From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619F7EE49B2 for ; Tue, 22 Aug 2023 19:11:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4D1D280044; Tue, 22 Aug 2023 15:11:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFC77940007; Tue, 22 Aug 2023 15:11:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCE2B280044; Tue, 22 Aug 2023 15:11:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AD9B3940007 for ; Tue, 22 Aug 2023 15:11:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7DBE7A03C6 for ; Tue, 22 Aug 2023 19:11:01 +0000 (UTC) X-FDA: 81152683122.06.6B45CC0 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf25.hostedemail.com (Postfix) with ESMTP id 5F7FAA0010 for ; Tue, 22 Aug 2023 19:10:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=5JwyMFYv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692731459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IQel4RgNhxgk/AAhqW/nAOn0kPiLXQfoLmnalyqIi64=; b=Jk43gfQj5hGBC2Bez7yDA8uLzj5hVy+yXkBn5gPf2pRlVK39KLoGrOtdiB34isW3fVlirE N2MLkkDRHWnwW+Z9ZAOsbKnBHCS/zO4TvVmEcGkdxH9x3v+cFl0kZmQn0fhwSTGl4WPCFa rIvHdQPFVysgLmTCA9A47AIT+pCiaKI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=5JwyMFYv; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692731459; a=rsa-sha256; cv=none; b=EHfmNaCjhGcroojVcWHMK9t8KJZu85ytJ/wUk62EUiMY6sUY6JuIkD8nWM2RFZQshnQM9K Z0Dl6408GqTYDKqjon9oVyg2mkYmO0YT5jFCB1EruSED8h1TwBpH/6lCErDuL06fkxcxbR BChMMREKSnlrwTxCM/8JhUYPOVdRfqQ= Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6bd77864e05so3467678a34.3 for ; Tue, 22 Aug 2023 12:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692731458; x=1693336258; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=IQel4RgNhxgk/AAhqW/nAOn0kPiLXQfoLmnalyqIi64=; b=5JwyMFYvi0OD4mdojayyGpwSZHcbAytYeAtnE7MibV1tAF6SgoCLsB//DV/hGRQAf7 c4C+blWdMkYvJc5z/BVKEJ5IO13eri+1BtevVsKnvLaTD0O1oCgAeAaOVhrQvoXQwzUi FBC2QlGTF5PlDsr4019zQfHrYKg/N1lROVz9wLA9UOxemfMjOKuBFTyvg9J6UQWemZqh EC71Try8JOZukw4l9uc4A684zGu0e0Yg8X2MzLul5fftKIL4CdzSe+XLcMUDEEtfVtw9 faYRmXMRMpla6ypOplKeSvwwVw7kQ3+VXDlAxf9mlnlIrodzJQQoglYgHfUHMzTtX58w +8lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692731458; x=1693336258; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQel4RgNhxgk/AAhqW/nAOn0kPiLXQfoLmnalyqIi64=; b=X5LjK4DADebg6135KQTUcFwVlEtUlS3VfTqY63q2pM7wg2dlifejPoEDorV42F3c23 tfDc3kXMnIgyYF5KKLGu2U5kFU1Dqq/eD2/o03yMF3xwT5D+QKXIpKmCGrO3ysWykhhg /yhIO5BUgYCraz8H0IYliJpAqKj3paA2o7cOK7NRzeuqey8QYcenhdifTenhED44a292 d+/8Cf7LQ0rdX83k/vAc79+eCUrmnPclqhrQsooglEaU5c+CE0nQYeLx5fn5/lMQTOCD VhgPcZ4llOMdBV4Tnzks8jeqQuUpHlfFFTxGp/G6PTJCa9PVpC1TukoCwIfxEPSlCoXj xB6A== X-Gm-Message-State: AOJu0YxSlbqwpM7H8N0+J1aHQttmxqoblzpgkpSCpJSJkt76bACXtJbp OidEAyBibQvVjRw7JNFeIWj3kA== X-Google-Smtp-Source: AGHT+IEBm3m/LaDBf/1DgkyNDU6zxtVn+hbaxrHnTVvmv8dzjr9ChOJoftygo0pLRcze1/DlIgis3g== X-Received: by 2002:a05:6358:33a2:b0:135:99fa:a125 with SMTP id i34-20020a05635833a200b0013599faa125mr10540178rwd.1.1692731458157; Tue, 22 Aug 2023 12:10:58 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d74-20020a25e64d000000b00d7360e0b240sm2487223ybh.31.2023.08.22.12.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 12:10:57 -0700 (PDT) Date: Tue, 22 Aug 2023 12:10:46 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Matthew Wilcox cc: Hugh Dickins , Peter Xu , Jann Horn , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Russell King , "David S. Miller" , Michael Ellerman , "Aneesh Kumar K.V" , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Vasily Gorbik , Vishal Moola , Vlastimil Babka , Zi Yan , Zach O'Keefe , Linux ARM , sparclinux@vger.kernel.org, linuxppc-dev , linux-s390 , kernel list , Linux-MM Subject: Re: [PATCH mm-unstable] mm/khugepaged: fix collapse_pte_mapped_thp() versus uffd In-Reply-To: Message-ID: <3f926b9-ee3c-5cae-d7ad-9b3e1986bcbf@google.com> References: <4d31abf5-56c0-9f3d-d12f-c9317936691@google.com> <1b7c7056-d742-86bf-fec-fdb024b2381@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5F7FAA0010 X-Stat-Signature: dd7ar9ixsfzeijn84sbfgmkuacitktf1 X-Rspam-User: X-HE-Tag: 1692731459-89246 X-HE-Meta: U2FsdGVkX1824GjU7CohEFAErNrKdzRr9wvxmaHZPYJkNcz3lwtTwlRvt6nrYTTtahZLk3rW63XmjrYsx2JBRIoK695tGqNtJPNXJDYcPUbBHmNmj4tfK7qz5JssT2OZKGhmQiq1tER7R8qTTYOxrHlGbVtbBCBL/RUoWNfpTDh+PK1HDl/epKmWIUhzgv+OvddVaA2PsNsjUQ6+5wtqcP1OhC2J41iMtj4FxnWyYiu6m9k8Dt5HvBXxAB9rzpbqTEy78s+xqU9ux4oI+oq8QT/Sw4KQyAIh9MLebJsKlo2EWSeLYsHWBb2JYALMNxm1plqHXOopH1mPQiBW7I6JscNtWjieB+zJaJMV0OyVwtiuSqRv80SN13DRaneKupnt1j67S4p9h0+qionIZntHXSJ0h+GWBXFHKCMce500EZ/WoUNy1PLMv754nZAavLwECNOIZZy+kauC+FVYgCW0IWOxZcTw0XBbzXzZYLOuVciwbc8O8WwwYs+FEVIMBP3i2vTXu3X9v5DeC7vD6JmNzbP4SmQ+bq+ohgGBh9OmKRP4zR1Nj4+iyXxDhWSPmmRXu0rOxWaIWnpF8Kwf1utoYKsXIaLwePxhdkTPUIC1l37zxiG/Y+rFWJ3Et1u1LsL6yV+GOE5Em1Vs6R323VfwmTETl1pZ8Zxz0SGqg4qoITjhSlYWvi+ekjWvDm4ZrJzdOU+HtY3hatmqcRM0+B/LEMYL5cv1HnaFCrvKviAoODk7w3r9F20XycpUvq0pPd+0Km5NFCE2UJIgBaEzyabs5k1kk6pScPjADSLQsQ/QTRKr1u2AP42po3FRI0xAB2KYe1JD5wMj9mmRp30GbqnwK+vFDqZgtbHQGu3w6PnZhqnTtMPM1o/70r9dImwJ5HKjQoQniyN09rcIZ52klwl0LWKHFnbT1uTqCIJK40QmS/edZWKFlj85vOpCBbiuiJScx2/we7gqaorYuVaqy37 1X32hoLQ MwFGXXk4+63mma7n0uRX2GMnHKokf701UcIgsuvX40FEMVXzkhqTmFBLUvsO4fFiU7VXWz+oY3DPrAEacBfZ9sptvJrxxWec9a54RCfndXkidp9XvpNPgYuTphUaZRLMfyqCSqCCsyvcMARo1Ofz6eDf9ghX3xMQgUR0hSHGEmF8FGTlXUSIRRoG81vCW3SdfpWHCh/tj9eu7en4rAKaR5WBSWDIW3Ok7N76X5LYaJWht8T403t9E54LOSftZTrx0rV/P4Na2gMjUzL9egEqV45rEhLSyrhOGBdzZFdkGPG+DIQqNMXAvcJaSVXZmu0jq5mtp+hcb7nBSd5SVsvjXTqt7MCJEJXSP2KiwmiZ89ibZO6NLuooMf208G2EVTcvEj+dYe1umKc678qH25bZYxQ+zvpAIOvqyJH1YPbLZaqLrX9CC8ePLa+UN1GbFAbP4FsC0cffkHh4WGIBqKnpabkWilFYHeH/LDSij X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 22 Aug 2023, Matthew Wilcox wrote: > On Tue, Aug 22, 2023 at 11:34:19AM -0700, Hugh Dickins wrote: > > (Yes, the locking is a bit confusing: but mainly for the unrelated reason, > > that with the split locking configs, we never quite know whether this lock > > is the same as that lock or not, and so have to be rather careful.) > > Is it time to remove the PTE split locking config option? I believe all > supported architectures have at least two levels of page tables, so if we > have split ptlocks, ptl and pml are always different from each other (it's > just that on two level machines, pmd == pud == p4d == pgd). With huge > thread counts now being the norm, it's hard to see why anybody would want > to support SMP and !SPLIT_PTE_PTLOCKS. To quote the documentation ... > > Split page table lock for PTE tables is enabled compile-time if > CONFIG_SPLIT_PTLOCK_CPUS (usually 4) is less or equal to NR_CPUS. > If split lock is disabled, all tables are guarded by mm->page_table_lock. > > You can barely buy a wrist-watch without eight CPUs these days. Whilst I'm still happy with my 0-CPU wrist-watch, I do think you're right: that SPLIT_PTLOCK_CPUS business was really just a safety-valve for when introducing split ptlock in the first place, 4 pulled out of a hat, and the unsplit ptlock path quite under-tested. But I'll leave it to someone else do the job of removing it whenever. Hugh