From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7C1C7115D for ; Mon, 23 Jun 2025 08:37:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A01F6B0093; Mon, 23 Jun 2025 04:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 977A66B00AF; Mon, 23 Jun 2025 04:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83FA56B00BA; Mon, 23 Jun 2025 04:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 713706B0093 for ; Mon, 23 Jun 2025 04:37:58 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 19CE2B7DE0 for ; Mon, 23 Jun 2025 08:37:58 +0000 (UTC) X-FDA: 83586012636.04.C3FE9E8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 97906A0007 for ; Mon, 23 Jun 2025 08:37:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EziRWid3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TtlTV00Y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PtAp3ntZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aH8XsV6F; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750667876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PgJiopltFdnGzrRwoU2M0nfMXz1bXazdPNj1w8H15po=; b=Gg4yp+/dEXnSjtl4bL8+zNfV+ZcZeEn5SxIGw5d8+1iJIIPN09uzuCM/yiKA+lqPP6eKq0 3h4zkoMdyjwUG40NOknrKDPzxaWk08fmfRLnTlhfUQhUdnulqKM5WrJMSpBbBilfbMR6Ot FMt3yqc1YwvBRTP+GWV4N/v6n3lPAgg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750667876; a=rsa-sha256; cv=none; b=tCKWMDCHEDRdN2GT8W6UhiG9xzS8p4VXNmxfTArQrnsgBWs4+Aef2Ub6Go4CDZj+JY/dae 6D7TInQb1CU6lQOngs6AGUO1Pg/R0bJwLTAj/RoDKOlymFg9qOcpCxPswmJD4s7frs0OKu oInunnEfpRqdH1C/VIkOTnGp1W5B0Vs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EziRWid3; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TtlTV00Y; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=PtAp3ntZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aH8XsV6F; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E49D7211AD; Mon, 23 Jun 2025 08:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750667874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgJiopltFdnGzrRwoU2M0nfMXz1bXazdPNj1w8H15po=; b=EziRWid3PwTwA7WAN9w9LuyqRtncAAY/gwu49StwIPsqAerh6pGRQyjH21121BbpNywOlv nAH3Ww2JutK28Q43przoBaoXXROGP/6r+W3o5o3kwe7hd1m6OwI6FzpxNrH+AXIhyaqCpq 7iVQikYqTnu/IJNIftICSCZUV6l1vn4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750667874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgJiopltFdnGzrRwoU2M0nfMXz1bXazdPNj1w8H15po=; b=TtlTV00YO27qHJlN/N65LAz8yqVhv1S0F3PXJP4/tJ4cDO7vKlqP0rs4QclED5JSTVk4gC 59a0Uc7qA+Ytv8Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750667873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgJiopltFdnGzrRwoU2M0nfMXz1bXazdPNj1w8H15po=; b=PtAp3ntZXFA8McrCTcZ5D+UpZ3a/ngJMGH/LBeAGPCYq/QjuCwfc77yjX6dXmb33Lr+zV6 6rUEza69K6vja1yi6BandOy2YbAHZ1pikd1xv1qXala5uIanorRAKN/aZlfhuG/yWUeIdo jq13og/CjU6+XfU01bNpKmrmnWlpzNk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750667873; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PgJiopltFdnGzrRwoU2M0nfMXz1bXazdPNj1w8H15po=; b=aH8XsV6F9MliT2f8Ljw83vFvROp6p7wED1sKAEYvYLzOlBEct0+f4yOi4/Uq5E8LG0Y37V 32Oa5qdgz2dJHMDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C886B13485; Mon, 23 Jun 2025 08:37:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gG+ZMGESWWgVeAAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 08:37:53 +0000 Message-ID: <3f8da2c9-a877-40f9-b1cd-1e6455eae9ff@suse.cz> Date: Mon, 23 Jun 2025 10:37:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: prevent KSM from breaking VMA merging for new VMAs To: Lorenzo Stoakes , Andrew Morton Cc: Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Jann Horn , Pedro Falcato , David Hildenbrand , Xu Xin , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Stefan Roesch References: <3ba660af716d87a18ca5b4e635f2101edeb56340.1748537921.git.lorenzo.stoakes@oracle.com> <5861f8f6-cf5a-4d82-a062-139fb3f9cddb@lucifer.local> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <5861f8f6-cf5a-4d82-a062-139fb3f9cddb@lucifer.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 97906A0007 X-Stat-Signature: bu31okfkcyc8onincc95e3wqhs9hf7om X-Rspam-User: X-HE-Tag: 1750667875-528651 X-HE-Meta: U2FsdGVkX1/jd7C1vSMJhtrZKCWrcNR+9IqIKHY+Q1Jp7VWHipWyfCvXW+J3Z4pvJi3R2Hx33aPZKa4ttzqCweWwzOP5pHLriBXp7p2odUZwHhi7BzN+Ag2S9l3QUijzQyEr9uCC1T2ADIsZnbwShj8S0rFSi5MesRQ5KYb1qo9A6GR8CIXDMJ+dMW/sEutayT1xZe5EaLoqTQjDoh0SjM4qMkgYaI+WQhVZG0iEyFDKEU+cgZ8K5bH8YT4IZYZZHVNv80pOeyKNkvQUK9jVLwhqAExrygkWrMBGeqOiRAdbsKePrmcIrpPR0IfYuZd9LknDmzQwCKg5q0BKQDFucsX2cUcgiQhPuq9hF/CxDhI9UABglfBkrzjxCh4fQhirLb1i/SlI5gRa+Tw7MMDHL27UXHyXxRAtqyxGUADJO0gxWlsGplqryX4y2beyc+Yg0UvU9Avinx1BInJjoGghkFnEXNa7CxNd5hUqi4WBl2plhgPC0uhPMPREibW0WMmF9DAoa9xRpYvkaXnbDix/361QdGbb6dEiRn8GeNlElRXg8iv+cs6nO8OviInIYf0PBULF+4zpobpV96N3XHeZHCxhaFNL1e34vkeWMZUFeyCDa0LZM6WiTdWdrGJsnZNebHSoRJW71WZyK/7/HWkdl+hj5mzlIJVaWHtT2I111reCWRJZlndi+wQ31W/IXhuYXumUkV2Y1e4lg42LAAWbAbNCNc/XX3MX6KR4bJPDt22AMKbeNLcQFvRWsKVvpNmu9hU0UJG6H7kMTjmSIBzp0CLsEhY4DTRPMdIvc/fP3z2t4fXWmbUH9lETp0ksRNivbF5Ah+60BPwtND6JFbBaPkFB5EITJLsEBmeBu6FJ3Kx2PlHxF5MZyDVB9ex37HRRNxbJ3MIIe2Xx6KNF7sLdbgtm2P+HHVEfWbP4FG8843pa4VZnvEF3UoppoGSDH9hfuKJbOn0E3DQ7wOfWV7y WUGcyITp OGp4SOhKGVDjj3iq7ZN7M+OKGArKvsAOB8FPrheFOFnu2SscE+HZCLktUBmWPmnIAAX+XXbFhApGTnHAcQwqPOiiyKuuFEXWyv8rmre4pF1Zw49YpYqJM8/kcQxgV1wJpR2sS5ReOoUryW2GkADfRAETc9wRm9n57ZiGpZ3/VUsNAJsk4Qmnvq/BRZ7UE+/Lu136rpHIOhiuZMMz528M0TIX2p0Sb+6VJ3Q0rFOLo885p2kVXaFExVo+WxX/AjpBajzikuiRq4o0DQb/kA5kPCbQaU9b/3BJU6YmUvoJS5xdUObA5yhOfovmGXLQSh5w2o0nhKVYIhE/RrxoujvsRR+M94zl3n3WlPA/9xUXiK9bNoFKyEiT/Fvtolnv3PHyfYn+U9zAvZCLGHh8Tmxo5sdoBqA2t8DBH4yKg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 14:48, Lorenzo Stoakes wrote: > Hi Andrew, > > Sending a fix-patch for this commit due to a reported syzbot issue which > highlighted a bug in the implementation. > > I discuss the syzbot report at [0]. > > [0]: https://lore.kernel.org/all/a55beb72-4288-4356-9642-76ab35a2a07c@lucifer.local/ > > There's a very minor conflict around the map->vm_flags vs. map->flags change, > easily resolvable, but if you need a respin let me know. > > I ran through all mm self tests included the newly introduced one in 4/4 and all > good. > > Thanks, Lorenzo > > ----8<---- > From 4d9dde3013837595d733b5059c2d6474261654d6 Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Fri, 20 Jun 2025 13:21:03 +0100 > Subject: [PATCH] mm/vma: correctly invoke late KSM check after mmap hook > > Previously we erroneously checked whether KSM was applicable prior to > invoking the f_op->mmap() hook in the case of not being able to perform > this check early. > > This is problematic, as filesystems such as hugetlb, which use anonymous > memory and might otherwise get KSM'd, set VM_HUGETLB in the f_op->mmap() > hook. > > Correct this by checking at the appropriate time. > > Reported-by: syzbot+a74a028d848147bc5931@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/6853fc57.a00a0220.137b3.0009.GAE@google.com/ > Signed-off-by: Lorenzo Stoakes I've checked the version in mm tree, LGTM. Reviewed-by: Vlastimil Babka