From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCCEC77B7C for ; Wed, 2 Jul 2025 14:40:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14E926B00AD; Wed, 2 Jul 2025 10:40:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7FA6B00AE; Wed, 2 Jul 2025 10:40:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E93626B00B0; Wed, 2 Jul 2025 10:40:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D18C66B00AD for ; Wed, 2 Jul 2025 10:40:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 487701063C4 for ; Wed, 2 Jul 2025 14:40:40 +0000 (UTC) X-FDA: 83619585840.19.81A2014 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id CDB45A000C for ; Wed, 2 Jul 2025 14:40:37 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TgeDq7Lx; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751467237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hg5lB23m7WPuzqr3OHikhga/fPQ+cKPr7iSIzg3xU6A=; b=d/mdBU96ovsVKs1ipm85A1e0/FPbztmWEGvYv95skjbN7dUZSKJ0ZiKCs1Ber57jsIITuK 4LjgB8+m2qTDYeAJqm+dTm9uX3o40+iyNMHjjPoPq5ugU0iIf8WSO6PPbZKs8TIAunPSAm RMeUmxN4Gd3OtizGtfSU+Pxz2u3ntqc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751467237; a=rsa-sha256; cv=none; b=ekeBWnI/zRQhtw/nT4Qgr4u315TFqud9Vkdpkj3XxSYTXfhNA1T6wdW9ZINh33eRfCgVHY WgBZIUaH0sCn+mUOdfm7R8uSFQVWez9r5LK8lY7kr2E/D731CFTAhDlqTNNzaDe6w6IT8n 1KwVD19bxQNCEwAzKhdT5V8YtK+LUQk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TgeDq7Lx; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751467237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hg5lB23m7WPuzqr3OHikhga/fPQ+cKPr7iSIzg3xU6A=; b=TgeDq7LxwA9J1pA0aWqsC9TlBkXOWhLTw7miG9YRQY/A2GBazcd4O1KyZKIlCJODO4wlfW YbWriO8KPkfgwqa7G9lVlqgRvpQHS8/PywDfpox2Lyr9Z1S7ZJUKCnZIjHsBKqSbtcCbK3 +pqD/pMQXBCZyc29f9LCqBxFkdbf510= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-cHsbCFHEMS2sThU_pGqQHQ-1; Wed, 02 Jul 2025 10:40:35 -0400 X-MC-Unique: cHsbCFHEMS2sThU_pGqQHQ-1 X-Mimecast-MFC-AGG-ID: cHsbCFHEMS2sThU_pGqQHQ_1751467233 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-453691d0a1dso26424195e9.0 for ; Wed, 02 Jul 2025 07:40:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751467233; x=1752072033; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Hg5lB23m7WPuzqr3OHikhga/fPQ+cKPr7iSIzg3xU6A=; b=prlicEAXYw3PjUccKwyFj329bw6FaI6HSCX9Nm+2VbsiMoYMvQlvchIQ52u92AaUHI 5AkXomlZYXM/y/7/p2J6lWZVLtm33LieXDslnJx7CI31KnlENItrz1utmcx2LTC9KQiO xIUtMIrHMHGrlzubVwNtPkVfIZyGA12wIQKXBouL2DFCFcvAjUpkFI1ERT8jFeSXTOMQ 7oeh19y76l+S1QtKbqGPao73JDLTH3mgQT4U2vtlls/e/iuTQmhjf7GOnePg/3X5HHiv mQe2UGJtvAVL+A4rCSTghnrkChXFi8yoW9Oqy4gXckD+R8/09bmnAhFYTxUDnY6cHJV7 pGxg== X-Forwarded-Encrypted: i=1; AJvYcCWVNHUtfHe8LUQUgc+Yvsc3wGySEEKKejNKZQ7o8j6PsIISoT6joJemAL7SbSaN7+EQfLCpjWQxGA==@kvack.org X-Gm-Message-State: AOJu0Yy1f5nBQ4QvbU81WnIDU47JAik0IoIAFuSpxUFcyKpHq4+15fB9 I6vQ+0mxhY0d/rzCkA7JcxUrm3KfKbqHdIzuEBQUglt6qZRyF4hoTIXksPSIIpJFtYSw1S3WPWv UBZfOeJtlfhsAsmSOFt1osI7++SRnKie0KMtQKhYYEjjMTit2J6jdG3vOc8YlC9U= X-Gm-Gg: ASbGnctNY16WU6TF79d3w1txRrL4WxVdKRjRzZtBrEJsWD5WZFlldREs9keNXdjBgKY DSvuV8Ev1MgreVLsOWXDRElUgqzvWTjy159myPgFF81U/cJZcuy+3g5XD9IbgDN+cq5cLPagO91 MJilZCrHe6MI3ZKqrwDmLJj7GJIUb2rtFMYQ/3viJx42C56qACgwq34jCt1iPWU+JQVkhyvc2No /gK8l3fWQ7G3b1IAcC3eX89zymSGL1a694PKYkk97iuSAAD6V0RHgHjfCGIMLnBJQCaCP0RazWF aim4TppFNh9KEEqcQPgmSzuf4NljWeoTfkxADhc4RDXOqdHtWPeJO54= X-Received: by 2002:a05:600c:1c09:b0:43d:fa59:a685 with SMTP id 5b1f17b1804b1-454a3737d43mr32544395e9.33.1751467233206; Wed, 02 Jul 2025 07:40:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6YYN22MzNr+fR/PGtyiSJKmRHKfgu++F6yh97SVz8e8M7yP0kPwLbECiaMT1bm5RJjMuNkA== X-Received: by 2002:a05:600c:1c09:b0:43d:fa59:a685 with SMTP id 5b1f17b1804b1-454a3737d43mr32543985e9.33.1751467232716; Wed, 02 Jul 2025 07:40:32 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e6214fsm16412820f8f.98.2025.07.02.07.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 07:40:32 -0700 (PDT) Message-ID: <3f8d6f3f-f98b-4f90-95d5-f4a09d61c88a@redhat.com> Date: Wed, 2 Jul 2025 16:40:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang References: <20250702104926.212243-1-david@redhat.com> <20250702104926.212243-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g8AHciBP2juh6ueUNfJ3or39tdi3FwiwDZqyT0qnkW8_1751467233 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CDB45A000C X-Stat-Signature: c73aifh5n7jdbcoa4yddcjb3gahyr4ib X-Rspam-User: X-HE-Tag: 1751467237-795678 X-HE-Meta: U2FsdGVkX1+FbH0lQztMq70e/U51ipjK0CBSdIGjBwsLmjpVjr9cs05Mw4SwaERh36//apyAuYBpc2WmFmUdiLLRs87Jf90ZTvD0axgKzy5cy44AtEpiSouEbGJX71eEznUrkaWVX1nofgO4+NTLqXOnD4yQeUViM0vKDqXAW/ai/p/o7IPBG7HgdpvcxSJosImEinV/8d5ouvmy2R5NFLSByeBjq2sXXT/q+hWdQUDLlVNQ4KcqZVK1Z3kwU/DRplavBuBzv9+mvrjQbXg99mqjrhI8/IJ19/o04IEgnd1jTJXrLCRjBOKNypxgbgvJWJswChVvf56EfGKLbLGW3l1gCHpxYmDoZ2BJWC+GGB5yWbJy3HuHzMRbhPQEu1np3u/P6U8tWbgqDSccgTyVG92wFUK8Q4so5HURuLl3PTVs1TWzAX/o5Lqb0FmCK1FjuiTkSL/6ZrPumOtaVh9pcJ+u/G2KMGNmFHEns40zo+tXvStrrrEGqRCmCmsvZOewxI6iY4xtPHQ/Fse1r9r3QZaRbRt/VlzU7kNfBnPXY19DpJVxJdqCYzKEySpR54bnTMuIwRa5Zpz4MMLZxjcaRE72qnCSduygEWsOv8y+QasFGWr5g66R5zXfZSIMKJcmwbAZv+8150oe8OTfldsPzwzvQ9OH193G21XX75R9H7C9tMtkRrC5AUXwykrw0RZ4NpBEi8L227x4eBvGwVWzn8te9hDkcKWe2jlaGX7Y1trbdAw3QaMB4lk9pEDYngBqZWB2rKw0lMBN5YLwRTnUcZPi9LsgV3M/MMc/FnKgxEp9fwouoSk7hEyskT3ybjfQH+RbPx8y/40DLOweKnWssXJnreUvXXgp4FTOTeKPyFm5n/TVvGHjIa84DS/rXGAaq4xYKJlOyJc7cwsDUDXyszM7/PFKbLUjTkUPIxnj/x+3u56dTtJ/TwwUZYpYyBBnwSMEazcEKuWafQilunR OSBeX7GG kDCO0Zhm63yn5N+KSHX4HujWgrc/iXKPP0AOOVWIw4iUPRdv7t6UPNHqcO9Plrzqt9475Kzr/umMFP/s88+3qV+xF/9VUUWbUcaVFKGoaouZF+fv1SCmtOO4exc6Q/Zot5RywNmH0opJwKtzNHn1Ss8Qmgv4Tzm7MWHPyeYA/ibNrnVqbI8/fbh8k2tEYb8RLcmgNegLYeB9r8lyimkasgeSC4D5qOHeLnILlZhKhIvaDiDmR0FsLOa5I2mx30nONoDFC4iVOYaLnAM0eh8O5j+Dh++y98yrk2OAN0otiZEdM4uJxqmged7Ur5UJnA0BYgi35cEW0RlRwMyPkpO685I7LbgOp9+aSHevY06QnqWbiEwSVYVnSTMDyej+hErTZhdTMWtO63UJG6o6TYBPk6FBSt19avzvWpa4JT8+vfx5QMMJ0l1bfcKQd+K+JSNnS0JOHwIzxvknLc7FClpJKooxF9i5O7NGYAz14Rlk4zupdUMsiwiXAAdd8/93TymGjO3sje0TeKl+A7gHITH4lJfznSYqxQ072Dq49t5coGB5S8SCL+WLb05fduU8uQoWy9YOId7mlG5bi7ZY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 16:00, Oscar Salvador wrote: > On Wed, Jul 02, 2025 at 12:49:26PM +0200, David Hildenbrand wrote: >> Instead, let's just allow for specifying through flags whether we want >> to have bits merged into the original PTE. >> >> For the madvise() case, simplify by having only a single parameter for >> merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the >> dirty bit is not required, but also not harmful. This code is not that >> performance critical after all to really force all micro-optimizations. > > Seems a bit odd to me to have the dirty-young bit being treat as "one". > You mention that this is done because the only user of it doesn't really > care about dirty vs non-dirty and it's not harmful eitherway, so micro-optimizing > this isn't worth at this moment. > > But what if we grop another user which wants to make this distinction and > where it matters dirty vs non-dirty/young vs not-young. > Wouldn't be better to have it separated from the start? I mean, it's easy to add later if ever required. :) But more importantly, usually young+dirty is a moving target as HW can usually update it asynchronously. So in the common case, you really have to rely on the young+dirty bits from get_and_clear_full_ptes(), and not on the current snapshot while the page remains mapped. The madvise() use case is rather special in that sense. -- Cheers, David / dhildenb