From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23E6C6FD1D for ; Tue, 21 Mar 2023 08:01:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9CC6B0075; Tue, 21 Mar 2023 04:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 859FC6B0078; Tue, 21 Mar 2023 04:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7219A6B007B; Tue, 21 Mar 2023 04:01:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F4FC6B0075 for ; Tue, 21 Mar 2023 04:01:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CB5F1411DD for ; Tue, 21 Mar 2023 08:01:58 +0000 (UTC) X-FDA: 80592161916.15.8DB141C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 21222C0014 for ; Tue, 21 Mar 2023 08:01:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j55E7TVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5rCAUXh9; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679385716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ctS+eKV0U5OIdHV3xnU3MmgGcrolUtwAToziodkFTXQ=; b=61hvODPrRklfh6L5566z2w04pjhb/hA9IK3iL+z42tTbcrvUBxNgDa5a4/qKBosFVaF0WA 9ed2936SCXv695exajQHFtK5r/KNYB8cVIzZUlA9YXDuF6rqRDm3+cqaIS6htay+nhmPhZ ZQdRy/Lc5Eq8dk1tCdSHbpSV9xb4ldo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j55E7TVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5rCAUXh9; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679385716; a=rsa-sha256; cv=none; b=yNhptBCGuhEchY2xfUjw3jTFlZ+SHHHNRd5rRJe3bfqAL6VzWe6T8LQra9V5T6NdVaBuBo 7SeBdKLjGd8siSb63y/gFCQyRD1MPAKpqRlzlme7SbYk/TgIcTQU7lYCrsVWT5ZxjXyh7I KUY6Pb57xau8u0ABAdWlfNZYoReA+X8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DA75C21A7C; Tue, 21 Mar 2023 08:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679385714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctS+eKV0U5OIdHV3xnU3MmgGcrolUtwAToziodkFTXQ=; b=j55E7TVWuklZamsfwYqXgOHP+fWCAZ2tGRT5x7bQjlk1kBu2/SjlvPQw6E9FKUHaPudmkj un9PVnQw/lXKgrLiq7S2u/JanY88w5/Tk+l9hhYYU7H01VcAo5shYeRxIXLm/xZEZtRhff vjs2z8HcwLOtqdMVAeLA38fmOzlVGK0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679385714; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctS+eKV0U5OIdHV3xnU3MmgGcrolUtwAToziodkFTXQ=; b=5rCAUXh9BgcbPrucB5nQUS11Y73lHAQGezjezAFYeMah7RiMKbDcGyvQU+p0l3Ue93dIBM 2WtgWFX0ziQDQuCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B3D3A13440; Tue, 21 Mar 2023 08:01:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n9oqK3JkGWS6OgAAMHmgww (envelope-from ); Tue, 21 Mar 2023 08:01:54 +0000 Message-ID: <3f85d13e-5faa-ca0b-5ef5-79422bbae7a5@suse.cz> Date: Tue, 21 Mar 2023 09:01:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 07/10] mm/page_reporting: Fix MAX_ORDER usage in page_reporting_register() Content-Language: en-US To: "Kirill A. Shutemov" , Andrew Morton , Mel Gorman , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> <20230315113133.11326-8-kirill.shutemov@linux.intel.com> From: Vlastimil Babka In-Reply-To: <20230315113133.11326-8-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: bcti6yonn98g3mxab7f5cmp1qh6jtbzo X-Rspamd-Queue-Id: 21222C0014 X-HE-Tag: 1679385715-622884 X-HE-Meta: U2FsdGVkX18CGwV3fWQVtoXxwuq8kCtfzYek50RjIWbhtv+2M3JumDiUvpHlZ5BK+fA2M8TWx06lMopf/eJUw+r381vELyHrcSdHJCKHWefm9R1/JmO6z2d149ODqC1uOfdlUxBuuS22t8EKqdfuxs6Swp4QtzK16plxiKjTIQXPn70d6wLOwKlgnO1o4OxWp8a3kaCtLzrV7uNTMGzwTkylnKWU6+0nl7KKszwuW2HgvMladnSJbz5Num7LQo/ZP/gmA2KPVuX3UpR5QQnLuaBfJpqSaKBNTV9gew1n0SfB61O77W42lXMnaPzxceMl6Z3py2dXh41zQ6eHA377IAH9aQefQFMn7fLcDLemNNfLBeUuidWw3yv9uu9R8Z/WZRYfmotimXcePEXTIx+qb84crUbC6QZgW6aXNqHJ4jEGzDcyfqbo6NVfGsToTHv4Hwlp+X/R9sLeK5Vx6qjsJzcF3qc+MM3lwMfNty10VC+Zkh9BLQ4B8dDiUGfM6eX80/wd8eYbTBX6TT/qWsr1ELzpzuHf7FcRW1L4gR8FbPhtkvbL/S6E+jju0+ZphnHohd93nHGoQy1h/VN5CusenJdhRByoLGBryHeB2IUodEkX3f/2K8lFVauyGbpn6ZbxNp5vyp+CajMbCB2TzyJ67l/Hh6oc6M+KiREe/kgDLWUz9RDtCftUHTtBD3QfS+lyncAiRF+4d7l4Ws87XwOisppSjKk+jSye2wb9Rwkf/6Zr9v2gIxt8DiTob5otbcSAgS1sspNaHHQbJE4InE3QqMX8frZ/fWo7tqNUy+aZlIKD0c9QDqFaxPAVCL+aCNZqQQqY+0lf1dQ0OqP6lGMfA72O/7FMXg8Yj1q8oZwLMSUUvfprxVks1tKQlx7FB7G26lfXZVZFwmtyAB/2Pa527oCQQb1AQBdC5RPmq7MHrDqv+m40u7uCk9AZPeL/uqOtc5VcQAW6XkNrqbjSsoj cCi6zhYC ei++jKweH2Q7V/hP+rTwgbjxTujrZt5YLpdTOvmX4afPw/s/vzSf9vYtYmY4cZpoZsichrikwskQbIdDa0oypy8HM8Gx7TpCz2ex//PbbtRvHyO7LD91xKcBbxB8yDLeX8cYzxtVYRnb9IFQMZ7Ds6BRh3ZJD+BzlcbbelXejZIJeYBhCwlzUtL48S+5Vvk6GqRirCxd7GvBoeWAKzXfmMu7bFXmlN/xEA0Pepd0D22clztxZa3m8mJai5gvlFQOBdxMX7dnuqRD1MuVQFMlJhlNj7hvObqXdCATMDuKmVKXPyK6GhU4KuoTSFhCHAqXe0DBi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 12:31, Kirill A. Shutemov wrote: > MAX_ORDER is not inclusive: the maximum allocation order buddy allocator > can deliver is MAX_ORDER-1. > > Fix MAX_ORDER usage in page_reporting_register(). > > Signed-off-by: Kirill A. Shutemov Reviewed-by: Vlastimil Babka > Cc: Alexander Duyck > --- > mm/page_reporting.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_reporting.c b/mm/page_reporting.c > index c65813a9dc78..275b466de37b 100644 > --- a/mm/page_reporting.c > +++ b/mm/page_reporting.c > @@ -370,7 +370,7 @@ int page_reporting_register(struct page_reporting_dev_info *prdev) > */ > > if (page_reporting_order == -1) { > - if (prdev->order > 0 && prdev->order <= MAX_ORDER) > + if (prdev->order > 0 && prdev->order < MAX_ORDER) > page_reporting_order = prdev->order; > else > page_reporting_order = pageblock_order;