From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46ECCC4345F for ; Sat, 20 Apr 2024 00:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16686B0088; Fri, 19 Apr 2024 20:18:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6E16B0089; Fri, 19 Apr 2024 20:18:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E216B008A; Fri, 19 Apr 2024 20:18:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8DD9E6B0088 for ; Fri, 19 Apr 2024 20:18:49 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 091C7A081D for ; Sat, 20 Apr 2024 00:18:49 +0000 (UTC) X-FDA: 82027999578.14.2213712 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf26.hostedemail.com (Postfix) with ESMTP id 755C0140002 for ; Sat, 20 Apr 2024 00:18:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=x7KTlwh8; spf=pass (imf26.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713572327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7HwuxwPzmT/z3ihEcWAQkbcsMHdUvyid59MaSuYG0fk=; b=hQW9v+iRrl+SNhnbJ4aRM7i2AOl1FAY5KQVUgDAoAVFNj1+IwNOq61kOnIsxIop2R1ZLXF cw3NSJq/6khf/BGwepsZObmrJFKqsYm57k7UrWOUi1tSVGt0nLkhbaXHEhWabTzOOKa63d QrZ30ES1tF6HuPR6eYgXHIReJopheHw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=x7KTlwh8; spf=pass (imf26.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713572327; a=rsa-sha256; cv=none; b=e4y9LyxZT8PO79rppN1WWdrOQNFHYD3DKj3II+JWu+/h8k2SwFuVkDxdwVd/SeSWWWPKGH 1nyokm9P0X91s4Vj8PhGJ24nT7ge3GVbBWoT+brf3zJxzEMTsgg84n4JwyB/EAfHcDOChA 7DsvfqEpUIWj9n/XsrJ33JchT+97Fn8= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e84a894335so67715ad.0 for ; Fri, 19 Apr 2024 17:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713572326; x=1714177126; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=7HwuxwPzmT/z3ihEcWAQkbcsMHdUvyid59MaSuYG0fk=; b=x7KTlwh8reQMEAZNNDIt8z7J0wneyCEnvfR+9Yqv4hHaqSgqrdJFV4gsJ9/Ei7r5up m7lSpTY09RQgXpsRyMBY+mU2PBkYB5dAzDeFUboe1G5RunBt+pROA3dv8ofFGJivhR4y rRFvEg1PzqCAtk9KUwaKa1Y7T+jNNpTBkY3Gm2l55CP94tAHTpVtSKmgsGNz2XCehiJX ExX0K9/MuYsEB5cf8zGzKgYOoKigX5SmHHK7j6OwqidBKqH+sJcnKjn4RKF8ZeRYv828 qWcuevCyRl2pfSEp5GK5SQ2JZdz4alsNJnaocNNukClGDwnomR7A9298GvJYfw3x9qaX h5fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713572326; x=1714177126; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7HwuxwPzmT/z3ihEcWAQkbcsMHdUvyid59MaSuYG0fk=; b=sziWrEX+6NpWvNPmfSbccy2lH1dkUM76ndqwWj7rWPWQvwBubb7vn3q3axtxfuroU7 f9lUkf6IVyeP3mpUVZHH7F5Hq13PwLjfD3Om/Rl56tWSlDc8u/GLE90B3UDlej5DcjyO tF8IccO78PWHBdx9HwUe13XYSk0v/uDmqXqdz3JcGykrAU1bVr33makdAMGnqz4iUNuI pnBcWMkyckWvPO+HAeGhyv6d4PMnMVIMEh+r6w2Z3DkRhLIHEZbuxkDx4QQI0Ve2QPdv JAam3W8qM1jPGdge3r+RNRLA0xa/b2U9BanLlrmkYwueBQgzX29CYDn9qiVhjE6uJDAE 7grA== X-Gm-Message-State: AOJu0YwoAWq6jlp1d6i8M4a5WtIH1fbL7q2D+Ri9LD4JOeRqvS21Wdyq neqyJUVy1Z2nWFyoqDM1xIKZFuePHiKo5npcIoAA1uhb1sqyvvK0AiP9/sHQmw== X-Google-Smtp-Source: AGHT+IG4F01l9vOXAGAgTrRJloE92W55eOltoeObPXGlHwb1tAyTJhQcF9ONRTHfml/l8PjYgelomA== X-Received: by 2002:a17:902:6bca:b0:1e0:a7ee:18b2 with SMTP id m10-20020a1709026bca00b001e0a7ee18b2mr49126plt.15.1713572326106; Fri, 19 Apr 2024 17:18:46 -0700 (PDT) Received: from [2620:0:1008:15:1ed1:e8c8:9e4a:e624] ([2620:0:1008:15:1ed1:e8c8:9e4a:e624]) by smtp.gmail.com with ESMTPSA id fd16-20020a056a002e9000b006e5808b472esm3944337pfb.95.2024.04.19.17.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 17:18:45 -0700 (PDT) Date: Fri, 19 Apr 2024 17:18:44 -0700 (PDT) From: David Rientjes To: Jianfeng Wang cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, cl@linux.com, akpm@linux-foundation.org, penberg@kernel.org Subject: Re: [PATCH v3 2/2] slub: use count_partial_free_approx() in slab_out_of_memory() In-Reply-To: <20240419175611.47413-3-jianfeng.w.wang@oracle.com> Message-ID: <3f53b749-46b3-d1a6-8984-c8a3fc9481ac@google.com> References: <20240419175611.47413-1-jianfeng.w.wang@oracle.com> <20240419175611.47413-3-jianfeng.w.wang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 755C0140002 X-Stat-Signature: 8xt6h3dhge8ho3z1xc4o9fwhydo91dw8 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713572327-248628 X-HE-Meta: U2FsdGVkX19eOy2nP1KCPu2p4cGe+7H5OjRW+EgHdyFKIxab1V2Nc0tOQPZ5flWQqwLzY9xNI6mvIDj/cynxw0799y1swrNx48oV+j7SjV1jbxDkZaz8NVwZLrkXt7ZKNX3h8BYTrd+FTjzQEmQFKW4A0ePfIfPMMOKHXSQk8oNvpd/ESjhvOD1q9DzeGX8Vs05ma+/qT1J5huE9Y48RMxXsgwMApRF6HiT7JVwIu4zuL22HIOUbMBzw4lNZiFVbVhuHlts3KnisezgMp0A1Q8TkT6cEczrnW0qHLOqb5XPnTSXVHtIGDznSpXGaCmgQh2qJdxOmKx4FDXEh/QwqwXMKXY8qxtG3MS8yx3IVxNLtlC8M6CqkSNZQT+rd1kh9saJ/1oQNbbasN7cfNMtPMP4+fu1nqAlDOlKQJAmyUInVHHH1X/a2DCrz4lJ/6/Sz/N+cngoFEHXzvzvQRhrus3mgMBm93hd/7X1FQhuHiqDiKdxoIDxj0LTKcOCpLIBb4QCpMbXnX9QQCHO95JPVcAbONtxh0DX8JT8wAgxHRl4g77CnMnOi3cHsv6ErxWq1oycdkNLWlrr5D5gJ0pkjrKTXNxEiUJIVrhjtd5ksq4cPmC90gAZQ2PHM5pnzcaH6xBVGDl6Dthbind4lkDwYekRsKHye4rrgeoTveLUbsA6gd6A6dKTxhCxkyc6dGohNm4PKQju6AxyDIV+f9tYcR/DQE6MGNQOj+8xwgqcl1YVkSdS6Gd+252VY66OnmXjyi/yGpTrngzm+G5Wr5gSGC3e9U36LL9NCg2F3gzfyxbHXDSBk1T5YONkYte8IDGUNwKeo7ru5dyewuBFHo2JA1XDhfqxj3ypuQhuvEqg441mJPK7tV6SKSZLRbc/GXx9/0LbFzon0yIVWpd7aA4C8+NTDNwm1LqdXtZtLST6np2cElGypId1mMm7zSFbYsOAwJk7EZsDQhd6b5qbxnDB vvgDmcIl rFV/mMDX3DroSMcW7BXw3UEhJ5gaeiANUIic6QX4hgW3OY7PYJNgvHPOq2Va4lrYMkLtLf+wW7ioBj+l64Oqlrz40ReSFevbCXX57Uo6IHI7PcH/fTmLSK+HPTks+J8ZdPDVs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000158, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 19 Apr 2024, Jianfeng Wang wrote: > slab_out_of_memory() uses count_partial() to get the exact count > of free objects for each node. As it may get called in the slab > allocation path, count_partial_free_approx() can be used to avoid > the risk and overhead of traversing a long partial slab list. > > At the same time, show_slab_objects() still uses count_partial(). > Thus, slub users can still have the option to access the exact > count of objects via sysfs if the overhead is acceptable to them. > > Signed-off-by: Jianfeng Wang Acked-by: David Rientjes