From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CC9AE67488 for ; Thu, 31 Oct 2024 21:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 287046B0093; Thu, 31 Oct 2024 17:43:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20FF06B0095; Thu, 31 Oct 2024 17:43:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062E66B0096; Thu, 31 Oct 2024 17:43:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D175C6B0093 for ; Thu, 31 Oct 2024 17:43:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7976414044E for ; Thu, 31 Oct 2024 21:43:02 +0000 (UTC) X-FDA: 82735222248.12.65DA3D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id EC03520025 for ; Thu, 31 Oct 2024 21:42:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dyrkUvSx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730410899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pW3XyDUHYORo6AOcJmz+XZoymRl7jo8rGbI48Wa+FPo=; b=uiw3hJz6/7pZHiL8tg6mjOCNeTKyifXT+mu9Sujme/goDLDeLsOYRCL3cD0dQFaDmHTTIV /3OzrWG6aeDRVzzOaUkovPc0dgq/3InmOIqAdd23c88ijcOZEJDs+qf04S3MlZ+/P/q7Hm +HmvFBjNZ6Ifu0rduTb6vupOnasenAQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dyrkUvSx; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730410899; a=rsa-sha256; cv=none; b=78DylQi3klF1sVjbUNbImgK+wY7QwwAjkM1V4osPNuCqVvPdNZidO8mTQ+VpdJQcOYI8fU v32ipSPaEE/9vk8uI/ExxXZkAQtbUcMdgytCNztf3vorqEd/V1Aie7i0QXbBNvcau37Z12 lhUtALeJy/t4ywkyyCpR0QeK6j5K22Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730410979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pW3XyDUHYORo6AOcJmz+XZoymRl7jo8rGbI48Wa+FPo=; b=dyrkUvSxS1PcgNkRKuLx/EdfpVCbURtsvTxvQCyjN01rQhukuC4cWBc3UQPkBLru/aa5VW p+hdUmSTDIA4qafF65f6CfVuskkZvwBEUw0FyzDbTjpR2twijqwgTRGtsIYB6jbBuBsq9v bAD5k+ZhZmmadkHEwsO9rKspyqMb1xc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-EGTLXdW1Pe-4OGTpls0YxQ-1; Thu, 31 Oct 2024 17:42:58 -0400 X-MC-Unique: EGTLXdW1Pe-4OGTpls0YxQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d5a3afa84so672179f8f.3 for ; Thu, 31 Oct 2024 14:42:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730410977; x=1731015777; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pW3XyDUHYORo6AOcJmz+XZoymRl7jo8rGbI48Wa+FPo=; b=UX4PySsZRpATudXxkZSjZtfco5OUWRfDJzCu8yqopGbXRPz8zcJ/7TXVg+qqiM0AEg bRsU4VvM2pLHS7U1aUYBjzOZfIGwOzP+cY5/AvXgtDKJ9xZDDD7Wg7ceb/SlGIfN6aYB e4OzJWb75X/csBbO8I/Ye6bejDPK9zulh2vdsIvQiVYflMgyJFm9WSpTGiJrSmX5GM4R FP8KqdeXWykdWJFHvBKZGJN4YTq80BJ2UNoFG2tz+iEnwZ/MONfa21l6tzuNWmLrw0Zv URvhmEu7+4QW2phZtErAAa3FWedpwlI0D5gJGwFE8pmxL7/jdpMIcoT4FpbqY3n6ztdl eqUg== X-Gm-Message-State: AOJu0Yzn+0yB7bQF4D4IzF+LvcsrGwTMlPFsR4glPJuwA1mBfLkmE24z oeKYHStFZOtmsc429O6ZiyEsxyl5SKfq4972FMEO6Y+AoV0oEITrgbY1dvnfVZjEqkueL9LDgVr kuR3hblUqmDmR5EcIRbaJ3q7LvA1au46q34woh3I0E6bC7fwdxZS2ldium00= X-Received: by 2002:a05:6000:1a8c:b0:37d:48ee:d6fc with SMTP id ffacd0b85a97d-381c7a3a486mr986759f8f.7.1730410977374; Thu, 31 Oct 2024 14:42:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTl0vDqCVIRiVOmlOSF7005qO2un/95FJm+vY3eyjJtpJUezbnd5SGBC40r81fDAMHTh6rMg== X-Received: by 2002:a05:6000:1a8c:b0:37d:48ee:d6fc with SMTP id ffacd0b85a97d-381c7a3a486mr986742f8f.7.1730410976983; Thu, 31 Oct 2024 14:42:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe? (p200300cbc70aed007ddf1ea94f7a91fe.dip0.t-ipconnect.de. [2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c116af7esm3196878f8f.103.2024.10.31.14.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 14:42:55 -0700 (PDT) Message-ID: <3f4af429-1f60-40c3-bd7f-c8c5950ac6ed@redhat.com> Date: Thu, 31 Oct 2024 22:42:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] vma: Detect infinite loop in vma tree To: "Liam R. Howlett" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Vlastimil Babka , Jann Horn References: <20241031193608.1965366-1-Liam.Howlett@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241031193608.1965366-1-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EC03520025 X-Stat-Signature: 5sep63n43hiu3we9mhgmnprw3ix6x9cf X-HE-Tag: 1730410951-518724 X-HE-Meta: U2FsdGVkX18hEh+KcgoRBcsqRPVKfiaTKXb1VWpfrLbya+fls7xuPv9XXDxL5yh/wiZU7oFckqCbBHV46hYm1S8eOnotd333XOhhUtG7U3rByN8nOGZAWjvx/tKxHakNOaKdpBTFBZQN7q6xw3suB6AgeLao8J4bNu4vzbSxeEyswE+TY3QZPI8jRRPRhRCgwo8ewALkMqFMrIVVx384d40SZJrOurfNb/+uS9Na9OBIdVREtuvEoflpE44umtVtA7HGdX2yiSsnswqXR4n4s94M3BkGbN2RPGa4L+t4cihekH+JVGgxr8KkBJj6LGa15Vn/mX6ESLhN5V4tFut+k7LmGkU2TNN4wvPXDcQvZBdzQ8nqt6eoiJ7b15wdlF9R5clDviywW2WNW30f9UTQjRNsDQvzRyxE3xGcH6tdJfFZexQ7czLwgmvBIksX1FFJZ7+V9RiHvDoW88fwNo+xUlNWVDt2z+JXB1cxcdeLFDTjK7Du3FAsk3mUz6YcjG0HIb6A61VhYDwS5jK5ONN/NMcIgoPz9F19ut9c65cZia8gDEufYD3+62IglhJS3WwH6NvVAzhHCxuLcnrlILw5K4l8UiHRW2tLsFOnabA7s2lWrV//o98oNmDzjItKqWwygOws6Y3iBNUhZBQXY5PcRQ3/7YvKzyfgCKGLjZluJHTaaGIs/CP26QWqG9LoxB0oLbBxJoI3HEM28n3atz8ZmMFKqAVLJKoBGJZuPcznDa0Se2ubqaMpriT6l2xybQND86D7XqbS56ZLzYq9Kk3WsMo0UZyvV7fi86aWH8UvDL40tQI/WzzBQI1Nugo9q1yEBXyoLAfOeK+rfSH42gS90UfGsG6ehCXWza+6rjILFqKL3bf6QaMg2v5naB7RCbPe8e3kGiXCc6l/+cGb2yZ8R7RKGBThG/JciyXDuDbYukDbPdKGlvvoferi8CLE1/oHpKNzT3lla3x2KuBt4QB hd5gCr8m po36EPhmD84KC+MkzDVE0ww4Vd7SNbEa9bH8aHajFf3J6CxNFxmYiMgJ0skjt79vDg0fy8MX9Z1zbj9Oaxcw6WyE520lkYWmeLURDRWFsRbNkElwxUnatajCJfujQt0sdUV0pdZJfIUyXb1/S/rN7TgePK36IYtozn7t+WQWBi+deHNpIeY/BFcJPRwsTIkbzwEq72MowVzVeDWPhpdxXk1pJsFTCQjz7xd2y8qbQnxu1ZqiLEc/i/0bB2LvhReF/31H9GoiteF5jnHyP48/hNRbKhtqbhdy6f0LVi2+NbTeKBMc1ZCUKbwzCldxYpGnjLOTTeCOmZWU7B7wbpTd2YvNeJe70O7xmd6kkWVJuARP1KWcJVE3CO4xSgkIPdmXhDSBTUpe+FT9hNSGS58Fe8J/pSaF1PQZRSkg4aOl9GX38lEXfjx5TCmcCWdxfnmmJZIj512t0M6Q+I3np6xFJD4v/QQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.10.24 20:36, Liam R. Howlett wrote: > From: "Liam R. Howlett" > > There have been no reported infinite loops in the tree, but checking the > detection of an infinite loop during validation is simple enough. Add > the detection to the validate_mm() function so that error reports are > clear and don't just report stalls. > > This does not protect against internal maple tree issues, but it does > detect too many vmas being returned from the tree. > > The variance of +10 is to allow for the debugging output to be more useful for > nearly correct counts. In the event of more than 10 over the map_count, the > count will be set to -1 for easier identification of a potential infinite loop. > > Note that the mmap lock is held to ensure a consistent tree state during the > validation process. > > Signed-off-by: Liam R. Howlett > Cc: Lorenzo Stoakes > Cc: Vlastimil Babka > Cc: Jann Horn > --- > mm/vma.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 68138e8c153e..283e6bc4884f 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -615,7 +615,10 @@ void validate_mm(struct mm_struct *mm) > anon_vma_unlock_read(anon_vma); > } > #endif > - i++; > + if (++i > mm->map_count + 10) { > + i = -1; > + break; > + } > } > if (i != mm->map_count) { > pr_emerg("map_count %d vma iterator %d\n", mm->map_count, i); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb