From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B564ECCA47B for ; Fri, 10 Jun 2022 07:23:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A7628D0080; Fri, 10 Jun 2022 03:23:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 357368D0064; Fri, 10 Jun 2022 03:23:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 245C88D0080; Fri, 10 Jun 2022 03:23:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 169A08D0064 for ; Fri, 10 Jun 2022 03:23:28 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D71C434D0D for ; Fri, 10 Jun 2022 07:23:27 +0000 (UTC) X-FDA: 79561485654.31.BBC2552 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf19.hostedemail.com (Postfix) with ESMTP id 3DE6E1A0051 for ; Fri, 10 Jun 2022 07:23:27 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LKC7c4m4jz1GCCL; Fri, 10 Jun 2022 15:21:32 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 10 Jun 2022 15:23:23 +0800 Subject: Re: [v3 PATCH 3/7] mm: khugepaged: remove the redundant anon vma check To: Yang Shi CC: , , , , , References: <20220606214414.736109-1-shy828301@gmail.com> <20220606214414.736109-4-shy828301@gmail.com> From: Miaohe Lin Message-ID: <3f485480-9474-4401-bc4f-fb66aac1e591@huawei.com> Date: Fri, 10 Jun 2022 15:23:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220606214414.736109-4-shy828301@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654845807; a=rsa-sha256; cv=none; b=azUvVTst0PIyR7RvU8QPe6ce7YJ41bDJcXu3QaoS41jJZ0ox3IgDO5TWi8AENLt3HJuvxG S/oVQrJk5uE5mmrQqrm6ic20w6HYSRbHAPRj1whw29Es74Q86NdhrUYgc5fqBBGFwv1wOr iakXncsJWe7PdrNd+59LJoyG78GfJlU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654845807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Grt5n3VdVJbtRvf4cZZ9k+Kvbpb5XzxMgLrgLLD8um8=; b=ehj2bSvfLr1j+T1TFJOu8hShOMmL0yo0f2+L/8Zk4knCN2xF2kJ0JeZ1KiA8uUmbBuhtv9 7MlqICLjAuK9edVLmL84PYfNl3wvwIrDOquLs7LFPbLR12MutWrt+RjrH62XrrceZLf/QS JmJT2aiTCdRDaqaK+92seenAZ1RFewY= X-Rspamd-Queue-Id: 3DE6E1A0051 Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: mi37ppswo51g6zzs9hp7a68b5qhgkjuq X-HE-Tag: 1654845807-959945 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/7 5:44, Yang Shi wrote: > The hugepage_vma_check() already checked it, so remove the redundant > check. > > Signed-off-by: Yang Shi > --- > mm/khugepaged.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index d0f8020164fc..7a5d1c1a1833 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -966,9 +966,6 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > return SCAN_ADDRESS_RANGE; > if (!hugepage_vma_check(vma, vma->vm_flags)) > return SCAN_VMA_CHECK; > - /* Anon VMA expected */ > - if (!vma->anon_vma || !vma_is_anonymous(vma)) > - return SCAN_VMA_CHECK; Is it possible that hugepage_vma_check returns true due to the shmem check, or file thp check since we dropped mmap_lock ? So anon vma is explicitly checked again here? Thanks! > return 0; > } > >