From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFA0CDB482 for ; Tue, 17 Oct 2023 14:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 865248D000C; Tue, 17 Oct 2023 10:39:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 815556B011D; Tue, 17 Oct 2023 10:39:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B5DD8D000C; Tue, 17 Oct 2023 10:39:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D8D36B00C4 for ; Tue, 17 Oct 2023 10:39:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 183AE160CEA for ; Tue, 17 Oct 2023 14:39:15 +0000 (UTC) X-FDA: 81355211070.27.5AC16E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id AFB4B180003 for ; Tue, 17 Oct 2023 14:39:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BSqxnAdQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697553551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bSH+w3rTE+Pz2hrnXmquLWhpkJX2eVVDKFyhnXENtfM=; b=g7BLAFysWV9bEjZIBYqUAHjuLmt2Ao2hwqJvx23YRiHL7XX8mIOaiDnspDtlAhPS8edCZm 1gJCoftuP9dp5/n/BBQUTRwhcd5tfHYvXZPBY7p8Mp4CaheCpQCBHe5wMbVKadtf746HgI Xz/mBB+irQbpzsdcl5mPDlZsdxJ7oBM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BSqxnAdQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697553551; a=rsa-sha256; cv=none; b=1TrciUchwTkFOol73jlbJBeFuBl7XwLlYQBbmazboBafWbM0zhwx2C4kdTenP56T8zF0NK c00RUYqpTbjMN1fP9wePnN20ML/6TkqLDWXzxkW7PEsH0lyhXvltFeVoF32OP5K3IMT5IS FUdxfAlNCc1QK4skZQl5NWuEIbq1kMc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697553550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bSH+w3rTE+Pz2hrnXmquLWhpkJX2eVVDKFyhnXENtfM=; b=BSqxnAdQwubPbucnz68mfiN7Q3BQs0tsXFDEaQV9S8P04BQHSjNH28YzCDeI/yg6DO9Glj +3SVwQgdv1FZFaxwM/BiLkSyexbNYjb6fXFXct4kicy1xnHfY89jH2kxW/lKyFTwbxOwH8 c39S7uDkHnAyVikHP8Ey4AWTRZAfPAU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-hgz3rBbCMY6uriUGucPtcw-1; Tue, 17 Oct 2023 10:39:09 -0400 X-MC-Unique: hgz3rBbCMY6uriUGucPtcw-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50433324cf3so5932737e87.3 for ; Tue, 17 Oct 2023 07:39:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697553548; x=1698158348; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bSH+w3rTE+Pz2hrnXmquLWhpkJX2eVVDKFyhnXENtfM=; b=XitGyCJLsm9rg9oa//1/yiP5QkyX7k61JOqsL2Km0Y2yOO0n9syOpMCl7LUjp2Pi32 pLrCXKYny2CNiv6e0qJUv3z9YseU/2IZ1MBv84wNbXZkPSvdzPgUyOdf1ALl1rqR9Mcr NJsub/Rddusq+bQyI9pkUichkYPuDJNVuKG3qT5v9ZO9uM374E1BZA9X3USWxOpgHo3e jwyeShTFcafDNun1KRO/q0isBgFSvTjWtmIzya5MGR0W4/d3JlPLHn56Itg7/QF90e3O DxEc7JFh6dsmEO9sHkXo7VOBoSLVMYsdkQef9m47cYtGa61HiI8+b/pJ0CRaV+zx1WRR aC+w== X-Gm-Message-State: AOJu0YwsFVGr1W+aG9EbhSFLL43lkLy0JwHtkfebIIIAqpzWj4ZCo5ZS aF9xn8TcZ/TQBq5hqfBCyLlj38MV+BT30UIsgb17zPSGW4yQCnA7vRASVvybUGM3XY/5U+5QWH6 uf8rmsmjgIlCpRsWRcz0= X-Received: by 2002:a2e:5411:0:b0:2c5:d3c:8f4d with SMTP id i17-20020a2e5411000000b002c50d3c8f4dmr1717289ljb.13.1697553548163; Tue, 17 Oct 2023 07:39:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEeceyQoPLiG2ln4ABhwORc+ArpMpSl7lmpoS7xFx4O4tt+9zctlS/qeDjtsG4WynsxDTQVVw== X-Received: by 2002:a2e:5411:0:b0:2c5:d3c:8f4d with SMTP id i17-20020a2e5411000000b002c50d3c8f4dmr1717260ljb.13.1697553547724; Tue, 17 Oct 2023 07:39:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:5100:93b1:f654:ad11:cd81? (p200300cbc743510093b1f654ad11cd81.dip0.t-ipconnect.de. [2003:cb:c743:5100:93b1:f654:ad11:cd81]) by smtp.gmail.com with ESMTPSA id l4-20020a05600c4f0400b00405959469afsm2125712wmq.3.2023.10.17.07.39.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 07:39:07 -0700 (PDT) Message-ID: <3f46eefa-6415-4d7a-af91-eef898d4f77a@redhat.com> Date: Tue, 17 Oct 2023 16:39:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] mm/memory_hotplug: replace an open-coded kmemdup() in add_memory_resource() To: Vishal Verma , Andrew Morton , Oscar Salvador , Dan Williams , Dave Jiang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer References: <20231016-vv-kmem_memmap-v6-0-078f0d3c0371@intel.com> <20231016-vv-kmem_memmap-v6-1-078f0d3c0371@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231016-vv-kmem_memmap-v6-1-078f0d3c0371@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AFB4B180003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: e6km7gorr74qzjjnx3t65brabxqyccg6 X-HE-Tag: 1697553551-904851 X-HE-Meta: U2FsdGVkX1/neOVMDyfCRQ2lU8+oqYURFVozK8pIDe8nEUR0QRkb7Piq8IeeJA0MGCR1boN0K/6yn7V+wIToonQqFmjPoxZG+ILCQbCmkLC29K7NmI+WoxjcJwWIdIbDE1CxTQl/p5OcLwWEDEhsQhldCwdY+Q562HSLPZ1aBD+71/L1RAAdEqJnzaEHTTtlC2EAN4Mmw/Z5jcPUft88O7sAsXPvfnCRj49famrkOgC780izJeYqGhc86+2PPwJyDR8NPcKzLemPSNwQcvN42Piw5xZgl3rg2s3Si4lvLrIAg/d74vkCmkn3APt3FeUkWKiLQDUlPD9B3mhZ4UqgAvuLAWtH/9k2K+3lKf5N8krA47afd3oEKC1v5tehPq3kXP9inTCFLAj7GRfz2PpkhdzY8+ieDdN2dUz8qaVcL8HZ+cJbvK1z/2LmvdBi1D2vxXP7BRgLIGlJuKxIf1B/E2QKP/IbE2Ig3zO4+rtZ15eLslkpyRjJDS9Q7U+8xApHfvwEZ1D98+6VuaDizgfKKOlbm94kUF78bT42ILR+UEAP6h5GKZSsx/vaSI7qjy7LVLD0h7d0ungM/cP+7CLg85ZbdTXM0g1Y7QinnhWRhLS2A5mPqs0gK3JW6HtfaCQv6VWwz2MojgE0Lb8iQKrxm1P9ZxxJ2hKRRESERnre+pPGdIrNllYN6kt2/S4fQURNbRwBIlsiY6OeKF3MyPPAkdcAqAh+MGwdxBYpmJRGX/Zpj19yxrfZBSMdHXdDwjsd9nAzn1yBYQY6UnLPpweV7ncJz1M0j/ylQq45HT0BH0Xg/Ybv8uYz0keBAcA+4HQhk5LPeInpYd2QcvqrlHXDe4CHiohU2kwEzNliQEI+Rb1wygKshouo34FG+VCCYlOlzZr3nMIJ5HkcA0YhKUWy3k1kBOmXzNyCIEcyNIvHbZwWqDratWUTZ9J/718VQWp86N4JyCpsS69zpMStbXr IMsekw9d Zdsm+6nQH4jefTp0pC5ZZ1K33phK+DPaEXpMm1sRCnG4IVtqslgIzLgY7WBTaJyMFUErXK1Me2U4ixKZOTyoQSCbQOUd8wFHA0a9X2SDkWEjzErEGkt6T7t+aV6kvdmq4KWTA1ZbbJ0SRlLkB/i4EBUKATgljOoHlNG7JMtwG1ima5pNSWD6ImnvQCLhns9fy5EDY+QZ/15jSqIfNQZ3YUMdb5pL8iN9ppmZaKTweG4rR0Gpu3fmbLMuAu83cd2GJ6R6hbDOzqMRszafiBQrsEYrxbgQJxkEfY6nJV074KWC1MmFDmmwhgE1cXh+rB17yBdhmXnR9p52NkDtju5GD2wlhbwz2DqmVEgwo9Ul1vlh6bd9TOy2Mf8CEquWlpA+9D+KCe7Q5wWLjeGCBLjG6bs0Dlh7PgO/GjqhACfyj7VdesBEUjncCr7Rj1Ihfwt9vwptAK5O0jrnWZDWPQyJfS0YMBG+n8smS56CFC5FA5qoAKShfWddHCJMg66tzWKaZvNUoFkcmJWwDdnBLc0ooOBqq5r2WQK/LIQlnlOOlZChnUplR69Px6X/DdBGVkcqc9MW24KSszIUG1Ygu82q/S2BA5pDyQ9LSJ3EOg/BBwdsLIoEzyb8AdqKF7QHO0KFLLRl7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.10.23 07:44, Vishal Verma wrote: > A review of the memmap_on_memory modifications to add_memory_resource() > revealed an instance of an open-coded kmemdup(). Replace it with > kmemdup(). > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Dan Williams > Reported-by: Dan Williams > Signed-off-by: Vishal Verma > --- > mm/memory_hotplug.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..6be7de9efa55 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1439,11 +1439,11 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_flags & MHP_MEMMAP_ON_MEMORY) { > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > - params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > + params.altmap = kmemdup(&mhp_altmap, > + sizeof(struct vmem_altmap), > + GFP_KERNEL); > if (!params.altmap) > goto error; > - > - memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); > } > /* fallback to not using altmap */ > } > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb