Re: [PATCH] selftests/mm: Have the harness run each test category separately

[Lorenzo Stoakes <lorenzo.stoakes@oracle.com>]

On Fri, Jan 23, 2026 at 12:35:06PM +0000, Mark Brown wrote:
> On Fri, Jan 23, 2026 at 12:09:52PM +0000, Lorenzo Stoakes wrote:
> > On Fri, Jan 23, 2026 at 11:21:39AM +0000, Mark Brown wrote:
> > > On Thu, Jan 22, 2026 at 07:13:06PM +0000, Lorenzo Stoakes wrote:
>
> > > > # IMPORTANT: If you add a new test CATEGORY please add a simple wrapper
> > > > # script so kunit knows to run it, and add it to the list below.
> > > > # If you do not YOUR TESTS WILL NOT RUN IN THE CI.
>
> > > Is the Makefile the place for that or run_vmtests.sh?  You don't need to
> > > edit the Makefile to add a category.
>
> > As I said, you have to edit the Make file to _add a new test_.
>
> > The point being you will necessarily see this. It'd be fairly odd to add a new
> > category without adding a new test.
>
> You do, but adding the category is actually done in run_vmtests.sh and I
> can see someone doing something like adding the test to the Makefile to
> build the test while still developing it, then going back and hooking it
> up to run_vmtests.sh when they're satisfied that things work and
> deciding at that point that it doesn't fit with any of the existing
> categories.

Right sure, so maybe worth putting in both.

All of this is pretty icky but it's important to get this running ASAP and live
with the ick for now, we can do something better later.

>
> > And since you'd need to update the Makefile, putting this comment at the top of
> > the file immediately next to where you have to put it makes sense.
>
> I guess.  At the top of the Makefile or right next to where you have to
> add the tests?  There's about 50 lines of setup at the top of the
> Makefile before you get to all the TEST_GEN_FILES.

I'd say right at the top, for both run_vmtests.sh and the Makefile, thanks.

>
> > > > > +TEST_PROGS += ksft_vmalloc.sh
>
> > > > Is this something that only kunit will interpret, or will it impact the
> > > > build in any other way?
>
> > > KUnit isn't involved here?  This is just how you specify which programs
> > > are run by kselftest, this is a Makefile in the kselftest framework.
>
> > s/kunit/kselftest/.
>
> > I use the mm selftests locally by running sudo ./run_vmtests.sh directly. So I
> > don't know how TEST_GEN_PROGS interacts with anything else.
>
> If you're not invoking any of the kselftest infrastructure it's not
> going to do anything, nothing execept make looks at the Makefile.  When
> you do a build it'll result in the specified binary being built (and
> installed if you ask for that) but not otherwise interacted with by the
> generic framework.  See:
>
>    https://docs.kernel.org/dev-tools/kselftest.html
>
> for the various variables that the build system has for suite Makefiles.

Ack thanks!

Cheers, Lorenzo