From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16457C4345F for ; Thu, 25 Apr 2024 09:49:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 935C36B009E; Thu, 25 Apr 2024 05:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E57A6B009F; Thu, 25 Apr 2024 05:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 786356B00A0; Thu, 25 Apr 2024 05:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5ACEE6B009E for ; Thu, 25 Apr 2024 05:49:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0EA46160CB3 for ; Thu, 25 Apr 2024 09:49:09 +0000 (UTC) X-FDA: 82047580818.24.9807F89 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id CE7304000A for ; Thu, 25 Apr 2024 09:49:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=URnR2pCl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714038546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GKBFsR/RCnSpY4xrv9ThDWcnYwVADdYh48FaX0VKOQs=; b=FgephIKjzSOjJp0jVEnWImC9PRIXFu//Dm2lq838I6vrnAwi9UAKWQ1fC0RH4+cIbOxZp7 9VIdd3H+vQwC4Fx5h+E2/DtVpo9yZqNDgunT5WArKEAUfKF3yk4e4iClXAMHrcBtDfA3AP E+hkAM29IAfhqRXh35pLNQIYMV2Y3gU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=URnR2pCl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714038546; a=rsa-sha256; cv=none; b=FLzuScApM2Dv+kTTwFrPVaJjtdQ44aLwyrJIvxi9uJFKHbZgbn+vhnhjPSli8bGHy2vMYY I+bFM064fYR97xM4Hfp2h46/aUNzHv3m5gSgyYz8058KAhrrNsl4C8mMSpKyAr4KAxyn8b xCLmpm9F4nrY/xWgo1OvCOIUQX8u8mc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714038546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GKBFsR/RCnSpY4xrv9ThDWcnYwVADdYh48FaX0VKOQs=; b=URnR2pClumdjOzYIlj1HVjktEMJZ/FBqWFaVLXk1H04Z1Ch2MZe9ks1huJKdI40HC4nTRV j1NMcXwxheLHO4LYq9cHTyh+SDTYVbzKkQkgpDrDhl8hLSo3N5plGC1Lfac9NQ+UcJ57/K ADo7f/PwXyKFOIrxjn66L3+pBEnLncQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-jLmbEA86MvuuR-0BgnjI8g-1; Thu, 25 Apr 2024 05:49:04 -0400 X-MC-Unique: jLmbEA86MvuuR-0BgnjI8g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-419f4192efcso8594915e9.0 for ; Thu, 25 Apr 2024 02:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714038543; x=1714643343; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GKBFsR/RCnSpY4xrv9ThDWcnYwVADdYh48FaX0VKOQs=; b=DgKEhLUzrPEI/6R1I2swi8NiNOR8BM3Nu0LmJ3inqy/4JvBlKO53G8/mo6C2QX5zxo c9TAkCsmu53lS0AUTmmmWY7FLA4/lM9H7YqC1x6GsIMsgnfWz7tglQewU6rAvhlRL4Du QACnpgSz7GJYDtUKluvJiSYewyXbXLKwrxKxgR3EyoDJmszGG8BJUZECFWIJTy9n/lqO mp9x6XOyEomfAz9RowT9ykZdlrp+YMHwnNAs7cRXKhlclPvZdjI6UFW+3cKfxP2xqVIi xwnW3qpi1JcJBdezhzBsOWM53ZJwACMVkBEHJVn0wUWSSseZ0zcnCtWlhoLYTgICQjrJ /cWg== X-Gm-Message-State: AOJu0Yz50vySXaLG3efJsjPilcPzHL0vstiUaEgfF7T2E71nZV9bba9T F2kfYu5C94jBd9hVfnMiiCRR+Fcbif2aIlaM5z0Lq4eYqCBC88v+1f1qQfiuPa9TYz0y+KvLDmA 6aaTInq96Fg3S4MWXh/9otxzYFbynOpzDDirMZ644ckk8O5i7 X-Received: by 2002:a05:600c:5246:b0:41a:56b7:eb37 with SMTP id fc6-20020a05600c524600b0041a56b7eb37mr1459276wmb.20.1714038543295; Thu, 25 Apr 2024 02:49:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7s2d4IUrcb58pg2zbyzWTc5nHavWV68X22gD60wBthMlc5awFLLkRn93BnlHxI5hbCPxIMw== X-Received: by 2002:a05:600c:5246:b0:41a:56b7:eb37 with SMTP id fc6-20020a05600c524600b0041a56b7eb37mr1459261wmb.20.1714038542905; Thu, 25 Apr 2024 02:49:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:8200:487a:3426:a17e:d7b7? (p200300cbc7198200487a3426a17ed7b7.dip0.t-ipconnect.de. [2003:cb:c719:8200:487a:3426:a17e:d7b7]) by smtp.gmail.com with ESMTPSA id bg11-20020a05600c3c8b00b0041a9c3444a6sm10468609wmb.28.2024.04.25.02.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 02:49:02 -0700 (PDT) Message-ID: <3f317def-9690-44b5-8d17-9a31e6eee32a@redhat.com> Date: Thu, 25 Apr 2024 11:49:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] gup: Use folios for gup_devmap To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240424191914.361554-1-willy@infradead.org> <20240424191914.361554-6-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240424191914.361554-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CE7304000A X-Stat-Signature: 58efoz3qiw7h4k9qrtqzi9pe8q991pnq X-HE-Tag: 1714038546-316301 X-HE-Meta: U2FsdGVkX1/9/BauyeN9f7jmSL5RkrqKfThzRqutfofgR9gnMypC3A4tymCU/yo0QD7DtWbYAcK+VyhqyNLfIy1bDeVu1arehIhz2cpzyC+MW6l80mkg5mwWGuCnIUbBQv9kdNkohBvI1eKGVXGvcnmAj+zXxyKz39aoGSiS5z9+yJVIxfkKii+s/zvZ/Q9F4GoWfw6343RMEqL6KreckGnAHDqpCPNKWkmZ6QRNStxQAy9vuCHOIT0T99h7hUlZUQdSfgaT/lPhLDlsH5TMSBkNLlyfM2zdSmYkgmt4D7H587AQLfHhBJPZtmFHKQfCPacR2q2G8sBGFMQ6byvnfTVpUochIvkJfD3GF5OVfNVtpTkuj8E9wuVcNaXvHuyhTYNGSh65AvfzuAEQbCepukkelOFhQtwhP/4YX7dgmVGpk8Fj3hsyRPb442WznlfnUpiRtxoInCBXuKy5P+z1kXH4xuSzJF6Anv8Ph1Cq+vi8vE9uGzcFrSOsDeHpmQ/jKd0yZN5u9/axvwEsUJ+6BHwx11Sz6HIw4tHQ8kh8UowRVXiuj0910jY4sFg7C+/SKJTXf0YmYjHdBs44YMMMEZtvok6zUfeNPBgWc1M++i3ZqvS6qsT+1A2pYUB6rOHazECt3yDH8ZlB8xPweNVG3NR7mGm/LM0ei16y/qu2ZxAX+KiA/3hV6LO2Twa8Dhm8x2IakG5oaaMNRZWjDVxredqUVvpVdwukuJ26bgaGv8I7hn5xsd+ibOiFGz3OgoNVrLhb5xm4ax/DnoI1SgIKg+X1Hl8VcJSr0mn3thorbHbcuNn3EijSE8BSyL7PctViomVSIiNf3+PvT4yoWcqvurdiaF/mkVz0uGQb7zvnVrQtynAGXB2RKtZb0ez/EURuT4do3QH+Ss4VttK8Ls47dMResFsaIANzLuQ+o1gzoFgp7reAVqaIAKy9fybw6jcQmWkzapNnX9tptQLE19i RBGAfawP 1qoH7ExTdqPDV9rJFZZqnT6f9D+h8Wf2vWJCCeJFVT67UIrcD+jsC8upN1yJJkNPQHLil7gkiQHCiImxGMf1GeSEUAR4kb1VWGS8byF3YIUpNmM5zuZRJkwhQAyeVXiKgxtR4smMK5/i3MkXMeI+72p04nW9cvtONzJLrhuJDflW13pDx3J8/RtHuBpVp9aeP/ewQcH4J/xh32SiFJ3YUtBog6hmXT3NTFCHgWacLJGgGnguh4Qq633eFr85MIMonZ5xXBMONdRh7LwSFM4A8yaziTU/2m05rX8SMKRzR2WSjLYZ9oX8xiryQF4h7oI1HuAKSrY0vMQoB1Yd6vF7akLSGwzq3Nth1HK0q4/Wb1bnEQ3omrbA48aQzpZbps3IWIwcstd/nEdpfWPK0n+GGef5oTIlzJXsek3DXegU20Q7Li+HVAHcFlOOTP6WwTEIDmAabJgZvKViIdV2rix2KJuPjOLOp/OAk4KDNzIF4RK7b0EaAywHA9MthE6+obzhKTVek0EIcHlgt/jXiyMzrG1g4hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 21:19, Matthew Wilcox (Oracle) wrote: Nit: s/gup_devmap/gup_fast_devmap/ > Use try_grab_folio() instead of try_grab_page() so we get the folio > back that we calculated, and then use folio_set_referenced() instead > of SetPageReferenced(). Correspondingly, use gup_put_folio() to > put any unneeded references. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/gup.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 49376f756936..e4cc12b8e985 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2877,13 +2877,10 @@ static void __maybe_unused gup_fast_undo_dev_pagemap(int *nr, int nr_start, > unsigned int flags, struct page **pages) > { > while ((*nr) - nr_start) { > - struct page *page = pages[--(*nr)]; > + struct folio *folio = page_folio(pages[--(*nr)]); > > - ClearPageReferenced(page); I stumbled over that likely unwarranted ClearPageReferenced() recently as well: what if the page was already referenced before we called SetPageReferenced? > - if (flags & FOLL_PIN) > - unpin_user_page(page); > - else > - put_page(page); > + folio_clear_referenced(folio); > + gup_put_folio(folio, 1, flags); For !FOLL_PIN, we wouldn't have done the if (!put_devmap_managed_page_refs(&folio->page, refs)) folio_put_refs(folio, refs); Magic in gup_put_folio() ... was that a BUG? This devmap crap is so confusing. -- Cheers, David / dhildenb