From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9D8C5321D for ; Tue, 27 Aug 2024 02:44:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E25F46B007B; Mon, 26 Aug 2024 22:44:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAEF86B0082; Mon, 26 Aug 2024 22:44:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4FDB6B0088; Mon, 26 Aug 2024 22:44:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A4FD16B007B for ; Mon, 26 Aug 2024 22:44:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0289612156F for ; Tue, 27 Aug 2024 02:44:07 +0000 (UTC) X-FDA: 82496480976.27.F03BFBA Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf30.hostedemail.com (Postfix) with ESMTP id 629798000B for ; Tue, 27 Aug 2024 02:44:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724726603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/YR5qZvy1DjydomES1B4qIc2qPciXwBrU5piAajOoQ=; b=3SKb3eYKNyFp4qOywcxjzXNPwirSmWsQm9W/lw91qzN+V3ET7w2pq8orWPMYT48HsgRzJW cTuHDBqgNvn8RYhOrdb0wJT9f7zR5KaHzAw8Cw9HDVqt6uHR0klIeAKRnwTenpWz5d/cS5 oiNQmyUb+kOERTgoMrFVGgCV4JvDqfw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724726603; a=rsa-sha256; cv=none; b=5ZqvYZvvQ9m054ETZ6wuZu25Whdms+v5gcYAdnQabxPydNhgFP9X+eQTGZdrMli/q5GUBa EPWMThEt8d0m7up4qnexJSI8roFQ5kFCmFP/pBKua12iev0+6g3vtA6a/9ALnhBOib1ljO ceVVmS9aAltetAKCE6ttmuW40bpiQro= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WtBdf07S4zfbYx; Tue, 27 Aug 2024 10:41:58 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 3FBA3180AE7; Tue, 27 Aug 2024 10:44:01 +0800 (CST) Received: from [10.174.178.75] (10.174.178.75) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Aug 2024 10:43:58 +0800 Subject: Re: [PATCH -next 07/15] security: min_addr: move sysctl into its own file To: Paul Moore References: <20240826120449.1666461-1-yukaixiong@huawei.com> <20240826120449.1666461-8-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: <3f2bf67a-e37b-f6aa-b0de-3c05d19a5f02@huawei.com> Date: Tue, 27 Aug 2024 10:43:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.75] X-ClientProxiedBy: dggpeml500026.china.huawei.com (7.185.36.106) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 629798000B X-Stat-Signature: nriqsw9oh1h7rxgtpr4suqjb4ozaabpi X-HE-Tag: 1724726644-368198 X-HE-Meta: U2FsdGVkX182P+UXBc8m8FFyw9TvzHPewEcKO2ftOli8gBqf6RYFlLfvE+6hTnKFWj58aKfpCMOlsrv00EawGVusl0z5SvZqvfnv5+aWNJJyEe8+bOm8yHo7X0A88i9R8mDkYuPg6TsCnOefR+bceqa51sdwfSdMJCoBaKvW6zQbDdFEzsFxiNXUO/jYG2APaR9vxw5QMUooMINZ0PWRFoMY8FI3U1NvBlBYHl4fA5tIucx7DX+F/XgnU7UkUJ9f4y4smH40PFGKwTgq1ABI0G7d5nYga41xzmcGrvn1GEbZghPpVEEia8/6qyxiI/y6YXDeCAR3UbELPh0VGz4Fq6WyE5xDqmflzeTsOt0mbf4AtMNUqn32tkULQmyFjBAoAtoG0VNQB7FeA/5kRceckmhUt7hWd1AR7ZX//xacSdwbuOfDEWb8hVhaBg5no6kob4AEEq6opF0AuiV9S9dTCDHQaGljnnZdTwDMj/xqSM9V8jv6SNPqewDQh/cEoLgnMf/d0BRcMq31wTTa7kyQWsjnzQhTu/fzSlc4mMmTNtlrVrjtnWBKtzhcRmcvrBZQjqydcHM8hXjOUkHhTxttsRK1aO3NzknqpEItRG0VP/dZ5kadADtjfzJm6kwwzIpS8rcWE9Z0zwzP456yeaNQb7ojKtyGVLhcMaepPK2X0WIjUDXOxrGO0YqZUqWjs5uFtRlPygOTGoA79SRGR9K98xVmzs+ArEY+G0z7lao2qPPPS8aRC0r2lDMmddLFeBMrVYI+SO7qYCqTPsmvbjDDoPOFJW3yAkLKNnWmviLWkc+AEKBraT123RK79QzpKD+Xxb8I8ACLMIjIUusuc1IzndIahU9CeR0jZO/r6m8163GZ+JWNIarQ1wnZ9FUZiJfobLptMs3aVSLEQTgwJzr2vaVgTlr+IxeOQr08ku70Jj67c7/P6PK71fVmh+zJ82NhMK1ydux2Pirkn4CtHgE fLgqQesf Z7DAkXImYsieqBQCQ5F9d4Y2bSGd3eYVg3Jl8MVdMwMBD2KYUROWRSomRoGWY3fQmfK7SFK8DK/W2PpZdqBELlG19F4vILzZDAxIsAaUoq55ycE9OIrTnQ4gj7iO50Fv2uANB9bSQoyBdys/W2nflw+Cw0JS7jVVIIPREeSg/8sVagSJTRUUrmQCQ2qbzjvBTc623bcaGn/iT3guT+Zeh5NF+KIaBsAgvkDDly5rSIZQc5zI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/27 9:56, Paul Moore wrote: > On Mon, Aug 26, 2024 at 9:38 PM yukaixiong wrote: >> On 2024/8/27 6:49, Paul Moore wrote: >>> On Mon, Aug 26, 2024 at 8:05 AM Kaixiong Yu wrote: >>>> The dac_mmap_min_addr belongs to min_addr.c, move it into >>>> its own file from /kernel/sysctl.c. In the previous Linux kernel >>>> boot process, sysctl_init_bases needs to be executed before >>>> init_mmap_min_addr, So, register_sysctl_init should be executed >>>> before update_mmap_min_addr in init_mmap_min_addr. >>>> >>>> Signed-off-by: Kaixiong Yu >>>> --- >>>> kernel/sysctl.c | 9 --------- >>>> security/min_addr.c | 11 +++++++++++ >>>> 2 files changed, 11 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c >>>> index 41d4afc978e6..0c0bab3dad7d 100644 >>>> --- a/kernel/sysctl.c >>>> +++ b/kernel/sysctl.c >>>> @@ -2059,15 +2059,6 @@ static struct ctl_table vm_table[] = { >>>> .proc_handler = proc_dointvec_minmax, >>>> .extra1 = SYSCTL_ZERO, >>>> }, >>>> -#ifdef CONFIG_MMU >>>> - { >>>> - .procname = "mmap_min_addr", >>>> - .data = &dac_mmap_min_addr, >>>> - .maxlen = sizeof(unsigned long), >>>> - .mode = 0644, >>>> - .proc_handler = mmap_min_addr_handler, >>>> - }, >>>> -#endif >>>> #if (defined(CONFIG_X86_32) && !defined(CONFIG_UML))|| \ >>>> (defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL)) >>>> { >>>> diff --git a/security/min_addr.c b/security/min_addr.c >>>> index 0ce267c041ab..b2f61649e110 100644 >>>> --- a/security/min_addr.c >>>> +++ b/security/min_addr.c >>>> @@ -44,8 +44,19 @@ int mmap_min_addr_handler(const struct ctl_table *table, int write, >>>> return ret; >>>> } >>>> >>>> +static struct ctl_table min_addr_sysctl_table[] = { >>>> + { >>>> + .procname = "mmap_min_addr", >>>> + .data = &dac_mmap_min_addr, >>>> + .maxlen = sizeof(unsigned long), >>>> + .mode = 0644, >>>> + .proc_handler = mmap_min_addr_handler, >>>> + }, >>>> +}; >>> I haven't chased all of the Kconfig deps to see if there is a problem, >>> but please provide a quick explanation in the commit description about >>> why it is okay to drop the CONFIG_MMU check. >> According to the compilation condition in security/Makefile: >> >> obj-$(CONFIG_MMU) += min_addr.o >> >> if CONFIG_MMU is not defined, min_addr.c would not be included in the >> compilation process. >> So，it is okay to drop the CONFIG_MMU check. > Great, please add some text about that in the commit description as it > is an important difference in the code changes that isn't currently > documented in the patch. ok, I will add the related text in this patch series v2.