From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC8D4C77B60 for ; Wed, 29 Mar 2023 23:34:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DF3E6B0075; Wed, 29 Mar 2023 19:34:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78F2C6B007B; Wed, 29 Mar 2023 19:34:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 657426B007D; Wed, 29 Mar 2023 19:34:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5260C6B0075 for ; Wed, 29 Mar 2023 19:34:06 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 249DCAC728 for ; Wed, 29 Mar 2023 23:34:06 +0000 (UTC) X-FDA: 80623541292.27.FF1EEAB Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by imf14.hostedemail.com (Postfix) with ESMTP id 81702100006 for ; Wed, 29 Mar 2023 23:34:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="XGIfQXr/"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=Kl9kIAB4; spf=pass (imf14.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DfLaxTup492SuA/C62YZooLlqgIm/3NXjeWzBMeGkHI=; b=khQcGUdzdCxst0FgfkgkK6mupdjvS/RCAYenHzBp4tB746InL4osLXnHniMYm/XxYTVgDO KgYF78frH+cB1nwEiyN/X3F3/K5KSkJIQnseZxFoKI7HeMGzCkvYwPzhHaclmvrs3XoFzg JdPr4/Hj2ccaxMXjGBAVbdntPUUYK4M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b="XGIfQXr/"; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=Kl9kIAB4; spf=pass (imf14.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 68.232.141.245 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132843; a=rsa-sha256; cv=none; b=GVaql+zY2csHz14Mn1K8yAvSVDDZGfTJJOkoCGra5O8SN2yOSiuywMQfhnxiNrJzj3IS09 H6VyEKiUe8sEvCd/YJXmrSfuL9AUFINwEMzxtpYfvkCLOFKcP97abB93YqNSxfcrsYEhK6 MN8sLxhUEOb4wiHsPEK65dJomGXDihc= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132843; x=1711668843; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GDXEDSyEMJWiW+7+O1GblQg3NUjwO7C813zV/2S0RGs=; b=XGIfQXr/I6GOdbNNGAphgzh/8v/TL3gR1CJblzaKoO4XHz9DCFjeGE+w Az+ydB4dyD+hidCKlxWCHv3FtLrCYRt4/dHDKUJqy8JjNfO7nlrAU7WX/ APQVKO7/ExLQS5d5+A7/jBMf/L/XEScCxJ6UZALMuccbz/PzTTYNXr9Az rNGG7SI6MXQUFkkN5b1Zd/3m4C4M12TefDt6IGD/HXuS15TCCknulth9L SmrvyJhxG4E/B1USAYES2qHtPGhnOd5IHCAVTKhkaO5x/y7LpVgWYekMz NmJAfLQ14HlTwpjq3VBJa96k9MK32OdAEQKjsixbF1iJQZyUW7rURoVYl w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="338904013" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:34:02 +0800 IronPort-SDR: WCGEDTyX98698dM09B7aM6y7l2R2HokqM7Uz/3MlTSTbsGE3FpF3BK9iaxb8HckpsYOfZEfqyt RZ0fwhORa8yMzyX1eqH1epEYgYPHI78FlL9KRxsfMxpYehYHpr3HsAxbf3by1aoCQmcOklyg05 aLXBDAhWZMJW6MzH9zWimLiGxEhbkIirCdoiK33PgEazrxKujhzYGyIJAsEyYlJxcHjdoKlpm8 oeRlfAEYSn8gg2oFcHBhdXnwMYXrObwQHqwh5E90iaXNvNNnl0wdsW9DOGU3iIJeP/MXMvisos u4E= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:44:29 -0700 IronPort-SDR: vhgMzGv+8qXd2gBsBJyQQaNndXoCOyx60FqemRIcOEddSIfyX8BMt9Y/hlwZW77tib1AXOUkPs 26nnbB/nyAgqW1BXMTjwn1apsX0GLIA0GzSjVKh1aVWPXuF3RDXrG48kAyC/KQca81tRZLSWA7 d0/xJSLy8NZhmjhcVaQ2FmMkQn+x4eEc3Ewr0TWDXPEZbjEVcH2E0+CS1+H4L8rPNrbH4nIfyZ 23f/mw9ofABAYUZoCR6ZYTGj8LObsISVooFevvcCuW9WFvXLGFiwm5SCGng1hr0q6Ll7hkGBis z8c= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:34:02 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2tx4DYFz1RtVt for ; Wed, 29 Mar 2023 16:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132840; x=1682724841; bh=GDXEDSyEMJWiW+7+O1GblQg3NUjwO7C813z V/2S0RGs=; b=Kl9kIAB48YMkB355tdUzMAD6Lq7A95Cb8NfzVQHNcITpVbKpz5Q Bf/AlRacy+pwRPXxv/Y59EYwdHDj+sTzoN5d7khiJg1/fGxSDSjw6dIQly/wyEJ2 ukCLhjTvrSGecTdk0ROBuOBGbsnuKbXyOPdM7YY2E4Dni8ehYMBTgPC7NIVoKJxc 8IKPtyMNTgTUJYWyKfuXjNsbQw0QIXDyQWwuAWgSMepI8V9fHAzLY/2GXcTCzi1T 8EIsd+WBdRLyK8+qPFbQ6B5xdnHCAUKseq3eKeeBNbs9gw2iB6jUvVdXetSvwOGq ede4DlUtPAZbbK7Xl0zEQL9cV4gZzJeC4yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aL543njJZDuS for ; Wed, 29 Mar 2023 16:34:00 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2ts6Vtrz1RtVm; Wed, 29 Mar 2023 16:33:57 -0700 (PDT) Message-ID: <3f1c6faf-b558-14ba-a2bc-ac12aad41ba9@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:33:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 09/19] btrfs: raid56: use __bio_add_page to add single page Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <5ce38530bc488f9d4f1692d701ca7ad5ea8ca3e9.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <5ce38530bc488f9d4f1692d701ca7ad5ea8ca3e9.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 81702100006 X-Stat-Signature: qr8iyz9rkntyry9jp7ahudm354wsts4x X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680132843-782531 X-HE-Meta: U2FsdGVkX1/3cZGQ7UnrJ7gxWrDfmC1ousZ+4wy7Tdvd2/ylNwjkXdwKWpAz9uB400817H7+e1xcxMzu4ipCjm0uuAsNnNk+8HmwFtMbyzqAoEoCZ7YtlV0m+7td62czEF/Fu5LyJf8HNJYGDWEs5vU3ikuj/+6mc16SgZIl+0Rnf68X5n7oQExZb54NmQjr5iIYNYh+7Pll4pRSsZV+tXGyoxMs+14V8rLyk0hEZ/+R/gWWmhZfjwlVL7Ttwjs4dtKHDlrkBgqI6FQTFOKLL6nUNq9Mu9Lq7+9p/5F8O1RuD7v+lmQbTunsO0LQSdU2N7+TjcRvWuk6VHUB5WvLrTgsuymo1/gmnarX7jBnHhjH5+xCFfn6WzTj/JzyhId7cLPl0my+2Xm3M+OVNy/AZtZGovkqyS7Gw95T+JL1Eom0cQ1eToMODsQGdYztI1xo/Ck8qnQjz9ilRYM4enT0UJlzJ1QTtXHymRpV/0nEk634DD9ZvhKhBxBUtUQumoZWo+60op7DVVW1expgk/JxgAtZFsRCRxAyUjGsAghrE246hd+hIbQ0LawugMrvseCXKKbRlxHK9kpTnyOhJsX3XBITVPl0TS7+t6oZJLtcDZV2ueq6IWXulwAyR3qTimu6fLY1hKbqb0PAFYu2QvgFYUaBvudcxrC5nJxeYFD2sFkIlzcqlbZeqnU+KxWuEBfSjxP8Wbw3mSv/eTmzMylOv8EMO47xgGWLzDMukWDCW4OzPRtVOtytWlrjhLk6QusbkvDmDCQuBE8v+GAbYULi+vX5wrx9xzQ0Fq73DOjoNoMh+pgWCisBfZ4n/0yqgATandtkzBOS8+FLuuIDTMLK8NbNr0iO0YzG86yFLYTj1AH+xZMzuOov0CJh1F/Rd/0tdKvzqZvwz5A+CiI0W1oHhHg/FEAvip1fkHmoX06815V2x4MkJpieSXtfQeAOWNV9PmzcZTdIt4ClR3pgM/m sRe1coTm UuEKXQoKHRaSF3WxWwmEBjXbdfFXVoZPd++9h9VKzZ4/y93F2abmnB9IoDyHCSWhKhEJ1Xfri4z1BctWCS9Prf35cORe6GKhJqSIKdkr+bzMHHQzV/2K3fmdp2XhXJ3bGaxJdkUwn2hAlzjb98EbVvshB4dQb5xbAaBvGvF9h5GvB3VGpEBujy9D5QS8sdnstdWnQ+gbKYjKzU3ecPeaVe/V52HpvMDgggxSAW5mZrcDaGMRLAgEIhkIT3Gs5VkY1ITvUIRQ3hBoXowc8EpS5T3XWn6qYYF6PxwFBnCh05ox20lEKxxlk7dIbkZ+uD+nITEHOGI7mDmUF0mL+A8u8zoGnjozKLWv/su2irLVkraXcgQhzKaRcv3QE4s7rZ1GrQom6Ko48jjKhUbrl+TmOAlF0rz+FWDyq6eHgxgfBnbnVgUyQUsv1lPPQ9oruopEs0Tu1wYjR0yqUrGdEGKG2h8JvfunUc5z1gXgsX6wMxND8M3DXg+DAwMohT1dttnoFFEMXyiMyP6LN5qW7M+bTE6kX0yD1wlWogsEuPoqKq5PU9a47YkdkHTHZWuiZ+qpwKtu4cWkG0WMZ1J39SxwOFJWy/U/MPaSvpwtgqlFJnjWFSgil5hRRTzr5tGxiAXAu5AsMvaF2/Oxuc/jGc37DKKCuocRocKJ7yf+hmyxjnGbaFnXF6AamOpzJIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The btrfs raid58 sector submission code uses bio_add_page() to add a page > to a newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research