From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2088CFA3758 for ; Wed, 18 Sep 2024 07:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5AD6B0085; Wed, 18 Sep 2024 03:03:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A52A6B0088; Wed, 18 Sep 2024 03:03:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 793E36B0089; Wed, 18 Sep 2024 03:03:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5B3646B0085 for ; Wed, 18 Sep 2024 03:03:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCDC5140381 for ; Wed, 18 Sep 2024 07:03:11 +0000 (UTC) X-FDA: 82576967382.18.C481888 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf19.hostedemail.com (Postfix) with ESMTP id 2A54A1A0021 for ; Wed, 18 Sep 2024 07:03:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Y+T8v8k8; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726642879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+koPlgFoOfcmbQ3ZvwHQOZUll9hUzIHFs1lrXFkXoTY=; b=BV9Ljn2CkVff7WeiOqsMjaO6bkP4f/n0Aon3BEZZjKxGF2thSAqnRhVrZIMqqCcBMHSXqS gz935R94SHSUuuDRPabMi4jwa1/UbZmHG16g0AAMkxp6nya3k0G0KiJb5MoDtQSmi05HU4 xX01VomIR0lgx3ZBZL0DoZo2wJxf7Qg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726642879; a=rsa-sha256; cv=none; b=xrg2T1fbz6bmHcMOHwEtviw+U7yotKV937Diz82Dc/EcWk57j/zPHVIea9bHpB9WxVykEP dLgV975ccFKJ/rXiWNQr/AFOxh2ceIQ1hp3t4ijQN3zz2lNkzkwYN7Zd9PapiHywvUQfxi 8U2KF6NZMfmXhIE5l5S/HWMZgcAIvJs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Y+T8v8k8; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1726642984; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=+koPlgFoOfcmbQ3ZvwHQOZUll9hUzIHFs1lrXFkXoTY=; b=Y+T8v8k8MAqXcG3+Hl5oyH7JMwilQKzntGyfOxOyUhQf2fkTSYwuSYVwBYy1J4fjVuf1mwXf6Soj6xlT5kt5dTsP1UduQJtq6pb3eGnZkfpKuQ27PPRsoQ5yVgc8HnLxdDolRmM55oAwzxXM8SnblNxB53GhtDmYZVEi+4De5Mc= Received: from 30.74.144.133(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WFD8cZj_1726642981) by smtp.aliyun-inc.com; Wed, 18 Sep 2024 15:03:02 +0800 Message-ID: <3f15a44d-cf49-41f4-892b-cb3202603652@linux.alibaba.com> Date: Wed, 18 Sep 2024 15:03:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: Make pte_range_none() return number of empty PTEs To: Dev Jain , akpm@linux-foundation.org, david@redhat.com, willy@infradead.org Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, baohua@kernel.org, hughd@google.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, gshan@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240916110754.1236200-1-dev.jain@arm.com> <20240916110754.1236200-2-dev.jain@arm.com> From: Baolin Wang In-Reply-To: <20240916110754.1236200-2-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2A54A1A0021 X-Stat-Signature: ecnhjf3769ubm56pw7opjhm7r8drz8k3 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726642986-339913 X-HE-Meta: U2FsdGVkX1+6uEhx4m38rUGuoO3pilOa+EAAAULwBBMEk3Mj9KTEXpPAwA9ni5VSZXHyBPAgDSefBpS91UbidegLC4U+BDTUte+bQRej/cYju1rcyhQ/1oK6bhNcQsETpeWgPuY4efngHq4mAm/m3yWO93yno27dGAv9Six0Qq57VP6QQpLN2Crbo6xI8j3ZmzixbpdzBt5HKsmSj4fcAjSgt4JJWQsgaIQtc8kE36Jms5NOLIo0NkNk69NgZQwI+Mt4Eh8sidEFWFh0mzOWHjKQjtaqBdcSWt9XkDVoV3puboP9MYCLFrN7T7WFi9RBPzFFktVXh6G7Qoce9RBUJUBfz5g2TR4n1eW/ZFpk/potZXcfIA2kWi7IIIO0Gev5l3N4mo70y2s3Tby3LsYS62VPbTwvE/HD7GT0r+h2mVJzAxF+fZh3vUP9DX5ZL6x+v1ZcpW2sa1tuB/r8zQPQzMSlxDsQec4Q3QNPax1FxxZlgMspMmkI9X0/t44GXO2y2nG+1VAIRH2aE/Qteff62rEagyLZzcXRdvhj8CH1lDBQTe433uqTwaKlhEvImGmxHAJltSybSU/KQkqdD+WdwM++PTW2+LGAY9BN/9VZVUuUe/NE9mfmaILV7sa2F/y2OH0BQJa29F4OQUhpvwu+X66MJ9rpsAyfdype0Phnw9umnvrhR7qG6CJo73Fg9HH3sa3wXc/bgOjzci7R9lpyZjmsCvMnlWvx8F2qFzJwvXKrwjoruvXZz0P2IRDAZrV+/Ycdpyr4VcdM8d8UG+395B11mNU7dH7lavTqqGvdG45fH9ZkrTuCLnNatLurHqX78hMC6phWsbkInU4M36jTVSNl50dIJQ6ya5kKTQTcN9Zs0y6fkKpPMII3WcgAkv3nyMNrWWMfHs1cbtwj9pXL3wcqRYtHSwRZupng5CWftVkhAlhQIY64QoRQjq4uj5oktpaQUerphTGh5VMPiQR UAH7uzrk JljHXwji5tmWwpCVx2++iVxia7SC6/d47tBHCvPWgzbnTj2dafA4nB2FJZiZ1BYsskpND3W7GZqk75/oI2E34k5te5w2vMyffxPZC9cxLgfQ+mPPd/76d+62AnZAhS4lPNjnaEDBclR+crR/VgKDD68y2dBIW7ammWTRhSM9tfMcqfV3r4Lufwx3KWnTEKerVqdfosmQtZjwwzYC2NGGizXaa+6CoTUaYDXhXMNfonwf3AJZY6KRSFsZBBUjkuXmyZjo3h3eJid96IzkZZ8554dtk0kS1uVTEAmHxusYTJWkGGLPQ3qmcKrIh69mpyJkHslg12P5oTyF9hOBuMVjfH1NzCRBsFA7Lf6YPb6jesOkYrgdfSqIXNafcL6rKiL/22YlB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/16 19:07, Dev Jain wrote: > In preparation for the second patch, make pte_range_none() return > the number of contiguous empty PTEs. > > Signed-off-by: Dev Jain LGTM. Reviewed-by: Baolin Wang > --- > mm/memory.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 6469ac99f2f7..8bb1236de93c 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4617,16 +4617,16 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > return ret; > } > > -static bool pte_range_none(pte_t *pte, int nr_pages) > +static int pte_range_none(pte_t *pte, int nr_pages) > { > int i; > > for (i = 0; i < nr_pages; i++) { > if (!pte_none(ptep_get_lockless(pte + i))) > - return false; > + return i; > } > > - return true; > + return nr_pages; > } > > static struct folio *alloc_anon_folio(struct vm_fault *vmf) > @@ -4671,7 +4671,7 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) > order = highest_order(orders); > while (orders) { > addr = ALIGN_DOWN(vmf->address, PAGE_SIZE << order); > - if (pte_range_none(pte + pte_index(addr), 1 << order)) > + if (pte_range_none(pte + pte_index(addr), 1 << order) == 1 << order) > break; > order = next_order(&orders, order); > } > @@ -4787,7 +4787,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > if (nr_pages == 1 && vmf_pte_changed(vmf)) { > update_mmu_tlb(vma, addr, vmf->pte); > goto release; > - } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) { > + } else if (nr_pages > 1 && pte_range_none(vmf->pte, nr_pages) != nr_pages) { > update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages); > goto release; > } > @@ -5121,7 +5121,7 @@ vm_fault_t finish_fault(struct vm_fault *vmf) > update_mmu_tlb(vma, addr, vmf->pte); > ret = VM_FAULT_NOPAGE; > goto unlock; > - } else if (nr_pages > 1 && !pte_range_none(vmf->pte, nr_pages)) { > + } else if (nr_pages > 1 && pte_range_none(vmf->pte, nr_pages) != nr_pages) { > update_mmu_tlb_range(vma, addr, vmf->pte, nr_pages); > ret = VM_FAULT_NOPAGE; > goto unlock;