linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Igor Belousov <igor.b@beldev.am>
To: Nhat Pham <nphamcs@gmail.com>
Cc: vitaly.wool@konsulko.se, Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Shakeel Butt <shakeel.butt@linux.dev>
Subject: Re: [PATCH v2] mm: add zblock allocator
Date: Tue, 08 Apr 2025 13:20:11 +0400	[thread overview]
Message-ID: <3f013184c80e254585b56c5f16b7e778@beldev.am> (raw)
In-Reply-To: <CAKEwX=MXD9EB242WkB50ZBmZgV-CwrAHp=_oE+e=7yHDfrMHtg@mail.gmail.com>


>> >> >>> Do you have zswap/zswapped meminfo metrics from these tests?
>> >> >> Yep, and those look somewhat similar:
>> >> >>  - zblock:
>> >> >> Zswap:            234128 kB
>> >> >> Zswapped:         733216 kB
>> >> >> -  zsmalloc:
>> >> >> Zswap:            286080 kB
>> >> >> Zswapped:         774688 kB
>> >> >
>> >> > I tested the kernel build on a 4-core virtual machine with allocated 4
>> >> > GB RAM running on a Ryzen 9.
>> >> >
>> >> > The results are the following:
>> >> [...]
>> >>
>> >> Now what's funny is that when I tried to compare how 32 threaded build
>> >> would behave on a 8-core VM I couldn't do it because it OOMs with
>> >> zsmalloc as zswap backend. With zblock it doesn't, though, and the
>> >> results are:
>> >> real    12m14.012s
>> >> user    39m37.777s
>> >> sys     14m6.923s
>> >> Zswap:            440148 kB
>> >> Zswapped:         924452 kB
>> >> zswpin 594812
>> >> zswpout 2802454
>> >> zswpwb 10878
>> >>
>> >> /Igor
>> >
>> > May I ask what compression algorithm you are using?
>> 
>> It's LZ4 for all the test runs.
> 
> Can you try zstd and let me know how it goes :)

Sure. zstd/8 cores/make -j32:

zsmalloc:
real	7m36.413s
user	38m0.481s
sys	7m19.108s
Zswap:            211028 kB
Zswapped:         925904 kB
zswpin 397851
zswpout 1625707
zswpwb 5126

zblock:
real	7m55.009s
user	39m23.147s
sys	7m44.004s
Zswap:            253068 kB
Zswapped:         919956 kB
zswpin 456843
zswpout 2058963
zswpwb 3921

>> > And does the zswpwb come from zswap shrinker?
>> 
>> Haven't looked into that, to be honest.
> 
> Can you check:
> 
> /sys/module/zswap/parameters/shrinker_enabled

It's 'Y' so the answer is yes.

/Igor


  reply	other threads:[~2025-04-08  9:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 19:28 Vitaly Wool
2025-04-04 20:03 ` Johannes Weiner
2025-04-04 23:56   ` Vitaly
2025-04-06  7:53     ` Igor Belousov
2025-04-07  9:00       ` Igor Belousov
2025-04-07 15:51         ` Nhat Pham
2025-04-07 16:44           ` Igor Belousov
2025-04-07 17:00             ` Nhat Pham
2025-04-08  9:20               ` Igor Belousov [this message]
2025-04-08 19:55                 ` Johannes Weiner
2025-04-08 21:11                   ` Nhat Pham
2025-04-08 21:38                   ` Vitaly Wool
2025-04-08 22:05                     ` Nhat Pham
2025-04-08 23:12                       ` Vitaly Wool
2025-04-09 17:59                   ` Igor Belousov
2025-04-10  7:02                     ` Igor Belousov
2025-04-07 15:54 ` Johannes Weiner
2025-04-07 18:26   ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f013184c80e254585b56c5f16b7e778@beldev.am \
    --to=igor.b@beldev.am \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=vitaly.wool@konsulko.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox