From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A5BC4345F for ; Thu, 25 Apr 2024 03:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2CEC6B0087; Wed, 24 Apr 2024 23:26:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5E56B0088; Wed, 24 Apr 2024 23:26:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955956B0089; Wed, 24 Apr 2024 23:26:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 74B8D6B0087 for ; Wed, 24 Apr 2024 23:26:15 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04565140E7C for ; Thu, 25 Apr 2024 03:26:14 +0000 (UTC) X-FDA: 82046615910.05.64A2982 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf05.hostedemail.com (Postfix) with ESMTP id 39932100009 for ; Thu, 25 Apr 2024 03:26:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="SB/UBFh9"; spf=pass (imf05.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714015573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4E11bh0mnSYCbs7XlFu6X7DBUDw+NgzQF2QoLRfZq4=; b=ph/BKcVE8LGdmjhaqt8ixDXZEtD4Nm6oIvYGp/As/oIjlMrf2/PvXP+gPCM6Rtz2V+6LdK 2uS2hO2sZZ5Injc5P3Ot4w2JG4vPAt9DN8nrYyH/dlqLeh6wxWD5zUl5sIwrtl/PRcAnIn BomzOXM/HiFHc48Ps8JmHBbX5kDE+fI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714015573; a=rsa-sha256; cv=none; b=NoAIfL4ahERU4PnC2junq1bgugRoahfG0A+ekeKp9kajIACxttDvI5miwqb0R/3Tf6MDDJ u7K+Nd2bf/lGEJSBVr/4RciSg+3mjOAbc7MTB4a4PwBSZ5qSRGCQZsnxGp5p3nSut6hOhD Yaxu+Fu3BbCV649znfvbj2Xkwu2qEQg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="SB/UBFh9"; spf=pass (imf05.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 24 Apr 2024 23:25:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714015569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B4E11bh0mnSYCbs7XlFu6X7DBUDw+NgzQF2QoLRfZq4=; b=SB/UBFh9p4EtaUdmuFy3Y/2llf6hAFYeqTBTCq9EEsoT+vbVj3Dlf1lTZDFcjgmVyftRCV Waevx5gMLX6VuaMH0g7owkCnFmE0q6eqUFo94c3PjotScdKb99fpqHnymmit8v+7TmVjp+ fv6zDMYTkmqCw9Lze8Tza4V/pRVw9Ow= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 00/37] Memory allocation profiling Message-ID: <3eyvxqihylh4st6baagn6o6scw3qhcb6lapgli4wsic2fvbyzu@h66mqxcikmcp> References: <20240321163705.3067592-1-surenb@google.com> <202404241852.DC4067B7@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202404241852.DC4067B7@keescook> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 39932100009 X-Stat-Signature: yzhgdha9xqrn8kamfdy4arbn4eba8xc6 X-Rspam-User: X-HE-Tag: 1714015572-472289 X-HE-Meta: U2FsdGVkX1+wAh9mEuD7onDWRLPjm4rh/nnDYAAt8wS9lm3dEupncWodu4drPujF/pg5ZqgGBXvT1TFEZEocSapvo7RyT7E/CwkxtnolP0vcR6Xq9sP1uR/RoRlmgYro+czOMaPUkD5cNCq6lPmgfuMfkPotqegCVQRCHb8xd3bTuTg5z6lajiiFvciecuLVDDQJScLhHJYztr7gDcJ0xBX4hRQiQJfxE0Xel4aJeCfuc81zvaFpyyVZIieSBMJ+cR1uT8tUCHwXnloZA6jnlPxqgMILPKZ7c5EQULOk/hUtK+Rf0TdG3ntvlekhjSAZmW0ie9QqFWlUo8J5UbITWfAIOzmmzDQuHTkqew1lAfI/lHkuLxqE0U4D8S7oXM1zpds4MgAGW4er3KcArExI17omOKngyCQX6nmWEEBn2Vh1Jlhdsh+9ooy2+JXjwxLcHDVFpq66HSATm5lTnWriT4MlbPR/XWLYuTUcWuMbpIyCphaKRWqWCr9F8ncj147kd6eHiNSAc98Kno/xieV9f7GAVKSqnB60HhCURNt9B0+AckpvNkmHH3ugoOGMOuNQ9asLWgzzBrRUrLc9TyoageaTav8/wmFSq1NuChAszHQCrVEnG7zKNu+jvyER6vaBX4xVNv7oe2zREKGs8DOORS3mta+B0P+UMJHgg24NYOyZXaQTKEOEhMS1tlkOMjqDpFAX34JkJYcovhaLwGVwMFey2KHSgOOEjHiv7woZ4AMFM6adFHIze8j4hPlZvocXSBh9V/Lqp0ra0MKsbw6kgMkHqpQcHkrD6gSqcTlwoEN7J2wz+WB8POlLWYvKigWhuB6r3j3xVtRAPUXq7haPJvDqbSL+1+PngsriWC7uTTJPa2hzm9IQ2td/CMl45hXcqzcx6otkux5evPnhv8QOdaTEXYUJjGfdNCD+w5S20Pev1TaLU8FSo7Wpoz7mfmVbjotZvT5acU72oTmL/aa 0Q8956GV 8i0Y2+fie8ArV/7ey4UDCSNTZsvCOLUgkSxF1uR8VJIMqzRxVBaabsPqGEA3YEh+ZHBsirAtQJDOc/8UQMOH0DXo0AtN6ZvppR3vomnnUBDjJCTZ8gfMacFssnxZ9EKa6ZmPz04Giabi4BV/yHci1MQTlQ1wHyozRKmfc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 24, 2024 at 06:59:01PM -0700, Kees Cook wrote: > On Thu, Mar 21, 2024 at 09:36:22AM -0700, Suren Baghdasaryan wrote: > > Low overhead [1] per-callsite memory allocation profiling. Not just for > > debug kernels, overhead low enough to be deployed in production. > > Okay, I think I'm holding it wrong. With next-20240424 if I set: > > CONFIG_CODE_TAGGING=y > CONFIG_MEM_ALLOC_PROFILING=y > CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT=y > > My test system totally freaks out: > > ... > SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=4, Nodes=1 > Oops: general protection fault, probably for non-canonical address 0xc388d881e4808550: 0000 [#1] PREEMPT SMP NOPTI > CPU: 0 PID: 0 Comm: swapper Not tainted 6.9.0-rc5-next-20240424 #1 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > RIP: 0010:__kmalloc_node_noprof+0xcd/0x560 > > Which is: > > __kmalloc_node_noprof+0xcd/0x560: > __slab_alloc_node at mm/slub.c:3780 (discriminator 2) > (inlined by) slab_alloc_node at mm/slub.c:3982 (discriminator 2) > (inlined by) __do_kmalloc_node at mm/slub.c:4114 (discriminator 2) > (inlined by) __kmalloc_node_noprof at mm/slub.c:4122 (discriminator 2) > > Which is: > > tid = READ_ONCE(c->tid); > > I haven't gotten any further than that; I'm EOD. Anyone seen anything > like this with this series? I certainly haven't. That looks like some real corruption, we're in slub internal data structures and derefing a garbage address. Check kasan and all that?