From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76081C3DA64 for ; Wed, 31 Jul 2024 15:08:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D6C06B008C; Wed, 31 Jul 2024 11:08:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 087406B0092; Wed, 31 Jul 2024 11:08:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1BA86B0093; Wed, 31 Jul 2024 11:08:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BC1436B008C for ; Wed, 31 Jul 2024 11:08:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60C67A3255 for ; Wed, 31 Jul 2024 15:08:34 +0000 (UTC) X-FDA: 82400379348.19.EC5587B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf15.hostedemail.com (Postfix) with ESMTP id 9FCF9A0023 for ; Wed, 31 Jul 2024 15:08:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qy5g79g2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h6AjUHTB; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qy5g79g2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h6AjUHTB; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722438437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nl6rGQjI8NmFXSzFaYBS8yJKHN5SNOcvfiJQVFu7/SU=; b=aieACm9owCFcNZcT2uURA+nOzrop6AImCPaohN60nQ6QFrFH/0OhHfkuH+AH7tJzLikAgG 54OUfsiKpv5g5E175UKRAGl2QLwjDnLO5WaHEMxI1jDuQJxUVMgbmLsDuWtRFCeEgykvMI iGsdmqlsjIYoP5W6LlmlGzc8M9e0VS8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qy5g79g2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h6AjUHTB; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qy5g79g2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h6AjUHTB; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722438437; a=rsa-sha256; cv=none; b=LuWY/ntjuckH3dWsgCs7+p8L0LaSeP8wFOoQm3e07+DA1myZ7m3G1DvhnzxYSy86JEs3mY tSL4mCibn5aXUjy5K5aNwCtv3vsREsFIP/8cCB5Bvs7VjXZHoj5FF7NksLiA9JRbIytgX6 skWaS8CUA92RF6mvCE4urTTV/IKqxXg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D6E31F833; Wed, 31 Jul 2024 15:08:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722438510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nl6rGQjI8NmFXSzFaYBS8yJKHN5SNOcvfiJQVFu7/SU=; b=qy5g79g2HVvR5zy8NixZnOu+B33PbK3gjDVKDqnpipvGXJZnvbQ9Tcb2anOD27fIKBjvMp KL1nbWLV8zmfW3o/jdaKl6XACZTPxGTAJzrsNe2wx64B5zIfn3v982NQcUMTZ9GN9lIYyF qHDqM3QtyKaWsYa8jL7J8ZoieTbS+fI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722438510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nl6rGQjI8NmFXSzFaYBS8yJKHN5SNOcvfiJQVFu7/SU=; b=h6AjUHTBRJLf2IsmFkbictuYKCowUfeGAujqSWNDOCpq01ht+rNKxqQZf/RHbBalodMv/W JDnymA/PnR0VUnAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722438510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nl6rGQjI8NmFXSzFaYBS8yJKHN5SNOcvfiJQVFu7/SU=; b=qy5g79g2HVvR5zy8NixZnOu+B33PbK3gjDVKDqnpipvGXJZnvbQ9Tcb2anOD27fIKBjvMp KL1nbWLV8zmfW3o/jdaKl6XACZTPxGTAJzrsNe2wx64B5zIfn3v982NQcUMTZ9GN9lIYyF qHDqM3QtyKaWsYa8jL7J8ZoieTbS+fI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722438510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nl6rGQjI8NmFXSzFaYBS8yJKHN5SNOcvfiJQVFu7/SU=; b=h6AjUHTBRJLf2IsmFkbictuYKCowUfeGAujqSWNDOCpq01ht+rNKxqQZf/RHbBalodMv/W JDnymA/PnR0VUnAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3BD1313297; Wed, 31 Jul 2024 15:08:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id suo3Dm5Tqma2AQAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 15:08:30 +0000 Message-ID: <3efc8b38-182a-4021-b550-41040aecf1c1@suse.cz> Date: Wed, 31 Jul 2024 17:08:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 15/20] mm: Make kswapd use kthread's preferred affinity Content-Language: en-US To: Frederic Weisbecker , LKML Cc: Michal Hocko , linux-mm@kvack.org, Andrew Morton , Peter Zijlstra , Thomas Gleixner References: <20240726215701.19459-1-frederic@kernel.org> <20240726215701.19459-16-frederic@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240726215701.19459-16-frederic@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9FCF9A0023 X-Stat-Signature: tdncyyh3rr7wmhx4smh61kkwbpfcm9d1 X-Rspam-User: X-HE-Tag: 1722438511-124611 X-HE-Meta: U2FsdGVkX19wgA85jpCD3RsSbkjPOY+Y+bFt3H+vz5XAS7PSBAGz4KBzy2UAKZHWsxEl5EGXLnMMYSAIlys1iZ2GwoJwbLbWzzqzGKq1ZyIPEON4Znu5r4RGYay5XG6JNSCs4Sg0FgaY+CZxgt//eA4HA7Yp6KjV/ESaRyN8oYdEN48+wfTTfO7oAkSaFBWkdB0Q/fpQvl5uoSTg0lgOJEo7LAfq666ijlW+amCFUXet8tmwzN/mFxkl7O+N0F3G63dzTLCFtb+NXLtX4+FoBjF5vtH0M1oevLYaRSiN4rCkH5tmqq7E22VTzpW3OFVAFdXu38T0JSu9fVDKr21FuSc7jVFllM4fsWPhChZNpGq7QYRMrO2v4eHEVIFoRNPflYylAbgssAh6HaJXU5rI1zp01MJTEpbUnTCs/pzCMb1xn0U/Qv8Em1IxfHqDS54Ch2YO8sD/4ATpMsUf42NAMMnaKgXVWfoPwiXuk7KymSGOsx+jU//YylfWn6q85oOmYzqfE1qZHjFaZq3PEUA23Xkij7NyVYN0vZc7qNbuLYx/cfzLa3m0NfrJNS9oUyhyjrlPY91YEmm8AXYdIEGXX2CRGBAISVSALXvY+sVn765VozRNZBFj8Xvsr62g/tZWb2Uqcr24KyNR9TFPt17yaWYChF+NiSE9r+cW5qDyMrAi9hbd6lQU3evneKHLjH6n5I5fpnNX/6hV6M+ntA29k4k8K45jCkyQutw6dlGJcfcxBDwqW7PLluk207kyaYwtTs2Aevah+vwRzLrAEXXJpB8OmNhE/qwSYcdg/936hkdVUZLK2LGMNdraTGEmHIckjfXn7XC7m6rH9U1GNUekaW5Nnlgrj2WKy8pQSYEX2UusH2wnLRqRiyiMfkbx6pPuAsHMwY272nIj3IliaK+pjSFVRt6lbf51swoE7YBAW5Dzgm13RCU+EnzPFYYEi6YqQTeFh2Lq+3I4TbHqpZw KEgbGsna EAT6+Ra4htsVYa7d+hCpkbzVKFhqpFvjrchTPJUwBwggqJ6lk5S/YNGf8E7JN7ZBS2rERjj29wmh/ujgq2ZQsrQLYmEImhO9o52K4y0vpuHws+NyU2fbhG1fo3ujNhrkTLBB/3lWYjnrUVF+zGdHX55M1FGvdtqCVKNYrztHzeH8U8lgL8N0tJMmhk7Vu0rLugdeXX/VttKaIdzN4trWxlmKl6kGs//5RGOeFgo3T38Sj/gqIIwcKM/WrrMpzQopdO6YxDUdk8GLHA0UpIbjMzO2BbEFzfjY7inKG6EtBq24v+VlnBYqr4OpUddLI9YlA7D014ghUENOL6o0Qn6a6p7KqrupNUOcUsxva X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/26/24 11:56 PM, Frederic Weisbecker wrote: > Now that kthreads have an infrastructure to handle preferred affinity > against CPU hotplug and housekeeping cpumask, convert kswapd to use > it instead of handling halfway all the constraints by itself. > > Signed-off-by: Frederic Weisbecker Acked-by: Vlastimil Babka > --- > mm/vmscan.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2e34de9cd0d4..94359a893b4f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -7116,10 +7116,6 @@ static int kswapd(void *p) > unsigned int highest_zoneidx = MAX_NR_ZONES - 1; > pg_data_t *pgdat = (pg_data_t *)p; > struct task_struct *tsk = current; > - const struct cpumask *cpumask = cpumask_of_node(pgdat->node_id); > - > - if (!cpumask_empty(cpumask)) > - set_cpus_allowed_ptr(tsk, cpumask); > > /* > * Tell the memory management that we're a "memory allocator", > @@ -7288,7 +7284,7 @@ void __meminit kswapd_run(int nid) > > pgdat_kswapd_lock(pgdat); > if (!pgdat->kswapd) { > - pgdat->kswapd = kthread_run(kswapd, pgdat, "kswapd%d", nid); > + pgdat->kswapd = kthread_create(kswapd, pgdat, "kswapd%d", nid); > if (IS_ERR(pgdat->kswapd)) { > /* failure at boot is fatal */ > pr_err("Failed to start kswapd on node %d，ret=%ld\n", > @@ -7296,6 +7292,8 @@ void __meminit kswapd_run(int nid) > BUG_ON(system_state < SYSTEM_RUNNING); > pgdat->kswapd = NULL; > } > + kthread_affine_preferred(pgdat->kswapd, cpumask_of_node(pgdat->node_id)); > + wake_up_process(pgdat->kswapd); > } > pgdat_kswapd_unlock(pgdat); > }