From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F0AC77B7C for ; Sun, 21 May 2023 23:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87F9900003; Sun, 21 May 2023 19:41:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B37AD900002; Sun, 21 May 2023 19:41:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2674900003; Sun, 21 May 2023 19:41:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 913C1900002 for ; Sun, 21 May 2023 19:41:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5436CADDAA for ; Sun, 21 May 2023 23:41:07 +0000 (UTC) X-FDA: 80815885374.11.F8A8D8D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 6C88C140013 for ; Sun, 21 May 2023 23:41:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bbR+hubY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684712465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xi/1ic3ts0dI/zKAVwmjvawndGiVSi1VP8xFbd/Ve0E=; b=j0xdMXXmEOXt87QxDRnnKRkEj1f5wVj1yFca9OeJB6k4hBkDnW67WPNftH05/5ogPz1sUZ 5q5q1JfcpLJG9J7K7APQv6APxVe11JIcwWIzG9B98pcMeOPKUhkq2M1QshsxDhsBF9X3C0 1GLhgjM+wcdi8JZos52EgwEkheJKay4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bbR+hubY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684712465; a=rsa-sha256; cv=none; b=sL4hbUTthMmP6XCwpDzzdJqJcuRZrfks+wadNjxLaA4dbvV/9PaesqYs5kzCyRHfSx7Zkk +bVG8cvimKzWNXqeYnEyfvofR/7ELwYsAzqpzJNXHbN0d5ec+GaC+Gksv/s+yGKnVOL40s tRjyp7d6SC8GyaTJ/hKCuDT9AaRURO8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41E7A60F36; Sun, 21 May 2023 23:41:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF259C433EF; Sun, 21 May 2023 23:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684712463; bh=tA12yQU00KKUJDHmMiS/p1BMYZTe42VhuQxJI9hnBGs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bbR+hubYRLAGzg/uGQW+S+uObtEMdvAC9Prq09XRey518FIX9V+FA9yn08nrOyJNo phX9SlbCCQp1tqYPJmwQQ7TYpLWkj6b+H3zMuc1Z7VQuG4Eo9Q/x02u3s+NMYDXZK7 y6g4/CCC39Anez1oZFdvYg1ooCDtAlwpyilfm6Q6NNXW5yqA5BSTe0P3z5r+pwBHUD 0on5F0vG1ouPX4IHgXYeHIp4iq7izeicWegN4YNYFIeZ8chatU4lAHZIfFgH6cpWn+ WUW1P4+xbujvaU0L10MBQr77eKeg564VpiezTN64057zhcRO/0ww07EJx3udJ/fiyx NLclOBUpvfnRw== Message-ID: <3efbf8c7-b3ad-fbca-f37e-a7b2fd78320d@kernel.org> Date: Mon, 22 May 2023 08:40:59 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 01/13] iomap: update ki_pos a little later in iomap_dio_complete To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-2-hch@lst.de> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6C88C140013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fuubr3zbxmr8d9tj1ywsqj4qd5y31fo6 X-HE-Tag: 1684712465-989806 X-HE-Meta: U2FsdGVkX1/mRWaQm8FvoIFecxrBp9eWc4snUj58ON3+cscEtAMI1//sPF7jTf3AGst2v0XInIu9isBaD/PB6I1IPDY70g99hjwh9pThqUeeyQ8zNCzDSpM60ES+JIeQl2nebGjkXTKX7FcVUh336jA/5KJNohUw5ODb+m6u07mEj+7o9RMrgPpq7uRIj31IupOnOMVsm2AvFI3VvqO+jtx1SFy3aId6+SkiZvBG+2+F63jalKm80RfDNXJzSg3CI2aQL0f09L+9q7AU8iC77XEe4VcxRvjQBU1uUG+91a5/64L5vEt6nm6oYTGSrJjpcMCPoDv0k7fV3FvCRaZxaPbxhnztJ+Jgx7WdLaicfFXPTxOjhW9/OAP/CtA4jAuCZKiXqbnauY8eFwKnfU82XfZnyD5+RsVd4yu3aHRgVK87znPKo6k+Bcl6p1SmhO9Acd/8ig/ZyH6br+3SKOz8XNDyRq6CNte7O2Tg+A92FnGWMCoZNnGAXtmbEbPqhSbChCppQPFn6/e57FdNFQ1c2/CpDtLz77QPlk2yV02tzYRoBZZFD99Uct6uycr1F0sb6gMP6KidMWtkSY9dTuiZb0364aS93fDXCusBTr3jxSjayivUFQMso+eZvqh47UTQ0+hPL5ruQv4rvpBGWfRB8myCBrqVaeBZn4Ca7YS6c/BimYMoT/9yUjb8MfkuAT1+MxZ5CuYeq4qAXCl+umzWCSLoTyc+Py3EW5Q/bZ+lkCXec8W7FYtIswgxI2QUNo1/fxldB82+T/NwXsLh+9ZkqSmUv8+gXh5/2REFGUbdyw6c0gGzHrMAhWgfFVrp5FRAXhFZRPvi50AtZ9Pu7WGAhkO4+sX6iUj2xg2ib5n5yqSeOhOtNIAqMoytmMlkGX177zwNfNoN202KtZ5y2M6RvmJvind0PPnValhZ3Q1yBe60MMxb5sDGuC0BovIezkM87QVe+RR2UZkk6ypPUw3 5TInAxli oLu6WHRbjOEDPEklQM3qOgaV5Iz7tJ9C2jx9gqvGoObZr5V1xC65b+1M+kPUlqEYmYR0HSWp9gUbuZXRd538peygeU1VL2ha7Y7/a0tDxC+jqxoYnFkKuAncPhjAZEc5x2Lj67Uc+kCEYqWqkxsYDw3IlrjHNEZVtlz4QLQpIuheRA83s1As36uAXYYh1VkZvOZwNjUymHWGxhdx7Kefmd4OBYvCS9ta05twxEgqklS+TQ5QEXlE5QQlziebcaRkMfUpIKcMSFcS6l48ytEuFCHcGw/wjWpArP1Dztbj3vdSs9NchALaz4P5EkS1LY6qw2bhJKGXThf9c/2OumWMzvW5OPnswwoA9OP2JaYlVXWLoMKW0fQKNhWy7Wx3pp/PMUwa7SHWZb4hmV2SlThJ1gkeZvEtCzeJazC87k7HP0qSXO1HhZIYTDBhz8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 18:35, Christoph Hellwig wrote: > Move the ki_pos update down a bit to prepare for a better common > helper that invalidates pages based of an iocb. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal > + if (dio->flags & IOMAP_DIO_NEED_SYNC) > + ret = generic_write_sync(iocb, ret); > + if (ret > 0) > + ret += dio->done_before; > + } > trace_iomap_dio_complete(iocb, dio->error, ret); > kfree(dio); > - white line change. Personally, I like a blank line before returns to make them stand out :) > return ret; > } > EXPORT_SYMBOL_GPL(iomap_dio_complete); -- Damien Le Moal Western Digital Research