From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F292DCD37B3 for ; Sun, 17 Sep 2023 05:03:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3006B041A; Sun, 17 Sep 2023 01:03:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D93706B041B; Sun, 17 Sep 2023 01:03:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5B226B041C; Sun, 17 Sep 2023 01:03:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B05876B041A for ; Sun, 17 Sep 2023 01:03:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6398E1209D8 for ; Sun, 17 Sep 2023 05:03:01 +0000 (UTC) X-FDA: 81244894962.23.CCB8B30 Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by imf27.hostedemail.com (Postfix) with ESMTP id 6009C40026 for ; Sun, 17 Sep 2023 05:02:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=bkGTLOwJ; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (imf27.hostedemail.com: domain of deller@gmx.de designates 212.227.17.21 as permitted sender) smtp.mailfrom=deller@gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694926979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5HfpUJ6pdWPLPI6qrUhqI7kJgwGb8/2KJEzo9RfNBU=; b=2Kx+HcKXkH9q6M5or4Iza4D7JDAFfCxqJJRr/qu+QmGk3EpW/ln29nKJmBIF83XrMg1EEH GDwhxe+mdFzkWf8H91GRaeP3KvpCz9nmOOTyCruG0fu8bujmuV6l5DZcNVaANGGYFWX5Eb 5Xo5XgJdmI/PGQKxIfyLTPcaJXcLGm8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b=bkGTLOwJ; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (imf27.hostedemail.com: domain of deller@gmx.de designates 212.227.17.21 as permitted sender) smtp.mailfrom=deller@gmx.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694926979; a=rsa-sha256; cv=none; b=CS2c5x4EJgHxLSqv3Bn3vcSe7r0HvmYmN857rWnyS7TTZwLMEcyEHtQ1HNNyGuXeHAMaYh +qjI+6fI9J3Mkh+nAe74bRd72tDEXP6vhBxKjp4IAVoSTrQIznMw4iyyOxGvdtHhLwC6rm w8BZLwSa9iMda3/TMENhYer+fy1qsq4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1694926976; x=1695531776; i=deller@gmx.de; bh=cb3+ZF/rV4lwk1B1qRxD0kTjy/De7HPOSvC2jWQ0MzQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=bkGTLOwJ6+u3KncVFviIhQH1gSOQa23v2bH93POlk+8kQa1fdLpMyefhwCe9EhXsFgJDZJS20EY bycUR7epK5mwp91vbOzFPbx2GBQYyEYGDEBXT8HHwL35f0pNc0Vbwcft5KEAid+XhdxpEkrcqZGpq eKXxk0qwbFR4t2/51NbrRMPu2Y9Qn8HmiRgMUFp72Lck3JVysMAGR2gOwhifsWhUPNlrud2MJ4/Z0 EW/mWrsW9EM+sH8d9mCmFRHkYaJOIR1cbe7fbkxmCWzn9cMVI8DPoX3nsqNcerrD9Zsb6MG1BfAuj RSexj0VnMMQxu6YU6havyNL6mpt/RgkZ2nvQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.149.71]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mw9QC-1rXN7E0k4K-00s7eF; Sun, 17 Sep 2023 07:02:56 +0200 Message-ID: <3ee4b922-7686-ec20-f280-48c06bff09cf@gmx.de> Date: Sun, 17 Sep 2023 07:02:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Possible 6.5 regression: Huge values for "commited memory" Content-Language: en-US To: Linus Torvalds , stable , Sasha Levin , Greg Kroah-Hartman Cc: Linux PARISC , Linux Memory Management List , Linux Kernel Mailing List , Linux Regressions , Andrew Morton , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Bagas Sanjaya , Michael Labiuk , Christoph Biedl References: <1694366957@msgid.manchmal.in-ulm.de> From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:uIHbs1szNnWp90sKUPbPA52puQA4EtPReKI1kZ/IIhX2E8llQlo Pcb0RDVxaJG9khkqX/rLPIha0TWkVY68z/dIH0M+Cx85kD3BUwTna+dn6z8tFlm6pNdqDFc oUpvgo+nW37eTA4GiZkVv1utzXhTaugpQfdyS5ndfle07vN1cQ4OrVPnjb7+BviTDDpIE6v M2w2TS9YEfU4byH3IIajg== UI-OutboundReport: notjunk:1;M01:P0:TVFLNApSMFc=;Q9CDIMEE65QafXNmvrGsy35E7g/ v5/2DAwP3hrQCCZnrjprA8UieqDCv3G6u9w44f9K8QXiBy4K16Ce0oXY24weGjattJXOIc8XY tsC45Hc9nxd52OVEY0bCtbA4B7n+Wu9vRBa9TjPSc41b25I/RcKeKY3uoNMyO0HNdBtO8kz3q D0dUAl8PSpMs9kcywU5nwUg36e9Ch3QrbLa5BYvhnxXJOdGsg5P18bxpzyQmLZIJ051w0f1Si MhQMeTHR0wt8QrZFgA8s35m1HflYPGBjFsZF5Pzbf9lrGQ1hsaxoK1aUYXZwoc/Jl40QXKscX NoqVVsHBrNVg0AJIBaBURGXZttuQk+FLiZqeVnLsk+gWlsGG0X5kx9HcFn6vSmZSim4H95qtq qBJ+yK8Dq1d2yqMjbogyVw7XymXMdaZbdgULho6w6NqpDhlXfgSBgvWW1Rezdj3+WLtAqclJ3 eROwhwGLM+GRdR+yqNmUq7Uo0iiRQBVxzuHNvckG4lF4qBTu2VMVt9+7N0vBuzhZVyiUCcpOJ wAOnUcTUfd5M9PZS4V3G1IW13+qQ9ecpKOm5OOYfuFL8S10HUW+T1Gcxji/8xRKDKWMsZsEUV QL16HEasISzHmf5J+KT23JUKje8qUrYffYalHdq5wX3xzBn5GtGyoXDnlP5CJFInhIFKhIW1t OAxgiotBcw4DuYVDo5aRgOOM/CIjxv8Y5xNSJcBBZyU1ijmomc8bTeEIF+g+C4L6/4Qi3VS1M 8hTquv988qqIpwLvtp1jMO/yTGyq2yakH2QFTWmGgNfksaWzr36S5TeZHEwB7TGpBY/PCMTO4 RpKwoekPAvosQuFoFYi7lLA9Ex3FPHXilAhxQhyoZUyRs39MV85Vk3UfVU19aC8frBRNZIIQf SsGi9xBoEUfMSLmdHBhc8uxzfOac8JC3zZXz+hLDG7vk4yDjkbBo1D0S0ClYyf+FBUJ9FAuK5 WsS74RnkzFLtEUcCTFa+ofkGIWY= X-Rspamd-Queue-Id: 6009C40026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: mi83xdou1945t8u7rt33tg8n5g3fr87r X-HE-Tag: 1694926979-489064 X-HE-Meta: U2FsdGVkX1+66UagppX+GS49E2MiW6+ESyXjsdvbrTsUIj1LF1OunfLwMAe4Oy6kmc+EmP9iC6L8rAsfp9hfBCZ1CTjk5sSvQ5yONPLA6wx5M9v5GhfrCAPoh6lt7XkW6pobC+rE3ks3xaXuiTQBbOGBdYhKGobapTnQ0HTsMs6s4J8EMEW8ndHt7eEwVPfjXuWPwbUZ7B6OBayHWbWAWvBhdg0CwtPM2s7dUqVFYZo20oqASUL6t5d1DDXgyxKvcNUS8S+dqBq/f+2ooJIc5s+g8CoCbHRZLR1YWjewcQzGkt346V+scZB2jh2yD1BgnEm3LtlOsIfT/DIq3oRjolCStjo0xixSqEnGDMhTymBW48InUOrZq2PVhSmWaol5a2saVmvhs/ZSPLik4/1MXUuSA9Tffz7f9sLbGL4ruWGX5wJaSnGmN741CEhA8ybqn2VxGQlHKy/V4xmxTSSr211y5hIHAgxTCDg62H8bm7Ln4m5CBX19n9NTFxg6471yAYei1/z3/tfZM31XD0MWJ/BWPvmOWZ0C/+Hm4bN9ThuKfip30OWKas5wE/Gw3Rn/qf0pgtB4RzLQ+434xc4OWKoPE9VAPcAWmXudJKtJGHs6bWl4SkvyRXdAZMfWEDDUIkhP2DXvfAyTKTsVqVdRnBeOhI3L7RC+o1Neo4vn67x0pUJKwe6zjRfacSyAqPb0GyUOiy3DxCFIo0cNZT+woucv5a4+xarIvk2XUI2kHkhYHNRPqssFlF7hInQK+9P/NvEiZWOYuNl0eh+aST9tpBqmFoiYO6OiQrcJCqd2aMus1pKQwL4wWaSsyYOlY5qjajreUPnyQWixnX16WXnypHM57wCj5tCDgVlRH+bWomkA6A/B7n05McWSXu9HhypSP4lwbC9Q8owIna4OUDBb0TieN0DliaqMt5BLKGN2yaS/thDJEQlmVse9bsgzkELzIXnBRjvVR4oBoHIEUUz YZCDFzPY 1TqyAfwADHvDwFG+O53CYFSUjkdUNijoz3moztA0luOYzrSSNMMInBEFtqgZbUDe2mdQeZAVlTmF/BD0oI8VPZzGFxASkJbO6/B2QUj5eTVmO9HyacNdwU1EgBSUVZjMI4kqY41fRyY9T9jjuGk02KcpYZ0hL4l7tUq8ohZ12IMeczSJlJ/2xw1SdJE+Ct/uYipTtoxQjCR6FqJwYtxH9+91UPzX5GoOHWzGpJd/XwPEdtnbY+/8fPXiL91WHMVWNd8J4dUJMWfSZZ38I7+S8EkVvOKk8YJX6t2qK+V1G9m8CB+hrXMqp4h/oJATopC9BpS+bxjVtb+irWcDDz3g9n4uYgYpvtO0bo3kLpwW3VWBpcsX+7hm//kljxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Greg & Sasha, can you please queue-up this upstream patch for kernel v6.5-stable ? commit 3cec50490969afd4a76ccee441f747d869ccff77 Author: Linus Torvalds Date: Sat Sep 16 12:31:42 2023 -0700 vm: fix move_vma() memory accounting being off Thanks, Helge On 9/16/23 23:17, Linus Torvalds wrote: > On Sat, 16 Sept 2023 at 12:31, Linus Torvalds > wrote: >> >> Does the attached patch fix the problem? > > So while I didn't confirm the fix myself, I'm pretty sure that was it. > Getting the return value wrong would cause an incorrect extra > vm_acct_memory() call in the non-error case when VM_ACCOUNT is set > (and mean the loss of one in the error case, but the error case never > happens in practice). > > Which then causes 'vm_committed_as' to grow when it shouldn't, and > causes exactly that "Committed_AS" in /proc/meminfo to be off. > > So here's the same patch, but now with a proper commit message etc. > > I haven't pushed it out (because it would be lovely to get a > "Tested-by" for it, and that will make the commit ID change), but I'll > probably do so later today, with or without confirmation, because it > does seem to be the problem. > > Linus