From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037DAC282D1 for ; Thu, 6 Mar 2025 13:56:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92D7280002; Thu, 6 Mar 2025 08:56:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4341280001; Thu, 6 Mar 2025 08:56:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE496280002; Thu, 6 Mar 2025 08:56:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96E9C280001 for ; Thu, 6 Mar 2025 08:56:50 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 482C656E9C for ; Thu, 6 Mar 2025 13:56:52 +0000 (UTC) X-FDA: 83191277064.29.4F6F323 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id ED5E214000D for ; Thu, 6 Mar 2025 13:56:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uqfd4Xtj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=orX3S+bC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uqfd4Xtj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=orX3S+bC; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741269410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Kzl5mnhT2R/4sPjXbXDpEyhE5fuXsCx7EHyoayjeTg=; b=tVfYQQoP7sFn/koNNz7YqG8eheqQ973pqunc5uiLmNEefuKLN/YwBocSdxYLW8JDq6sppD IGBqypoIvIeT3BcH9W6a/E3bc7ToEHu1dX6XXU8KJCDkTC2nm2iItIA3Kli/LboxksDC12 JcljN1/N5zd73KwXzBaqgfG/73cKgwU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741269410; a=rsa-sha256; cv=none; b=5sBczseIyvV8LwWEmqHt6+i73hXzEMJG2E3ZZe8cvcJeN6s+OnpbtxtfOkHA1NcU11JleT PVMfDdRE/BxSHhyuNqaeXE4lU1uY2zfRVGB8ZUy2rWtaVeoENc7DVHwLWMT+jYibq9xoxf Mc1ouLMqD5qjY0qVCDkwcF1v4pBr4DM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uqfd4Xtj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=orX3S+bC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Uqfd4Xtj; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=orX3S+bC; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 353A21F78B; Thu, 6 Mar 2025 13:56:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741269408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Kzl5mnhT2R/4sPjXbXDpEyhE5fuXsCx7EHyoayjeTg=; b=Uqfd4XtjfmUDvgJ3SaIqKZFEtpM/tSy/1719dU5HaNc0rnBvd1rxcoVQ/cad8PCinbcJB8 5B+O/NdcZJhno7ZWZr49WPtT6lIp+5xrNudldZtKidECAky5EBEG1hTCJ0j88lf0zW71cI O2MGGKyeeivHpVESXCj/IMn+njbk9gA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741269408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Kzl5mnhT2R/4sPjXbXDpEyhE5fuXsCx7EHyoayjeTg=; b=orX3S+bCvFawaw34RGbnNjSj2GIfQioTB1cArAiGtUCJdvJoDCNwbdUcOHrNupksaT/sZg Vwn9hfAJZ4X4V1Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741269408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Kzl5mnhT2R/4sPjXbXDpEyhE5fuXsCx7EHyoayjeTg=; b=Uqfd4XtjfmUDvgJ3SaIqKZFEtpM/tSy/1719dU5HaNc0rnBvd1rxcoVQ/cad8PCinbcJB8 5B+O/NdcZJhno7ZWZr49WPtT6lIp+5xrNudldZtKidECAky5EBEG1hTCJ0j88lf0zW71cI O2MGGKyeeivHpVESXCj/IMn+njbk9gA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741269408; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Kzl5mnhT2R/4sPjXbXDpEyhE5fuXsCx7EHyoayjeTg=; b=orX3S+bCvFawaw34RGbnNjSj2GIfQioTB1cArAiGtUCJdvJoDCNwbdUcOHrNupksaT/sZg Vwn9hfAJZ4X4V1Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0D8E113A61; Thu, 6 Mar 2025 13:56:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0YEHA6CpyWe8cgAAD6G6ig (envelope-from ); Thu, 06 Mar 2025 13:56:48 +0000 Message-ID: <3ee33a2c-5370-4d79-9c73-9dcbe4078b7d@suse.cz> Date: Thu, 6 Mar 2025 14:56:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] mm/mremap: refactor mremap() system call implementation To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Harry Yoo , Yosry Ahmed References: <6a62c1a4ea7f362b0685bbe3a2e74a47d24e5c43.1741256580.git.lorenzo.stoakes@oracle.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <6a62c1a4ea7f362b0685bbe3a2e74a47d24e5c43.1741256580.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ky8sstb76o9zkmqnownscma9s6wgkbix X-Rspamd-Queue-Id: ED5E214000D X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741269409-948896 X-HE-Meta: U2FsdGVkX19lxHJ7rC7ShGXQDq0s2ez3Ny58N9igN5rryr2dMPF5nkISV+7Ze/vp7sMmAod95u3eV/j68pF45+oBYChzilth/f2ZqBIv7opXIjZhU9msLLIlnYWw2J4tLsQSwDyF056d/lGxFK4TFQ2YEXkUPFkNAWovbk+w8TyVJ6mbVtxpCL77Un4O8YBE7PUVxbr2+BxVkL75hx6frR8sNoemSXafKb5DTw10yPiwH0ZFIKIqFl7qXgzykyThjKowgAfl84S6rUI7KKdh8OFT4JJXAEtphHDbPUUhhJu1vqns5jTOT686q+lYxw5tbEoN95iCR2eXkMmjNcRXhctOxM4EPW3eZ4TymsENi3t+zeR7bLfVD+5I9y/GQa5TQsRMOj2Y4mPLF/yRFrMrOp2SPjSB9DCKJL2IC0jr4lmpOudxQaR+7TlogW9H4F5KM+PWeaVkVxTMdVBzvTrQuQVmDnsG4ogGBwK+N9H2hIaETjVzfehFkNDQ5kZznpATqlRS4wsX2J1GYc8o0ASCX/SfOVbqbQ2j4Zj8zw09RLT5ZxBguknBuUhEplRA5gHicSdpo4jh5bouZcO2sSaJH9BwIpPEThF0T05ti+rzTtoFoXh6fVMWg0kHR1Mcbl65rjU64OuzKNDUDqbwdUeAxpuEgcLfKT2BzH+vnSvMmfCvM1ZnbYVz40/t0M5ZFaRQeEC9qP7zZnYu3XHiOKXZu48ZuUMubvFPICQZvnxkwuAlR0Fu3pD0E10ZJjYN4Wi65rowjKqY53DQBzu0nDzNnHc7Ub/f3w6X34R0eP2A1GWQp28++04nH1oNGboAC5x+CqXeXEeY0YY8rmT0yDlFOpJWNqjLy6Yfe3pMuLrxoG89eeL8rLqKRxTa4Vr2TMLP/tY5j/PwsRpF73jwNyPo184XP8KsHCBmRqy2a2A52/nJRqU0nIt1n3RM+EhFb1VE+szFhkKwJyL4VzQoRIW X3K0IvMZ l00kn79QDzeaaXlNPFEbsGOhQj/5pAhRInXGiPY2iXTtDf0sUgFxBOZPEWJJpf2yt4C66DMBDRHG8Fs5Qt0neTPgVMp377aTJIIZZasD6uPlvzGKknwugyPyLeXBa1BCy3W7DP5glGPu3s4TdlJY61fs3epSGla2icqHEtqkf/jWrkH2O2ZJkcxWpWyM35gHt/GCInB/Xj7EKARKuGO8kN5rv1DiGLQcwLEgOGoDH0m3dNyvHsrrGCNXsWVY7gdk4V/pbu2eOF0MqvsOFLrf+GKV7Eyf2AZlhk4Zkt7uPqL9mU1FFFMMNoeilww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/25 11:33, Lorenzo Stoakes wrote: > Place checks into a separate function so the mremap() system call is less > egregiously long, remove unnecessary mremap_to() offset_in_page() check > and just check that earlier so we keep all such basic checks together. > > Separate out the VMA in-place expansion, hugetlb and expand/move logic > into separate, readable functions. > > De-duplicate code where possible, add comments and ensure that all error > handling explicitly specifies the error at the point of it occurring > rather than setting a prefixed error value and implicitly setting (which > is bug prone). > > This lays the groundwork for subsequent patches further simplifying and > extending the mremap() implementation. > > Signed-off-by: Lorenzo Stoakes > Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka