From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC1D9C433ED for ; Thu, 20 May 2021 21:06:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BC1E61028 for ; Thu, 20 May 2021 21:06:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BC1E61028 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE7076B00E4; Thu, 20 May 2021 17:06:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6FF96B00E5; Thu, 20 May 2021 17:06:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D378E6B00E6; Thu, 20 May 2021 17:06:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id A13D26B00E4 for ; Thu, 20 May 2021 17:06:41 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 03EB7BBD1 for ; Thu, 20 May 2021 21:06:41 +0000 (UTC) X-FDA: 78162843402.32.19ABAC3 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf09.hostedemail.com (Postfix) with ESMTP id 03FD66000248 for ; Thu, 20 May 2021 21:06:37 +0000 (UTC) IronPort-SDR: /HDS4NZn5yG0rFg7F6C71iY3Vtom5q0JeI8l3LQ6jyyFCPwn7CxcdFeP7H+fFHI1695FHtR+/E Vz4KRxZ3wfmw== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="265251064" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="265251064" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 14:06:37 -0700 IronPort-SDR: 1LaHlQbEIAaulARfd6pepuB9A1uuFmz3hYPtGsneBv9e13fT63+Y8VTImuWAG69kBQg6/JNBWa M/5pNrvRTOCw== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="440623013" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.167.234]) ([10.209.167.234]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 14:06:34 -0700 Subject: Re: [PATCH v26 26/30] ELF: Introduce arch_setup_elf_property() From: "Yu, Yu-cheng" To: Matthew Wilcox Cc: Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Mark Brown , Catalin Marinas References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-27-yu-cheng.yu@intel.com> <89be0683-e1b3-d843-c4b4-ba351ede7427@intel.com> Message-ID: <3edd6ac7-4aa2-5f09-245a-3e5cf4bb06aa@intel.com> Date: Thu, 20 May 2021 14:06:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <89be0683-e1b3-d843-c4b4-ba351ede7427@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf09.hostedemail.com: domain of yu-cheng.yu@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=yu-cheng.yu@intel.com X-Stat-Signature: erioyhodhsfwhtogdj5f34b894nx4me5 X-Rspamd-Queue-Id: 03FD66000248 X-Rspamd-Server: rspam02 X-HE-Tag: 1621544797-106475 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/2021 10:52 AM, Yu, Yu-cheng wrote: > On 5/20/2021 10:38 AM, Matthew Wilcox wrote: >> On Wed, May 19, 2021 at 03:14:58PM -0700, Yu, Yu-cheng wrote: >>>>> +++ b/include/uapi/linux/elf.h >>>>> @@ -455,4 +455,13 @@ typedef struct elf64_note { >>>>> =C2=A0=C2=A0 /* Bits for GNU_PROPERTY_AARCH64_FEATURE_1_BTI */ >>>>> =C2=A0=C2=A0 #define GNU_PROPERTY_AARCH64_FEATURE_1_BTI=C2=A0=C2=A0= =C2=A0 (1U << 0) >>>>> +/* .note.gnu.property types for x86: */ >>>>> +#define GNU_PROPERTY_X86_FEATURE_1_AND=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 0xc0000002 >>>> >>>> Why not 0xc0000001? ARM64 is 0xc0000000... >>>> >>> >>> I just looked at the ABI document. >>> >>> ARM has GNU_PROPERTY_AARCH64_FEATURE_1_AND 0xc0000000 >>> >>> X86 has: >>> =C2=A0=C2=A0=C2=A0=C2=A0GNU_PROPERTY_X86_ISA_1_USED=C2=A0=C2=A0=C2=A0= 0xc0000000 >>> =C2=A0=C2=A0=C2=A0=C2=A0GNU_PROPERTY_X86_ISA_1_NEEDED=C2=A0=C2=A0=C2=A0= 0xc0000001 >>> =C2=A0=C2=A0=C2=A0=C2=A0GNU_PROPERTY_X86_FEATURE_1_AND=C2=A0=C2=A0=C2= =A0 0xc0000002 >> >> Please add all three, not just the last one. >> >=20 > Ok! Just found out, I have been reading an older version. Now 0xc0000000=20 and 0xc0000001 have become reserved/not-used. Maybe I will just put a=20 note about that along with the link to the ABI document. Yu-cheng