From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B47C4C83F1A for ; Fri, 18 Jul 2025 07:22:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5407D6B00A6; Fri, 18 Jul 2025 03:22:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 517C96B00A8; Fri, 18 Jul 2025 03:22:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4070C6B00AA; Fri, 18 Jul 2025 03:22:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F7E76B00A6 for ; Fri, 18 Jul 2025 03:22:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D905A80337 for ; Fri, 18 Jul 2025 07:22:15 +0000 (UTC) X-FDA: 83676541830.07.E2A48F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 7681F40003 for ; Fri, 18 Jul 2025 07:22:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M+uReOBt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752823333; a=rsa-sha256; cv=none; b=HKU4i6zwhERY6BmKYNXP3tBdrM9/wke2dPEuy/yA5slgUCkd5wdYeiZapAp+n39+PrOsFB v+7DbHgWv4XqkOgMoKj92DzigPUvfY9rnqG++kVj70j93449wD8LVTQUmV0S+ULzQ1ok0t nGKOnrluEqBKpFdOOkCr7Pc/quIQAIc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M+uReOBt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752823333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S64nmm1CmYXTsKNjLLVJT9xjGOP5MhwT+RPhwkoKmp8=; b=Q0HoxrSjYgfMzQbBtQYNegs+zPjSpa+nj8BPFgFttbSkymKaKNcgFfRPTr9jisHMzGeZDI A1e78cvvh5vPwWeP99UK+GEvGjGXky2Nb6rrtz7mYpPTawerzPEZoBM8nYyP2EZQktYDpJ 3znYKiIqGWpXYqezWp6bSp4GBcyEx3A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752823332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=S64nmm1CmYXTsKNjLLVJT9xjGOP5MhwT+RPhwkoKmp8=; b=M+uReOBtXC5YkmaPSOlXJtTlL0LOYnlbfzJg1VVkYuRI7dibgIQswhYdEYRTsutsvHiLwa 0U6Zp+Hts7wXT8m0XQEiZqkksZ/VPO+uPAouni9vSDBK+mFEjT6pisP9QQcjBg0AvIZ4Wr fZ4I5NFxahpMqxEon28Y18WlDth1+Jk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-I2WrfiF6O2Cob0YEBiviyg-1; Fri, 18 Jul 2025 03:22:11 -0400 X-MC-Unique: I2WrfiF6O2Cob0YEBiviyg-1 X-Mimecast-MFC-AGG-ID: I2WrfiF6O2Cob0YEBiviyg_1752823330 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a523ce0bb2so775533f8f.0 for ; Fri, 18 Jul 2025 00:22:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752823330; x=1753428130; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=S64nmm1CmYXTsKNjLLVJT9xjGOP5MhwT+RPhwkoKmp8=; b=RDtWO425JA+cYG850F2ygtWsQl2Wrh1cW1zMFswhpngcBbZmw52qynjgqbIIgZn9aU dX9+1H0zXoKXLo8YNHi3ynD4rUSPq7IeqcmTyMqWxJkbNqHSx8OBzhBeiibbk9jk5a+S Vi/a5VxlF3nkZoMjMnqnVVJVw1KXBjCpWJUwblXVRf7R8FXVFueAHbjZ1m2FOYqwRj1l GtowIsX9XF6UxtoSBso1IviTI81nRxKVrEP6fOvst7AxNgvozOUKOS7fDIQ0FduY9PJb rLeLVrw4WzkM6bh9D8eUwgzfBMGl/vWSWRykNq4vx3jDlGPWI8fnyt7Vdk+tdhZkCQHt qeCA== X-Forwarded-Encrypted: i=1; AJvYcCU2QBc4g+UE/ptaR+F363EuvjXSS3ZRMq/HOFqJOpDxOYyu+rgS6cs7PDTqSSqdo20ZESHWpDeNJw==@kvack.org X-Gm-Message-State: AOJu0Yzw+Gi0hVonugAq6q2eQqb3rBKj5Y4IylPsIpcJR3x2zEp/fhbP 05BM6i8vgbyGzlDzjmDWVtbgA5S9QzlX5YaOBBOGbKfsk82Q2Rkh/6tn09IoCIDlC+9gQj3PNQN GPo6AGK98yygVjCnyFIqMk72TQfcLwkZIW10Tmqwhu8RQnGPj1TOB X-Gm-Gg: ASbGncshAgnDN9jAH3eWdzkL5BPu7TMMd6cotOprujXKKEQEXzuhqPkX+tFuy3OHtR1 y8GQy7nV2Oi0jRZH679HdtYcpGIEqFbhlzcnCz7q0/umgPoHDzXP2Qa7HXgIUPUJ+Ryee/6XQ7J nSp0/EteRWyu0MoXELSNonI3pCo7L8fHDkAlwB9ji2miCZ7vK09WOG2Ium7pzyGEQhG2IsN5Dsk ZuGY+PIRnCOF85x4+USeK2fp4V12U64L+Bm8RiZGJeiVUpDx2/rewUXrEaj5BKLCa6uacboyEc4 mmToRnVFb07fu3S1UyWqpNHmd+j60aPvNZKxIsvh/8a8+NdKqy6V39UNUYH7iyIRsOQAyZ+4++I kyoiRvZ76IpWmxyLbQEH+2TGYCRuq/WEnUJKu09+kcwTVGWumGhrNyeUrcqvIF96njgg= X-Received: by 2002:a05:6000:26c7:b0:3b3:a6c2:1d1b with SMTP id ffacd0b85a97d-3b60e4f2e53mr7044463f8f.28.1752823330004; Fri, 18 Jul 2025 00:22:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtcDpZB4AC3Qf1+73jluGyxsv5vKKt6WgwtoaUdWufdaaeHjQIUXlAFhprYhAV/bBWv2gGtQ== X-Received: by 2002:a05:6000:26c7:b0:3b3:a6c2:1d1b with SMTP id ffacd0b85a97d-3b60e4f2e53mr7044431f8f.28.1752823329539; Fri, 18 Jul 2025 00:22:09 -0700 (PDT) Received: from ?IPV6:2003:d8:2f43:8900:f364:1333:2a67:d49e? (p200300d82f438900f36413332a67d49e.dip0.t-ipconnect.de. [2003:d8:2f43:8900:f364:1333:2a67:d49e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca2dfe0sm1024933f8f.36.2025.07.18.00.22.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 00:22:08 -0700 (PDT) Message-ID: <3ecb7e94-c0c2-4dff-98bb-a9e32a48c369@redhat.com> Date: Fri, 18 Jul 2025 09:22:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm/huge_memory: convert VM_BUG* to VM_WARN* in __folio_split. To: Zi Yan , Lorenzo Stoakes , linux-mm@kvack.org Cc: Andrew Morton , Dan Carpenter , Antonio Quartulli , Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Balbir Singh , Matthew Brost , linux-kernel@vger.kernel.org References: <20250718023000.4044406-1-ziy@nvidia.com> <20250718023000.4044406-5-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: <20250718023000.4044406-5-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zsHS3VoEtp3ZFO3yarrPFs13ypKRi3zrc5AUXZkHKiE_1752823330 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7681F40003 X-Stat-Signature: s55fqqdbkfejdbg16wffkwmx4owfmpjw X-Rspam-User: X-HE-Tag: 1752823333-274999 X-HE-Meta: U2FsdGVkX183gcz5XV2e20uMGgqncD5B8aiezfFjxyqaF+7ZieO69IXsokVJgjuhPj7rTNYIiFOzyxQ5gJAN/8yo521ZyCgoNxABV6HCrtvGtlWyROwFTFhsU764+ZVM+Lq4D2ZZ0QcClKFTctGE1aorBMSHi+QIuaKEQPz4ESNOGicw48+vUgeh2sigWnN2pGsh3z3b2VsHzFgR5uPJzJGhP/wq4jBRYLvuNhTNWxW94EZaIysWlrsBsEl6l4hL/O6CDwe0WFz8Z+5qgrXPdOgdoPSoFfj2u8ocMStjKXouZ0vytv5S6oZySHAQc6r9/o/o4U92Qkl8qDDLjixXjI7OJslaMdiB5LrMU3tl1EOgxKnPtI0qfJbTwlrn+Cq820GrsonkgVyXdzSQ32+OoBNAsC8L4M7VWfu3kmSInlVS+Yb6k64NvQWsGdl+HLdDh8mBlse7Mfbbg+OhAqsIEBdA8ChDiQNa1CGk3gRsWzu66LgeD4CUJT81l1ccA95Jw3ixTWGukMzWPO1F1PAIkGAfd72EyoMs15nAzeeB+Yxs4zy47bTYGWTGmQoVIOeF/WhLYZYyNKKBaiobq8U6hXXgcbwvSJWE/wyOZsVH8f7l61dExydQlcBTSpTvODflldffhWVHNWAcazlIsUkwR4pQhLr1S4lxjn0NrM7awtOuYnJKPobbCusuXU4MqSlQy9z+B/A2O72T6KS1ZNhsKmbcTkaglb4xvt3dMBbsg8kbTQstrjzgR6QMaHt3M/saz+EVqHtzz+58uV+vqGfFWq9x9SEUtUWg7y3x7838QROucw50NHeY5fRLi68GWRHStqqXsDwjW++hzWXS20vCMZ5kekJfcQVe8wLh41xy7B7Xm/hlPgHe2b+FKgQ9E9q7DsaoFtE0eJvO1KVN7AWd+NFd+NzOUTndx9BOjRpnZxzfOtEj0lFKj0T3gFHLUmxHsRGz/ROAO4rI8zJ5uUd UZn4sGKf JVleIw3Y+LdUOXTywKRsfS3R5pMtmNdNXOx3FvV3YDwhnbGtiRbi7dlwhEspmOoffRx22EJ4KsgbOetcN6sbHblC2d1Te2w0DMfVrAytuAmuALNrDpXeBEHnAfgWBJa3obGrd9DGQof96dPlCoDlSSRMnh+fSBncwDOASDjCujv96i+zT2Vc8sEo0b/pvzIj1kOE/CT9iUSmJEfrAHxjcvRiJTjxRk5BP76Wd9R0L9mtWRslqMYy1twV1WJLPfor/Tuc8/LJwoCvmpQ30zP9jeAvLdmAmt1DFycTWUEA7owJMk+0MZhLhj8dK+RnXOCu6lq+7xjFT917quTYax2ej60nNuqvGtP0ixFDYb/lwXpsAxVVkOCLRRtooVBalA2AY53zaliIkAwoa+OxDd/FiLbb42oRRjcguHh2E/eICDcv/EG3ePgjOX7VvvBl6Mi8EMZBxN7RP7+hKIZvp+keNuxaGWY2YJrS4X+et8j8cEZinhyrgA2bueZJqdBXrKheTpXJgA6qcq3gVPI+nKIpkqMuYZPOXjAdmdvo4u9QZ/LgYxWVnNzF6Dhrago/vRLDKDTSMvg43xGPIt2B6lEJBDVD+LMoP1d4G5GoV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.07.25 04:29, Zi Yan wrote: > These VM_BUG* can be handled gracefully without crashing kernel. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d36f7bdaeb38..d6ff5e8c89d7 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3601,8 +3601,14 @@ static int __folio_split(struct folio *folio, unsigned int new_order, > pgoff_t end; > bool is_hzp; > > - VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > - VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > + if (!folio_test_locked(folio)) { > + VM_WARN_ON_ONCE_FOLIO(1, folio); > + return -EINVAL; > + } > + if (!folio_test_large(folio)) { > + VM_WARN_ON_ONCE_FOLIO(1, folio); > + return -EINVAL; > + } For cases that we handle gracefully you usually want to use if (WARN_ON_ONCE(..)) because then you get actually notified when that unexpected thing happens. I am not really sure if recovery is warranted here: smells like a straight VM_WARN_ON_ONCE_FOLIO() is sufficient, and catching this early during development that something is extremely off. -- Cheers, David / dhildenb