From: Miaohe Lin <linmiaohe@huawei.com>
To: Jiaqi Yan <jiaqiyan@google.com>,
Boudewijn van der Heide <boudewijn@delta-utec.com>,
<ziy@nvidia.com>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
<jackmanb@google.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>, <mhocko@suse.com>,
<nao.horiguchi@gmail.com>, <osalvador@suse.de>,
<surenb@google.com>, <vbabka@suse.cz>
Subject: Re: [PATCH] mm/page_alloc: Fix freeing of failed-split poisoned compound pages
Date: Wed, 28 Jan 2026 10:45:20 +0800 [thread overview]
Message-ID: <3ec3f4de-2c38-5ec4-4b4a-d7a801efe558@huawei.com> (raw)
In-Reply-To: <CACw3F529=PC-pwXOX0gbNrnS7HTwXq93oVT=V74J4FHLqcZ-ug@mail.gmail.com>
On 2026/1/24 12:42, Jiaqi Yan wrote:
> On Fri, Jan 16, 2026 at 6:12 AM Boudewijn van der Heide
> <boudewijn@delta-utec.com> wrote:
>>
>> Thanks Jiaqi for the feedback, that is very helpful.
>> (and thanks Miaohe for connecting the issues.)
>>
>> After going through the memory_failure(),
>> I can see it indeed puts the PG_HWPoison flag on the specific subpage pointer,
>> and therefore my fix won't work as-is.
>>
>>>>
>>>> Yes, this is also a problematic scenario for Hugetlb HugePage. And Jiaqi works on
>>>> it now [1]. I think Jiaqi's patches might apply to THP scenario too. Add @Jiaqi to
>>>> verify this.
>>>
>>> Yep, I think my work will also help solve the concern when
>>> try_to_split_thp_page() fails.
>>
>> Your fix makes a lot of sense for hugetlb,
>> as it linearly scans through all the pages.
>> From my understanding,
>> your fix also provides the perfect architecture for also checking THP,
>> though it doesn't yet cover the in-use THP case outlined.
>
> Oh, sorry I went ahead myself and assumed the split-failed folio would
> eventually be released to the buddy allocator at some point when
> userspace processes who owns/maps this THP are killed or exited.
>
> Zi and Miaohe, am I right about this? or do we need explicitly handle
> in-use and split-failed THP?
IMHO, it's enough to handle poisoned sub-pages when in-use or split-failed THP
eventually be released to the buddy.
Thanks.
.
prev parent reply other threads:[~2026-01-28 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 20:54 Boudewijn van der Heide
2026-01-13 21:05 ` Zi Yan
2026-01-14 14:48 ` Boudewijn van der Heide
2026-01-15 7:55 ` Miaohe Lin
2026-01-15 17:11 ` Jiaqi Yan
2026-01-16 14:11 ` Boudewijn van der Heide
2026-01-24 4:42 ` Jiaqi Yan
2026-01-28 2:45 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ec3f4de-2c38-5ec4-4b4a-d7a801efe558@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=boudewijn@delta-utec.com \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=jiaqiyan@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox