From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E7BCEBF9C for ; Fri, 27 Sep 2024 12:24:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C78E26B00D0; Fri, 27 Sep 2024 08:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C28E36B00D4; Fri, 27 Sep 2024 08:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC9BA6B00D5; Fri, 27 Sep 2024 08:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CEEB6B00D0 for ; Fri, 27 Sep 2024 08:24:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2A32B80CCA for ; Fri, 27 Sep 2024 12:24:07 +0000 (UTC) X-FDA: 82610435334.21.3CB5C1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id E1F67A0002 for ; Fri, 27 Sep 2024 12:24:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMnMmPVC; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727439723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rOO/RMJMndVoVeK71fgXzYzz13o8AL6/Nz/3/wUYT4k=; b=kHlpdo9xz0eZPX0XcThddtE1cjLX9H0rNAusO7dQV9jMThDjMxWRt4MxLtTBvVkdXmkqGw HRn2Q2nf+GV6wvgUmLclbwNGBsGDiFxi7slwObFL/yYplFyiBuDo50Af3LogmhrKuTX7Xo NwC9GJXuwlQ66xZkZ6H84eCsZH2gGf4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727439723; a=rsa-sha256; cv=none; b=lF24ZVnNq+KE0+BWo1G1cKT28mE20MY7T5258B9GgfZxtD515h8Bp7sXIWQvqW0+6lLD7O rWPglfUtC4rGWGsVevBmXIrtcK3u/qdea1omriaGEvufGoC1J9Q/Th56EvoRElA4fV8nBM O6D/L8EFg0nkL6jdAmQBxncq4xHhPXo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NMnMmPVC; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727439844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rOO/RMJMndVoVeK71fgXzYzz13o8AL6/Nz/3/wUYT4k=; b=NMnMmPVCSWFkviPXAPLUP8BlmPVKKdIV/ElGoWDby65tSjovxmoPM7m35Yw9pJRdql6wcC OS/xqEBsZchhi40/+Z7x2LmFIeNAGNxyJK4d7LEDBe9A0hE3Zuz7wBZnhNA10fdb8/bADU azWx61ug6t+YQIZrkiHWtLRDXOh0I54= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-216-QBuIXnEzMVSfsNzNbxznyg-1; Fri, 27 Sep 2024 08:24:03 -0400 X-MC-Unique: QBuIXnEzMVSfsNzNbxznyg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37ccd39115bso1233341f8f.0 for ; Fri, 27 Sep 2024 05:24:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727439841; x=1728044641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rOO/RMJMndVoVeK71fgXzYzz13o8AL6/Nz/3/wUYT4k=; b=nt09Ru7IweYj/VJP7qjiOZ7xU5FGB/WAGhUq42gKo6dzJuNJ1XG2WmMZ3vzyKyP2Sw Q+vIXAJv3UmjDVKTsgSKyAKDlLk4YUmZfEpkoucjOLlAAq2fWXTa6IwpolCnkry7jK0o ChkO3om73T/g/7f+kTNNdqNVM+8Sdh/MHySJW2+vgDJ8G79XVVgxqtHIZGjk1BEexUrN eOdzOYkZXzyiOn+Uq0rjcl65kOFX2yMzLXyLrVyU1utkQ379Q/JwOMg11MICGhJHPOno bafCpJ7vmDiS8AB+QULbWxvWjBSu0z6fpGI729+sU5quQI36Inr42Wz5rTpz/CXxxM68 u4eQ== X-Forwarded-Encrypted: i=1; AJvYcCUDqw7cyHATle37LRZRotoYe2BYEGK4pgdz3StlUNSN2adwOG/RFLc4zKc2wGasZZjOb9c4oxUJfw==@kvack.org X-Gm-Message-State: AOJu0YwSX8MmuEeChECV9lvLcpFUnU8MKvtI0BWPAqZ7sABBwrMUkw5g yRSc3vpbPt/WBkLG0gLheIClIfqOfMLETda0VVXKFtZnCl2qT6QYnQss4ZNaAAS+pE7Thz5zP0T 3Pojjndu6MDOanCKHadXh9fc84EqFZAZx0hWO7FZeCLODMpNs X-Received: by 2002:a05:6000:114a:b0:374:c8e5:d56a with SMTP id ffacd0b85a97d-37cd5b292a5mr2156770f8f.48.1727439841698; Fri, 27 Sep 2024 05:24:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMdCrEL1EFKHWG5H8TyNvUQTkzVSw/bWL4thDMZuabh4Ub793nN7dXmSmqfZoWUw/tqASgiA== X-Received: by 2002:a05:6000:114a:b0:374:c8e5:d56a with SMTP id ffacd0b85a97d-37cd5b292a5mr2156751f8f.48.1727439841270; Fri, 27 Sep 2024 05:24:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:8000:b502:8c1c:3624:99d4? (p200300cbc7098000b5028c1c362499d4.dip0.t-ipconnect.de. [2003:cb:c709:8000:b502:8c1c:3624:99d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e96a52915sm73471995e9.39.2024.09.27.05.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 05:24:00 -0700 (PDT) Message-ID: <3ebf7c73-a575-4add-aca9-fb5079663ba4@redhat.com> Date: Fri, 27 Sep 2024 14:23:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Add missing free. To: zhangjiao2 , akpm@linux-foundation.org Cc: shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240927030114.3792-1-zhangjiao2@cmss.chinamobile.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240927030114.3792-1-zhangjiao2@cmss.chinamobile.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E1F67A0002 X-Stat-Signature: pfn1r3qd7i94qfjw68w5k3dwogdohmip X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727439844-495074 X-HE-Meta: U2FsdGVkX19Hk1lKNtmKg8FCSMPssaUZSr4+TSUX4Fho+8ehJCGOadqNKP/l2ZvqwMOBHH9nAyO8mGcdh3C69t6fLNer9dTPfRZS6MHvK/u6f2g8p7N8Wfv9cECXV+QFDLBWJTf4BDUQ07cg3Appzpb0WZ8/k1C4c5HDYb7LeIXN9N4muOj7iara1eiA8X0yM6+JXWxMCmPaWvZrMsyvFPG56XyuENrBXVSx6ycbpnOH38pBdGR1PZuHArFeo1+ECr8gFHtYQ1O0Lx0nfXottudnFU4YPh6e8Z6dIPTNneQ8+SQFNTRv2mGiH//rq+VXJUhfZzzqZC11DOBJw3kjuMsRQdt+Kt80bUdaw2wKjG/FasStFowL/0Mg63Fhfd5KNutToutzCfW0NhZGJfb9f7oXHoQaHOxrRTp1A/ft9XOAMopMYhEoKs1LdJLJseoV0dcc0W9p86rqU+uTcZ38vDctNQZkNbjTwCquqv5wBpTdutGBd6AWmhUgRCAgVCvJSRnSGOiiOyJBmLaeaIReRAWZ9wUgxnsMK9rX/YIziS9AOyjG1lKsK5O+o7DBPnTLUGwthw+L8Sek7/wctb5jAKvEejp9BjiZTUwozJzhNzyil4fiPhklfM5hHjFTx3Sv9NwsXjCES+lQOjCbMh98xiJTMsXbho88WgjfaNoHa9ldUKeQSRKanjMgYipv/siOwR2rrDfEVMG9In0XN2adLbaTtKzgcK4HkWfj3DXPc9Ro0RpHGMrpfvIWHj6wx9iD6IlAxeAxSu9LFFYDsqYl4DwG4UnuwLYQaTiyZ4+6L4r+D1BBe/Fchw8iPUtHiFOT2aTmPI9gMy5xBad82McFvce1R7Kp0/kdk54TBTXYgkOanRgCfK3QGZKgOBf9fpCNSz4mTnBN+qaT/N95T3pFuCNMcmbFSluAszYYpt/eQG5VVXA1bUhKP/cCfmlQlr1rv49bq4QEOLrWp9vOpfl cmcyDIU/ Sp/dPUp+VmZLrVnigyXFuMTmwNO/HGLv7nYUuQpsy2E7T73Q55l9ejlRYXu8xULyaax+/HPUNRT+iAylbJos0UaYroPvroMV6xCNIP2pf7F9+z3YG2Onvdm+t+dgBIc9Edetk+v9u507f3SSvXd5Rz4jq9lMgSUX2ym4h8N6GvtRLUpS+e51NFVtmiPYt2RCSDfytGbSmNUIRB+6Jiiw5a3fGQstmDILzEaRwzRI4I4lyHA8rFCcaJSmLMt5+Og1GV78eYo76aV7zVppgRNN+T8KAxIjXvenNEy3QGFxE8xnNqWixcx26ix1cKt82GRsmoraH6QC4zFhtGhjtK10Dk/F2zU86q7XYpRU7T4BAjhd3HKX+oH1f4H7pOxB66a5z3NUnlRXVQ0Jhq1i0zcIzsxLXQar8f3Aif2BJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.09.24 05:01, zhangjiao2 wrote: > From: zhang jiao > > There is a memory leak in mkdirty, just free src before return. Now explain to me why we care. The program will return immediately afterwards? -- Cheers, David / dhildenb