From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2003C02181 for ; Tue, 21 Jan 2025 02:17:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35D0C6B007B; Mon, 20 Jan 2025 21:17:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30D506B0082; Mon, 20 Jan 2025 21:17:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FBCB6B0083; Mon, 20 Jan 2025 21:17:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 020556B007B for ; Mon, 20 Jan 2025 21:17:54 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9A1A5160590 for ; Tue, 21 Jan 2025 02:17:54 +0000 (UTC) X-FDA: 83029848468.03.5B27277 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf30.hostedemail.com (Postfix) with ESMTP id A0C9F80009 for ; Tue, 21 Jan 2025 02:17:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737425873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kX3SRc3lPH/wGTgvFKMBrxej0BB3Vn/bB8yRR4982g=; b=zeQVRI61s+UUWXZnd3okLbBpzd9arGgt/aZh37kmDEYcRDXzA9R5pmKEs+B2o8I2ZcDb1S x1YkQXYCmTuZh6j6lFP0xDb92w5hh9dwmkKkwzVGD2WZWakdOrhXDCnamsQjYiSDErPa11 72MmgHBy2gRnZZrLTcz3cES/xte2qJI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737425873; a=rsa-sha256; cv=none; b=osEKBajgJRm06XpI6Vorolw9ObqTeJceoEbuQvK6VgQlE8jnlm4jSKi/deuA6KVCpjuyjM AZ6qcE8rdLFEk0XujYqlTcEkRnGPqjk3qSxBqqCJzbqduG4PQOTLBkieIyo0/jhnLqE+39 V77V2WnprgSlriGg8vRMC2lrZvwiGDI= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YcW460850z2MWrc; Tue, 21 Jan 2025 10:14:30 +0800 (CST) Received: from kwepemg100017.china.huawei.com (unknown [7.202.181.58]) by mail.maildlp.com (Postfix) with ESMTPS id 7BC631402C4; Tue, 21 Jan 2025 10:17:47 +0800 (CST) Received: from [10.174.178.120] (10.174.178.120) by kwepemg100017.china.huawei.com (7.202.181.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 21 Jan 2025 10:17:46 +0800 Message-ID: <3ebe55f4-99ff-4144-95cc-a8fcf682bc90@huawei.com> Date: Tue, 21 Jan 2025 10:17:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , , , Subject: Re: [PATCH v2 3/3] mm: memory-hotplug: check folio ref count first in do_migrate_rang To: References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-4-mawupeng1@huawei.com> <3b993af4-1fe2-b250-5d07-5840f1ad530d@huawei.com> From: mawupeng In-Reply-To: <3b993af4-1fe2-b250-5d07-5840f1ad530d@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemg100017.china.huawei.com (7.202.181.58) X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A0C9F80009 X-Stat-Signature: hgum8m5iqpfiticg8a6dik4ph9k6hdwq X-HE-Tag: 1737425871-182932 X-HE-Meta: U2FsdGVkX19DxXy4S/K2uqIc2hS7/5rV+qNcw848yq6onfMawypcI5vegrZa6AATMnAlAsUtnIWWFi8bxi85gRxpJ6jXPdQB5v+zTB+7U2RagDK8YKLNlI/RtLq6TfwPmFnC1MXc3uIZNcf74FsbR44V1rb5tNTrHGpRLNj2jMmslYDFJUTHp0bWbp5XMXxk1f38pll8c+l1VceRxq2riUORIcVIEH4d3XBIy7v1egEqnJhEbEGZuQw1fL0YZ8kRimwvYpT/3YmLZsUIr0z2ozV9nY4SNQgzn+rj9FTOxVV9tK6oEYGT+pRK+sgcovDhjUyMVpTgZU02eCjo4ELDbT7eYBLpLwaDQTL0ntwtixTwjGAT3z+XfGS/YmqU96Ja5WU7Yem2j93Lr8hToTCEz8wf+TQaHPzmyQ/E5ZtmCY+EzqaoaT+AN1F5OIOKsUDrouIZIA7qJrcGnR6wuPgWM+s+PrVE/T1H7KAQ8HsPcxQYA90pP0nMkOFlqioaLwj58+c9l07Y+09aa5FyTTfAW1YGFrVYso+snJdtcxAiTYAWRjFQmZrEpZPGVufII5Jb7yys2cOHFKPA1bgTD9Z+WtDupzcbrcMivhtqiQvrphaa0TivdlV3Aq5eh7uxwsurpbuhnNHO57wQY5bY+RQx7f+VQxdRWR5zVYMQMr7+0+XtWmQPk7QbJU+oik+2s9UjUOOlwmsu8GH+pUVQ+J2SN93ONGvaokz/KEnLKd93wsFAy8bo7oKeWrmQCEPxNs4H2yEkriC8Y/1j1UEvzZMuRZUuSI3e2R+WV18LqgZSYI2YMrcCh6EB6c8aU9m5iw0lMTtgVldSxmH4gfqdcOGEX7dcgHahuR/pPHlXvDUEM8PM1yA4DN/RhzDLgD9Ve3VoV3HNQxZMnq/QZ4AsjpL22jJypNaS8bbm0fiIayshO8f0tI00kO5mAwJ9F4H3CTgpyM8nG6kwUxUKzwyZsP5 k2mt2+Q5 ypj16p9x8f8sPrqyVsXOwMmBcPm7KD8vACOjjP5sPnAvtrW/rOy34a6NrgJ1Bwrc6RQw0yTThfkE87B+3t3A9lsrlvgIqsRNY0ylyRx6Z6VS8zcYo5KTSufvpBC8as+6uI/8GCIZAgPfpXI7rxNvRx7j29sJjrfZAceBttsU8bMxl/5E7NNXNYLFvbI4XcmpTBw/D1hkvjWB9iPePcR5yrmNhsR2Amfm5bWQ2iIDrfPQa2dSqHKx3BQhioUqVhYvsNXjf4pMi1DbIdwpmG8jPdi3kCrYnIditvI+AQofEn01OICF9HR+xMAr0Fw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/20 14:32, Miaohe Lin wrote: > On 2025/1/16 14:16, Wupeng Ma wrote: >> From: Ma Wupeng >> >> If a folio has an increased reference count, folio_try_get() will acquire >> it, perform necessary operations, and then release it. In the case of a >> poisoned folio without an elevated reference count (which is unlikely for >> memory-failure), folio_try_get() will simply bypass it. >> >> Therefore, relocate the folio_try_get() function, responsible for checking >> and acquiring this reference count at first. >> >> Signed-off-by: Ma Wupeng >> --- >> mm/memory_hotplug.c | 14 ++++---------- >> 1 file changed, 4 insertions(+), 10 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 2815bd4ea483..3fb75ee185c6 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1786,6 +1786,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> page = pfn_to_page(pfn); >> folio = page_folio(page); >> >> + if (!folio_try_get(folio)) >> + continue; >> + >> /* >> * No reference or lock is held on the folio, so it might >> * be modified concurrently (e.g. split). As such, >> @@ -1795,12 +1798,6 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> if (folio_test_large(folio)) >> pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; >> >> - /* >> - * HWPoison pages have elevated reference counts so the migration would >> - * fail on them. It also doesn't make any sense to migrate them in the >> - * first place. Still try to unmap such a page in case it is still mapped >> - * (keep the unmap as the catch all safety net). >> - */ >> if (folio_test_hwpoison(folio) || >> (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) { >> if (WARN_ON(folio_test_lru(folio))) >> @@ -1811,12 +1808,9 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> folio_unlock(folio); >> } >> >> - continue; >> + goto put_folio; >> } >> >> - if (!folio_try_get(folio)) >> - continue; >> - >> if (unlikely(page_folio(page) != folio)) >> goto put_folio; > > Will it be necessary to move this check above folio_test_hwpoison trunk too? Thanks. AFAICT we can do this, I'll move this in the next patch. there is no need to handle this page if the state of this folio changes. > > Thanks. > .