From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15609EC8732 for ; Fri, 8 Sep 2023 02:46:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17C3D6B0093; Thu, 7 Sep 2023 22:46:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BBE6B0095; Thu, 7 Sep 2023 22:46:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F363D6B0096; Thu, 7 Sep 2023 22:46:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E1F8A6B0093 for ; Thu, 7 Sep 2023 22:46:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC96940387 for ; Fri, 8 Sep 2023 02:46:00 +0000 (UTC) X-FDA: 81211890480.17.0F35400 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 024AD20016 for ; Fri, 8 Sep 2023 02:45:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AuYbQVdf; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694141159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9h7VfuU4Oy/BBgAD3W63aRNBjYZvFElCK9G+YIFUMro=; b=elOGN+1SHoL+9fUnnHrBW6mPp6pW5yosYjNgfqy8DzGhRAlMoCbmvDMhk+MbJrxlDBeivz 3L9yo2h59SGiyaYlig0x8V1237fYwjZoyX6SacR+Ep5bHH0UAeW1OmJixYARhgWtHK1rD0 AtazCaTyGGjhh1bUGu2saGU5obKMxfs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AuYbQVdf; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694141159; a=rsa-sha256; cv=none; b=WR6BREBVtWQHItlVl/aob2u6ZW5dpfDtST4GgjW+0liXQxpRDc/uITm/ZbeeLEqeaYHxru s4zhm0JvHNLaZDb/T1fxAB9mjVZy7r8qItaWjglZAZFU/jAAf2ry6b8ssOHx1j6iAdB0d8 6x+RVMrBI2xsYFjobjVP+kvONx2taoE= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-68c0d886ea0so1410926b3a.2 for ; Thu, 07 Sep 2023 19:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1694141156; x=1694745956; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=9h7VfuU4Oy/BBgAD3W63aRNBjYZvFElCK9G+YIFUMro=; b=AuYbQVdfiZrt2QNmLBcRihHjmVE/TwX5t4uZ0MAI/DyHlAmyCn6k6ofhJBjdZn1Qnt a8MNR8HsOzcfUPgy7I1633YbAPzjPQ4Kr1K13GSkw2/quHwKCbEoUNopsbKCMtNTR3Ru Z+6E7PqgQUd0PnS3X2Xr1f2LtoqLaosMzLNgDyLeZhu4EuryEHBaNqC6EDZqeyV9ZN/t /1MPu0KEq9CFr2JBYMrK1L/83u/GHrbE5nW6PBOHwUnO36tf2YN4816pfrcx5Fpqpq6y khHDrJk+8d9rE4eoEQx416yD9sfjBHFvKEbTtAqUYK5TxEKy7TVANOP+rBVSEWCetDaM bWDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694141156; x=1694745956; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9h7VfuU4Oy/BBgAD3W63aRNBjYZvFElCK9G+YIFUMro=; b=Bp4fV3CV1c+YIWEYnsTY33aWS8Oe+z+O2C28uUszcFPppOr3D00coxHN59Dy1FQrdH QDRD5tLcul2IISMz+WsAMumE9M6IShppZIA0CRR3bxjwXYV3jk2PQEpm5CR2meWDW+ql dQbIz3kj5grWCuOmZYDGMTtcmn9qDTTJCTjN52MufM8pvS7ngv+wU4EiermyFKTjA7JI KjPv04XmsJYCxiMrnrhdcj4JUDNlHw/YwimvLD56yGYRODptDYyy4IawP++v2QqGZj27 WFYRv87lt+nC/cAO3pRWczqDgLGK8SWogtEhrLSrmCbYH9guFoPW16hVDCS/vAg/jaA/ VswA== X-Gm-Message-State: AOJu0YxOgT3kg9gPs+W6HnCdyq86Yq+ApTfJ+rrav5ju7mzvvJ7kUcrK s4iHdMYSJes5ppkewqC4uBcOTQ== X-Google-Smtp-Source: AGHT+IFQnqvdNGpryMKcZ/mzsBNIkInaLkAduE8sTSSLhlfJiuy33tUzTGUUvwepdzpMVoAqKZwRRA== X-Received: by 2002:a05:6a00:248d:b0:68e:290b:bb57 with SMTP id c13-20020a056a00248d00b0068e290bbb57mr1309970pfv.18.1694141156556; Thu, 07 Sep 2023 19:45:56 -0700 (PDT) Received: from [10.254.232.87] ([139.177.225.246]) by smtp.gmail.com with ESMTPSA id p15-20020aa7860f000000b00666e649ca46sm357491pfn.101.2023.09.07.19.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 19:45:56 -0700 (PDT) Message-ID: <3ebd7fab-ba27-9abd-b06f-b16fa567ebbc@bytedance.com> Date: Fri, 8 Sep 2023 10:45:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 1/6] maple_tree: Add two helpers To: "Liam R. Howlett" , Peng Zhang , corbet@lwn.net, akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, surenb@google.com, michael.christie@oracle.com, peterz@infradead.org, mathieu.desnoyers@efficios.com, npiggin@gmail.com, avagin@gmail.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230830125654.21257-1-zhangpeng.00@bytedance.com> <20230830125654.21257-2-zhangpeng.00@bytedance.com> <20230907201314.g4scadi3tk5ctrd2@revolver> From: Peng Zhang In-Reply-To: <20230907201314.g4scadi3tk5ctrd2@revolver> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 024AD20016 X-Stat-Signature: d7azpiyp78qcgq85zmjer5ymy4ajdj5h X-HE-Tag: 1694141157-666693 X-HE-Meta: U2FsdGVkX19vJADMEnRBUbjfnvnrHG2ZdWSqlZ0/CtE5bxO6xnk/Pbxbr3aCofYAkheEPI4f6nGdiaKimcRN8TrejY393prF0TA/bDRM4MW7m791GsujXRu4U1XV3V6KuJ3bSKl1D3OB6PGsp7X4AOr1n7AkFif5M0vjEyAr3KEEYjXF9SDqiCRqmS8dCHCOCN89W2VYI5SA7a62gP/B8PgYjVgzkIHLphPESYGzMcbEH8kl7VpPYH5vIQ7BoF0A4Fg6ztd9vxHN0O3Bu6thMJjygVVEehOQVObjWMnuPBC5vlKfjBSCuRJhs64M8G6FH3LbYNQu4q8MeT6Lm+MrHRmqfEfApHjZVOR5CiD0unJRKsigAmv1HnR3U2DxGwRv1lJEjxXd31kbrKWm56ARzoSbceu7CygcZOElkrMgi+NFrvpRwprA7DofsipnTa1hh+dMl525iItqzKwV9DL8T3BP4gD1ZEY7Z6fWx6ZNQQBX0UF5rVHK1S/N0/Zi3AdEjHiH2U4XuqPZ1enFVpJlQ4J8TQpPHi0iqzD0UJ33m2/zOTQYQ6fr8soVaPY7Huy8jdRXzOocaWDQJMKtILjcgY1sAwxfd31W7xoB8+Qui2C7yHuigEt9gXRzjbX5Sp05xzNTKuN/S238ABTljINTwsiiW8vI2KMJTRpnQkGd7pODUqzfaXyA8sa6Y1xc0jNrZlx0nMX/L5lqrK1SyBevdJJ4o1ckVfMS4AI20N9lxGCudk5rRwjCCuTsa7wikIqf9viLr9XH4npVu1MJD+v4HpeCNiv46EP+lrF17TYZ/IsnxeW0AeuYLxhtut/5f0uA0gt0JB/qAu9bwk2RHwmz47yR+3TzCNvmJ2ebG4GgO971F5gw2z4/PbvHYwtSbFbtxUmKk6uTWbfDFF9KroLmUyzDVk86vwkEB0Yr+hu1SjflnmIFYhNk20ddiq/mGYQZWcRKf2iMgKe6BuRC/Sp Rj3fca3w TB6YCKmHUAzE9VdWLFSEER4xzrGy7aUxhy1D2aCvUWf2Lk9zmt21CYB3jUED/trDRGUrke4gh2AAvAO2kp9nAs5s/qPcQjXyBCItGqGoG37bXOvcZzHelwMh6IijpkOmYA+dmfHU8yphu9Q1lBv1g2RYYPpVuDp/NK71N1xK5QP3SLTxhB+sZwiVCvHdcGm19xpmhIYuvSSvsvaFp5vpPA4hCMmrpNJN8te4GmZJgooR60Rsy2x0tSLGN32mrqdWPvQ+mpm0HOtG+iHyd3RhCGEwQytqeJTZBOwY6VoshOCRrLCSHsq5LETutZNeXuaT7YFOBwbATOqU0YmpcY08r9fz8e1N7u/ceYZQ2NpLIkI1NOMdFlG3NEMx25xabfor+1Vw0zsiN39D0Xn09+9RuSogZ6hRaQC+ZvjC24AUUK1QScnR5ZuMtzoSKUv6KOgtxTZw9O6xxXZTR1sCSPM84s2/0yXvrPD1i3qiL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/9/8 04:13, Liam R. Howlett 写道: > * Peng Zhang [230830 08:57]: >> Add two helpers, which will be used later. > > Can you please change the subject to something like: > Add mt_free_one() and mt_attr() helpers > > for easier git log readability? OK, I'll do that. > >> >> Signed-off-by: Peng Zhang >> --- >> lib/maple_tree.c | 12 +++++++++++- >> 1 file changed, 11 insertions(+), 1 deletion(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index ee1ff0c59fd7..ef234cf02e3e 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -165,6 +165,11 @@ static inline int mt_alloc_bulk(gfp_t gfp, size_t size, void **nodes) >> return kmem_cache_alloc_bulk(maple_node_cache, gfp, size, nodes); >> } >> >> +static inline void mt_free_one(struct maple_node *node) >> +{ >> + kmem_cache_free(maple_node_cache, node); >> +} >> + >> static inline void mt_free_bulk(size_t size, void __rcu **nodes) >> { >> kmem_cache_free_bulk(maple_node_cache, size, (void **)nodes); >> @@ -205,6 +210,11 @@ static unsigned int mas_mt_height(struct ma_state *mas) >> return mt_height(mas->tree); >> } >> >> +static inline unsigned int mt_attr(struct maple_tree *mt) >> +{ >> + return mt->ma_flags & ~MT_FLAGS_HEIGHT_MASK; >> +} >> + >> static inline enum maple_type mte_node_type(const struct maple_enode *entry) >> { >> return ((unsigned long)entry >> MAPLE_NODE_TYPE_SHIFT) & >> @@ -5520,7 +5530,7 @@ void mas_destroy(struct ma_state *mas) >> mt_free_bulk(count, (void __rcu **)&node->slot[1]); >> total -= count; >> } >> - kmem_cache_free(maple_node_cache, node); >> + mt_free_one(ma_mnode_ptr(node)); >> total--; >> } >> >> -- >> 2.20.1 >>