From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE80C3ABC3 for ; Tue, 13 May 2025 10:38:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB50C6B00C0; Tue, 13 May 2025 06:38:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B641D6B00D0; Tue, 13 May 2025 06:38:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6166B00D1; Tue, 13 May 2025 06:38:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7BA796B00C0 for ; Tue, 13 May 2025 06:38:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 928C4BA691 for ; Tue, 13 May 2025 10:38:30 +0000 (UTC) X-FDA: 83437535580.09.361C8AE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id 559F7C0002 for ; Tue, 13 May 2025 10:38:28 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P3+AzjPF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Okm5l0Q8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P3+AzjPF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Okm5l0Q8; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747132708; a=rsa-sha256; cv=none; b=p32orT5NBXmepsBAs0Mxe+xy2jyWLGnlaziA3rK6EFaAS/wXkSOA0qaeL2d56U74QbpVdV qwgU+tuZ3EDvzzYBHoJ3SoW4doopWufB7ibhBH8fpmT4tzEdzTlzGZRDXBTie3tT/9hK0w Xs9KLTNMqEk56vgO6VNyqJtdmqd/nrI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P3+AzjPF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Okm5l0Q8; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P3+AzjPF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Okm5l0Q8; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747132708; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WWVeGGrrVccIAgdnNbZOJAAMnTBUdv4oDXowtq87uDk=; b=ZTHIK1VEVVpE4Hd3SDaxuI4X0lu+JbTOzRjQd+tzexqEkP+Etx3f0r9/XGOr+7eCnjCRyv m9cEz3XHYPxfJNYBHxFkIv2Q0ZCCZ7Z/xmjN/zJUgL0A5mK4q8/gALhjckxYQ02MM8JWMN mgM/9Ipb9rcKT/JxyKamZeH+6O0Nkpw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B65D821197; Tue, 13 May 2025 10:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWVeGGrrVccIAgdnNbZOJAAMnTBUdv4oDXowtq87uDk=; b=P3+AzjPFkNakHEM95xQQr3oLjUoJk8zOjjvZbxwGUFJpriPDMb0qg2VuQkccnYDOt47vn4 E1ScVCgBDwJvQWQjcKaF6c7Kr4LBSnlFSgs0ONNjFUg3pXwcVjNseuWwFyY+3JHHclFbkK EodTeain+LCy0aM7sOUoaCuup9BVN+k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWVeGGrrVccIAgdnNbZOJAAMnTBUdv4oDXowtq87uDk=; b=Okm5l0Q8DGC6QwnBNviCL323g5PTKMmwocNzSZxyqaEZrHstUyWGffiGdeh6rJQhYy2jb0 1tCK5W2knUNOd7Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747132706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWVeGGrrVccIAgdnNbZOJAAMnTBUdv4oDXowtq87uDk=; b=P3+AzjPFkNakHEM95xQQr3oLjUoJk8zOjjvZbxwGUFJpriPDMb0qg2VuQkccnYDOt47vn4 E1ScVCgBDwJvQWQjcKaF6c7Kr4LBSnlFSgs0ONNjFUg3pXwcVjNseuWwFyY+3JHHclFbkK EodTeain+LCy0aM7sOUoaCuup9BVN+k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747132706; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWVeGGrrVccIAgdnNbZOJAAMnTBUdv4oDXowtq87uDk=; b=Okm5l0Q8DGC6QwnBNviCL323g5PTKMmwocNzSZxyqaEZrHstUyWGffiGdeh6rJQhYy2jb0 1tCK5W2knUNOd7Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 90CCE137E8; Tue, 13 May 2025 10:38:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /YgNIyIhI2i/IAAAD6G6ig (envelope-from ); Tue, 13 May 2025 10:38:26 +0000 Message-ID: <3eb24d4c-05ec-4c4c-a181-25a987fe69e5@suse.cz> Date: Tue, 13 May 2025 12:38:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/7] memcg: make mod_memcg_state re-entrant safe against irqs Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250513031316.2147548-1-shakeel.butt@linux.dev> <20250513031316.2147548-4-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250513031316.2147548-4-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 559F7C0002 X-Stat-Signature: anzxkwkmmjfkbudyxr71f7fbdhpa68py X-HE-Tag: 1747132708-146789 X-HE-Meta: U2FsdGVkX18BrPXuNW+rz4htttR/mVglfH7R4t9GHOznIKrpFudVM038BfOqmN5tbDud6VMOvsnPsXW9PqY17Y6g+BSQbG66EiXSKiCjqNoknLwHbJEsBULDAAgNn95ikUHCYbIA8uwF6J34PhdoR6OeIzqgBfCwItLgle4ZcZfJaOG6Gk8H9rZQ54os9QfyaE3wqlTDGOTzVUsJURouI9KZhloprcLGeLScv/HPlt3kzefCoGDWBWV///5VEEuhFBouhp0zdsrRNd6NwwUxLhattL58dAhEby3awyRmOOoYuHgA3lW8rG802u7sNrmUC4JY9IjBoT4Yoc4sVYoKn4Hmj3QX+yX+WnQTP3ktaCHfuUcM8tblSUK3qrgHbLVMKQ014rptH/6+HD0TXLMPGY/7HXCgkqR0ftSKhH4C5YPHZw8w0aA3g3dsYYJHVlus6K99wKw1NbjopTqIQ4DjTV4pEadY9kXPIAYBTzoBpoZwjRqInh/0st1GjtOKnaGiCDbJC+wM+5JUUYQE6V8JFzTg7e9WJXcNNwaHoFfFw3G0LR6QjK4sb2uZ4PeYklw/AF2xlO8ATozlntgMJrdmCyfcgnB3bDYd/vDac4Ik1YXidtEkZ1Funl2MHxWnXUlnC88BZ/cQy9GyoRRyBf5nZJU6PguglMB0a3KJpC92FlmjaXC+na6eOD9z4JDeuYZcVKpQbsKaQZrCn4xyoUcxia5P1X9xVw/wYBnxy22saZ6P/3HQoC+7zezRyj+Lv5McFP/IsLcITFwHoWknF9QInILLpFTPHbz15QOAEHYx50Cc+tuM/m3KKbX6XmOOA8gsNoaM9ow6Ec/t0zmOtF+SJBuPQrd+Cpu0hh0pBocqZ1Wk9OtjdZBCrrrqNCZaLE29LS2aM13nQvKsCSxxVFzuZH1Ly4fUObTCATetegjdUPlQ4CENjPr6XVHXac3eZZo/HllXsQftebHs43lkka4 r79cZsm2 ny8YeN68A4GTHhzbyfvibK22DiJXfwaIXQt4AY/oposcF07Ay3D9UeHoWCJRhcA/jAySDU8FL+HTPHzzzTAsDLJci2zuEvKb+Es3R2HaggTTKrbL1uH6xGV6sxOpzneXRtbbhBqIpKW43siLAx5vIIC6tN/sSojpyCe6EyUvQnbjlsyDEhdEfx/bDOcGY1pnuUlRBVnwm+nKKV3JYXe+sSILhwMAA51AbjoMUTz/T56dFgx9jC8Fe57HlXO8jjEAvnF9bixYQZGCWbQuzEfIeps1CAhl4+TEStOBVOHrIsg0tF0uhOZVIgCwVieQBQff7YZrQRjSv4YimQRdJgJIXUqYdfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 05:13, Shakeel Butt wrote: > Let's make mod_memcg_state re-entrant safe against irqs. The only thing > needed is to convert the usage of __this_cpu_add() to this_cpu_add(). > In addition, with re-entrant safety, there is no need to disable irqs. > > mod_memcg_state() is not safe against nmi, so let's add warning if > someone tries to call it in nmi context. > > Signed-off-by: Shakeel Butt Also a good cleanup. Acked-by: Vlastimil Babka