From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EA43C7EE25 for ; Mon, 12 Jun 2023 09:50:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D09796B0072; Mon, 12 Jun 2023 05:50:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB96C6B0074; Mon, 12 Jun 2023 05:50:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA85B6B0075; Mon, 12 Jun 2023 05:50:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AACF96B0072 for ; Mon, 12 Jun 2023 05:50:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 781DD1201AB for ; Mon, 12 Jun 2023 09:50:03 +0000 (UTC) X-FDA: 80893624686.17.EDE29F8 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf12.hostedemail.com (Postfix) with ESMTP id 42D6340006 for ; Mon, 12 Jun 2023 09:49:59 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686563401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K0YR+PeuIaGaOmm/FMk3C+DkVjdKIQqa+Dx4Q+mrpJo=; b=rfSdlc9h1kB+YTxd4IlicDeFwOWL+f/hFHOP7N+8s2zlmJZvBu9zk3EGa7aiPlfHeGZ6eA MTxAYcoaDF8q9fEnMJGvmC2lzGelw0OxQqW7rs/IuO3QRrZFCiLRweN6bUXfcagsL4j9GC omFEIdIw+PT2YOfhu97orzqzt1NNXNc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686563401; a=rsa-sha256; cv=none; b=QKsT9VXOhGgmSvAI1zH2V17HbbXR0xDAox+bAs0eYCKl8RUy+NPtBV+lopJP3MT8+Gr3wU 8J8b7P5MA472sKjyxLnilp/ceNepr+TdojZE83aE6cajge1Jk7Lxmr24vdYurN00didDHY k7X/vVGfSyLuw2PckQ1Uw2SrUNkb9/I= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VkwjQ3o_1686563395; Received: from 30.97.48.52(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VkwjQ3o_1686563395) by smtp.aliyun-inc.com; Mon, 12 Jun 2023 17:49:56 +0800 Message-ID: <3e97e1a2-47e8-9223-426d-5089f8802ae5@linux.alibaba.com> Date: Mon, 12 Jun 2023 17:50:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] mm: compaction: mark kcompactd_run() and kcompactd_stop() __meminit To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230610034615.997813-1-linmiaohe@huawei.com> From: Baolin Wang In-Reply-To: <20230610034615.997813-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: fcpbwbbrkt18ngtm8pyxjmds1jchntm7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 42D6340006 X-HE-Tag: 1686563399-614429 X-HE-Meta: U2FsdGVkX1/ZZrxVmNv8S5HL5hcwj0qZimTrgwbvXibkaGcGbC1NXz+AWK2PtUKv51YKBwIc3+th7vSOxlgx7YcXCCTqMaD7G2WlrQovRiVpPtxn8ZaXl/j14ogzaEIvnWcM6djtv/7AfF2PadUcdzOcJQ/z7J7uOZCBlOil9eE8topwxs+wZRd70IVialAUWNFp4U53nJfhBHkSWWhL/F4L74LbDpt/KHuKlMEF5opaNcoWHLMyBs2XYZxrxHDS9u4K1g5FGXv+OM3eqj+Y9iaRPUctTQk0TCiJGTP/1BhbFw+Nca2V3mNKgOOgKO6vdViBYeX5cOxi6Hc/vImPslRNGIpyvRbJ9FxoS+qcuTWCxyXvmCUOxb4pegfuIcK3DHM4WYcNFeKYvNAG6X1MPCsMd1zDWwpfdYqWPEhV0NCYURYcoL82Ppiwsd8OuJXJZCPS6mwlqpYpa7oLkoythcdWN36Ai2HvRXG3Lt423XfLLJXqYBV+nE4qrzIRbrckh0Q/vKFS9Nev13LWDeNagMl+E5HsMlWhtJIEUCqI1VdZvdWLGC6JpzcLNfLS2Cj5z8U/bUjZdqN+/bNOAi3Y0k4R/M31NRsgR7jAPT8z92L8ta/ZcZgd2yJG7TqSJdELP0CY+QUaN5eeL6Ypnkubf6Qg4GasHwpeWpjdPk3UglhXl5S4sgp7HLPQ14nYjwza4uPr/BA+iuXr3WnP1eClgnj3LdpDCKLqPodLzMM/2hMU1L6zOs+mXb88Q6JqYUVprXrL17BhJTFjC0i/PYeP+SQOtaUXICK4bznquYOhAMh8ujzTRvHtujdGUnBF7xslDS+MB4aOEebkNLT7CCWS/p13e1B9jT0IUs+e6qqW3i8X3m+GpWcEjxTqSfDcR8xDUeMHS73vDmAOxZp3aA+FTg+a11AdnGdR6wyaX3CUt72/PPApxsOl0cd4duCfSOT6QDcBfWCC+87HH7GbxB+ lkYt8jAh Cwm67kKRtbYDUDg1NvFmBBK9gvH4TWL9CNl1dqZpFQiznimqdhkh/R7gAGAwKLWu95OuZD9ulXbMzZh1RtjFQOVSXeZo9wMPpt7W3/daN7RAGSrf3x4qUKa83cCATGP1BxNvonMsxiNDzUUec8nhDjkpCSUUMxMcBecNp43OdBT8+oK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/10/2023 11:46 AM, Miaohe Lin wrote: > Add __meminit to kcompactd_run() and kcompactd_stop() to ensure they're > default to __init when memory hotplug is not enabled. > > Signed-off-by: Miaohe Lin LGTM. Reviewed-by: Baolin Wang > --- > include/linux/compaction.h | 4 ++-- > mm/compaction.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/compaction.h b/include/linux/compaction.h > index 57b16e69c19a..e94776496049 100644 > --- a/include/linux/compaction.h > +++ b/include/linux/compaction.h > @@ -98,8 +98,8 @@ extern void compaction_defer_reset(struct zone *zone, int order, > bool compaction_zonelist_suitable(struct alloc_context *ac, int order, > int alloc_flags); > > -extern void kcompactd_run(int nid); > -extern void kcompactd_stop(int nid); > +extern void __meminit kcompactd_run(int nid); > +extern void __meminit kcompactd_stop(int nid); > extern void wakeup_kcompactd(pg_data_t *pgdat, int order, int highest_zoneidx); > > #else > diff --git a/mm/compaction.c b/mm/compaction.c > index 3398ef3a55fe..8859cc91062f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -3086,7 +3086,7 @@ static int kcompactd(void *p) > * This kcompactd start function will be called by init and node-hot-add. > * On node-hot-add, kcompactd will moved to proper cpus if cpus are hot-added. > */ > -void kcompactd_run(int nid) > +void __meminit kcompactd_run(int nid) > { > pg_data_t *pgdat = NODE_DATA(nid); > > @@ -3104,7 +3104,7 @@ void kcompactd_run(int nid) > * Called by memory hotplug when all memory in a node is offlined. Caller must > * be holding mem_hotplug_begin/done(). > */ > -void kcompactd_stop(int nid) > +void __meminit kcompactd_stop(int nid) > { > struct task_struct *kcompactd = NODE_DATA(nid)->kcompactd; >