From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DFDC5321E for ; Mon, 26 Aug 2024 06:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89F3E8D0041; Mon, 26 Aug 2024 02:35:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84E808D0029; Mon, 26 Aug 2024 02:35:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C8608D0041; Mon, 26 Aug 2024 02:35:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4FF7D8D0029 for ; Mon, 26 Aug 2024 02:35:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D831F40CB0 for ; Mon, 26 Aug 2024 06:35:17 +0000 (UTC) X-FDA: 82493434674.15.AF0657D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 9CE4AC0015 for ; Mon, 26 Aug 2024 06:35:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e9LR8mnp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724654051; a=rsa-sha256; cv=none; b=1cMZIQZBfa2+t69BU9Z3N2zSjgDtYF0BHHxTv+zzlGPwbJk0g9RgfjTsdKrgdYsAnhqSuS hIPfnE4TiG57a42oEfrh4s4khBNWLvDkeUD2ZjThv0We3WRAt6w0Y/mC2IfrHRsxzXsv93 ZVdmHMcgifGyzlo0a8rY9BBDuqQWwmc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=e9LR8mnp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724654051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Io4rHxduQz7KVgfK4myMUjM2AwxJ/v33VowE2i/ueMg=; b=tGCNYPr92NsBr1kFPzToe7cZOskd2Ha1oxL+y23z4aqKhSBybk9u/6+exLFtYqvybugUcz xgYIAepuu/E2ll8QeuJe6TXgMTR1VHnsYORwRUO1Mp8Bghh5RMOpiLeXwv5noeoGzJZBr0 IO3j2e9X3QVdQLgJeZQGB6G5s8puYN8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724654113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Io4rHxduQz7KVgfK4myMUjM2AwxJ/v33VowE2i/ueMg=; b=e9LR8mnpTJb54tnGOOy/YCxNAZ4V7diuT4gCzBKY0O8kTXGyZRvvwbwI19PBcPNSAPO/hZ RLaUzMFhHESKn80bcio8VB6luXWsLHW16I3SnKa7/g1frLsqAm8xObnkCt/N79g+SQv6r2 c+FSVqlwIzpjEAKHov8xf6EVENMXiYk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-gVah04RGPbWf7i9fgHeO6w-1; Mon, 26 Aug 2024 02:35:12 -0400 X-MC-Unique: gVah04RGPbWf7i9fgHeO6w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42ac185e26cso39702655e9.3 for ; Sun, 25 Aug 2024 23:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724654111; x=1725258911; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Io4rHxduQz7KVgfK4myMUjM2AwxJ/v33VowE2i/ueMg=; b=wnSqcZDPFVJeoj5g6xYYrAhy5yx4NonjOEZtoOWvCJZhxdTLmR8BPP65J1y2GDA6fK UlKVh/hYcq9ljWBhGuSqGEvHK3/c0C1mVS7GOG3YPvekrCdRG/4pi3+Sp83xzrkp1Fh+ C08Qh4Qn7SwT3wjF4wSFr6A/TsyPak/gK1YkAl5RQKvCtZ738MSLZiJoQJZ/kKIAihJ4 24NBEKfUdCSLl/XBK1zNmK7YU2wRPmJd/OLZ5I7SgSZd19w7suTgzI3AHQQ0bm+l7q2n pkf1Fmx4FjHpuuZFni5F/hSt/Ypw/6qAoLzoog9uVvX6QNhAc5Bx/GCPw+qpdIoC3g0S WL0g== X-Forwarded-Encrypted: i=1; AJvYcCVIrrYq6MZZH9HKO6SAu6A2fVjR6EPke4pLGrRxno4TMCMF9kKBlY/AssF+ZDUjZHEk+bNgUW6xKg==@kvack.org X-Gm-Message-State: AOJu0YyQG+MXT04YMfPvPcTnC6tGoyAdM/d8/QH+fDeJsHhWgzPxzibC QWMIdrgTYrfUruAfQf4C23onH959gfk37IboGTQToatwyTO0xQLzJzvpLdTfypD9zsmMJHo16/i 8pmvbKBm4XI6JZ78Y8uBsF3Su89u6Lu7C0anZEIEKpD3owvff X-Received: by 2002:a05:600c:4fc6:b0:425:7974:2266 with SMTP id 5b1f17b1804b1-42acc90052amr65305645e9.24.1724654111361; Sun, 25 Aug 2024 23:35:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGD1UPOcNbemD8nX9kQpa7huIkZU0EulurEZhvyHQc1BNhaddTsoqhL6utBKUXaetrMV1u9zg== X-Received: by 2002:a05:600c:4fc6:b0:425:7974:2266 with SMTP id 5b1f17b1804b1-42acc90052amr65305385e9.24.1724654110375; Sun, 25 Aug 2024 23:35:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:c800:cf71:2042:6051:e26? (p200300d82f12c800cf71204260510e26.dip0.t-ipconnect.de. [2003:d8:2f12:c800:cf71:2042:6051:e26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac5162505sm142233335e9.28.2024.08.25.23.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 23:35:09 -0700 (PDT) Message-ID: <3e8add35-e26b-443b-8a04-1078f4bc78f6@redhat.com> Date: Mon, 26 Aug 2024 08:35:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] mm: count the number of anonymous THPs per size To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ryan.roberts@arm.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, yuanshuai@oppo.com, ziy@nvidia.com References: <20240824010441.21308-1-21cnbao@gmail.com> <20240824010441.21308-2-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240824010441.21308-2-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9CE4AC0015 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pjxdizcnfqxuczmtmnsf6zds5n9fz7kj X-HE-Tag: 1724654114-44853 X-HE-Meta: U2FsdGVkX1/noLeuw0KLl4fUCh6AwZRCvfoXZf+yaKD3Nnp1TA9b4lRys7ZNFQimiL2qxwziaq8AxuY3UI679ndb7S9+axKTPKJoGDmz5WYAKJOysadZJIJ2uxuN6elAqfvfcG9cJQirZg3ZN1USkV3HCIDM/FriXbGooCazrX3qkFOHz2qM38gFBOeBBSKKjD31O1V5izrHRtq8jPXJJEG9KI7PcQeI8U92l5tmqgBKmM4dw3hmZ/myOQnUytn3FgHx1EsKROaiUbDUKnNaHsdDLP2i5Klw/5QnpjzS3I3KdVnGJl2aTAxng5pjJTpAYQYarlqFr+v0HcYtL3lbXTKEcCKJoOQk1bzE96Pbnl5RPf4dIFX5fd0s3GLOC/BagUQFIVyl+2dw09iMvoHtvceqhsATVydvW5uGNkT11lDebzGAus6XDbJHHhS1ueAnGgvsl5pke4cZdGAViNmQvxvBQGSwK0LuGXxbU37u5z0UafDIeR9MRmPvbYYQlDRZddN7d4Wrted2Vwi72yBIWG1dJnGun874ZeUNdbfrIH67RcRiL9oHCU0bXlat7g3yR5dJpxc62e7x7YCSx2qDzzyjxozG+GZU+0l8AGzzhSvMwUtHtRUYEo9ifbQZ5fxboMtMKYW3vzIqBxVX4j1iqAJ3K6D5q5tIafG07aMTnKemJvyp49mI61V5LqNqp54TehNOZgdX2udkaYNePQFOJ9SUlYdVu9OQ5yg2GL39YCNzUZJFSeUOhAT/BJl2N2GuA89Kdj9Xj7X9NYTqMEI/xX9cyz8YN4RG+9AqtRdjQQ+5QZE3ymLpHOxzIvqe7kt7JuiA9rURnprc9UW3krKuKG4z3YB/lWhM70tldwwemfjveEjJtlHG46c47fa+27VVcBuItV5ummN2SuX6z2nEkhM2wGf4sRDFa/6bKhHvHxCSgoymB+BCL06FfL7keXw43hOf704FzePeziGpMYp bV3Wk5Hz PyntIsd37k3Zz+sKUktWq7X6Vj2uowTl6plfd8VWOYiFgAKkW5JnWNbm749Ut5i0LlAOyXN0H+ZjHWCxcugs42hzDAQ3m2udRpFLE2olTacoor3/3iYXhwyq/Qe30DmYeFfz4MvSr1cvzjMlnLw6CVCjyZJoBqOUpzm9D8nioREQbUoGErk2K9Vbwe0SoMML3RRJzkoWBC2RuhSbtlgSp7Ah2ebYkarha4B43+jQVC0yHKxy5H28AJMTdVOWz9hkjOXZqFBUvCoF47UvmppKYycYjII4QCs09KF/KQp0a6+aWYtOdAb8TDW3g2APAyZpZEAFN2mEykwPZwz2NpUwxq4e7/VhCEAezU2asuTrV12R7chQ7Yg3UqPD4xx6nplwNQ3/mPym2WZPsa3LDByBVylNl4sP/pGuvTzGW5FeXgQI+ntZzNnwzCuWknGE3p0HgznrERjsITwiX3/DX3tfXVrP9Sn/VgZ+sLOqGIfHyibQaZBEmNbI648uA2TvFQlUSc3wJcoGbwhWlHtCplnEx6JlfsMXoBOh2HwWQaCDDMmr/Rlk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.08.24 03:04, Barry Song wrote: > From: Barry Song > > Let's track for each anonymous THP size, how many of them are currently > allocated. We'll track the complete lifespan of an anon THP, starting > when it becomes an anon THP ("large anon folio") (->mapping gets set), > until it gets freed (->mapping gets cleared). > > Introduce a new "nr_anon" counter per THP size and adjust the > corresponding counter in the following cases: > * We allocate a new THP and call folio_add_new_anon_rmap() to map > it the first time and turn it into an anon THP. > * We split an anon THP into multiple smaller ones. > * We migrate an anon THP, when we prepare the destination. > * We free an anon THP back to the buddy. > > Note that AnonPages in /proc/meminfo currently tracks the total number > of *mapped* anonymous *pages*, and therefore has slightly different > semantics. In the future, we might also want to track "nr_anon_mapped" > for each THP size, which might be helpful when comparing it to the > number of allocated anon THPs (long-term pinning, stuck in swapcache, > memory leaks, ...). > > Further note that for now, we only track anon THPs after they got their > ->mapping set, for example via folio_add_new_anon_rmap(). If we would > allocate some in the swapcache, they will only show up in the statistics > for now after they have been mapped to user space the first time, where > we call folio_add_new_anon_rmap(). > > Signed-off-by: Barry Song > Acked-by: David Hildenbrand > --- > Documentation/admin-guide/mm/transhuge.rst | 5 +++++ > include/linux/huge_mm.h | 15 +++++++++++++-- > mm/huge_memory.c | 13 ++++++++++--- > mm/migrate.c | 4 ++++ > mm/page_alloc.c | 5 ++++- > mm/rmap.c | 1 + > 6 files changed, 37 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst > index 79435c537e21..b78f2148b242 100644 > --- a/Documentation/admin-guide/mm/transhuge.rst > +++ b/Documentation/admin-guide/mm/transhuge.rst > @@ -551,6 +551,11 @@ split_deferred > it would free up some memory. Pages on split queue are going to > be split under memory pressure, if splitting is possible. > In light of documentation of patch #2, small nits: > +nr_anon > + the number of transparent anon huge pages we have in the whole system. s/transparent anon huge pages/anonymous THP/ > + These huge pages could be entirely mapped or have partially s/huge pages/THPs/ s/could be/might be currently/ Maybe Andrew can just fix it up if there are no other comments. Thanks! -- Cheers, David / dhildenb