From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F650C001DC for ; Mon, 17 Jul 2023 01:45:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BEE236B0072; Sun, 16 Jul 2023 21:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9EBD8D0002; Sun, 16 Jul 2023 21:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB42C8D0001; Sun, 16 Jul 2023 21:45:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9811F6B0072 for ; Sun, 16 Jul 2023 21:45:03 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 61D181402BA for ; Mon, 17 Jul 2023 01:45:03 +0000 (UTC) X-FDA: 81019410486.01.65A47A6 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf24.hostedemail.com (Postfix) with ESMTP id 8874F180015 for ; Mon, 17 Jul 2023 01:45:00 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689558301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W12ICZ7yZ2sdO9JeKza2pEQ3M3R1jmpfAgpE7hsCOlo=; b=uYUrxXe7YeIwT+r+3cuvPmogK+rnW9MOzfGkBAgF7CCap6x9ByAnv3RJ6CpRCm3zxIqj6e UJMq9b+CmfL3r1k6ZEdncCbMg7n8D3Ed4xbZbjRwVla1VBYOSdJxNZyZtf47BUJ0/bweNX 2F3cERhf37tP4xM4ykhOVvZ4L9yL+m0= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689558301; a=rsa-sha256; cv=none; b=YFbtWcNw2Pznqu6gx6x3VhPeV1lxVSizOGARwHhBh/v/a4NkNJ7lXdrJ6cnzYYgOGbc5Nk lf7VZmDfsUwIK1EfSe9Y7Fzuoe3P444keR20IrOiq8E6VLCY/Z1jBVSWEuWKV/ORBufHMn k2NwT04cOjgSWjlTYm55RdJ2O+1Ow4E= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4R44c63XhczVjcf; Mon, 17 Jul 2023 09:43:34 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 09:44:54 +0800 Subject: Re: [PATCH v1] mm/hwpoison: rename hwp_walk* to hwpoison_walk* To: Jiaqi Yan CC: , , , , HORIGUCHI NAOYA References: <20230713235553.4121855-1-jiaqiyan@google.com> From: Miaohe Lin Message-ID: <3e587e41-b363-338a-9034-838013051cb1@huawei.com> Date: Mon, 17 Jul 2023 09:44:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230713235553.4121855-1-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8874F180015 X-Stat-Signature: 43w57fnpa1e1t75u19i8ipiphz5ugpd5 X-HE-Tag: 1689558300-705 X-HE-Meta: U2FsdGVkX1/vunyX2sK62YgQ27Ab1Z/c4kCjhgXKgpUX2ExUf21Sm5L+elZBXW9EFoZ5GZIjFtgO9F4BMnjuNewtfjCEqBCoN7oZgsp9DN/1clb4iR0upoldLhBS0Qs9zL6WWBkOw4RNeH5zlPs9r+wUd7Y8YEnjJ2p//onkattG+6GFBdKfTij238D/GtVymO+RX8BE8DuZW3ddHoEBp9cZS0/y+EEuEDlV+vhbGrPTkwC5oPpQ9nnbUKHHG51y3vD7YQguoNK0sanTWnhDNldwUBOgU+dp7RkPfDZqEUA51+aOzMr+yeVhYkKorqOy4JjQF3pn+Ghugg4DRkf5gIJu+Wdd58RHWr3yaqma1HXbX8WJFVkZWqSpqBIUYZKPf5c0J+bm6UMwu1cFZRtaX5dgzTiOy4S/5ogGqDYtqbHNoBKEll4uimybF1JIpNBj3B47HxwIB8/C/f1fT/W+U6eMs5aqUwNRdceWF+ZRvoUvQmpbamb9kJJ+L/STB7inouwxVItx/cOzQQGEPkUvGd+PM+tV01lIzEaQxGVAiWTrgNHxNIB/Yy399zF8uljsQREYdbjs7vnlCJ0eKHF4Qn3dkE23TnItk+x+X23C+pEQtGBObgVA5+h3U7B5oCvkHNIGhaCptWF1BLDL2w2SiiWhEVdE+VoVaIqT3u3zHHH0iJ68jyGg5Qc/f+P9Z8aquvrUqCcDHU7lsTeHJqE68TLVRJm61PkezOScGyKbgmKcgaOLV8pPQQCBdMJMXd+mi2rkKYGPjsqdHUfrDgKlo8//uaEyEqNPjebCtEGW0ZLhkaBxA/RNrOUcYqAE9tqLuttxo4WMIGzl3KPbGCq6TktLPQEKRCywV/lfGkWfeMsEGvaGScImCxAUCPlYd63/qScAcrKdSds1HGjNS/KQiNCfCyGKaPfwdg2pm/koxHnajW3cdpnWyB9q17UgtnptUPWwBGCKU4i0pyKGnjH 6DDiNgkS MP86zZUJhqk9jPsZW8Olx3m5cVlFnjMs5PTb/eljAAt+RcFZCGdnbp7HmN50bu9n05G+4y90QIgpD+uDt8uTPQ7qJQSwfdelVzgojN/RJnvT1bTtvgS+yoQVxW2SPEN9fCR4C4HG1n079zS7e7xgJOBJWIlfJR3NZ7R1mQIhwQ76XQlDu/Jltd5b8p8y59YMbiaRf9m+xn/drM7izEg0i6BJKTEnDqQAXBgdBJGPodVlYQDM4JUBsLD3kgB//r4Ccbb1oGV1XhnS+jiT/GshB3n6q9CQ0sp5NF30XXjJC1BHCwGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/14 7:55, Jiaqi Yan wrote: > In the discussion of "Improve hugetlbfs read on HWPOISON hugepages", > Matthew Wilcox suggests hwp is a bad abbreviation of hwpoison, as hwp > is already used as "an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver"[1]. > > So rename hwp_walk and hwp_walk_ops to hwpoison_walk and > hwpoison_walk_ops respectively. > > raw_hwp_(page|list), *_raw_hwp, and raw_hwp_unreliable flag are other > major appearances of "hwp". However, given the "raw" hint in the name, > it is easy to differentiate them from other "hwp" acronyms. Since > renaming them is not as straightforward as renaming hwp_walk*, they > are not covered by this commit. > > [1] https://lore.kernel.org/lkml/20230707201904.953262-5-jiaqiyan@google.com/T/#me6fecb8ce1ad4d5769199c9e162a44bc88f7bdec > > Signed-off-by: Jiaqi Yan LGTM. Thanks. Reviewed-by: Miaohe Lin