From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90ED1C30653 for ; Wed, 3 Jul 2024 16:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 072BD6B0095; Wed, 3 Jul 2024 12:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 021A06B0096; Wed, 3 Jul 2024 12:19:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDDB66B0098; Wed, 3 Jul 2024 12:19:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B3C396B0095 for ; Wed, 3 Jul 2024 12:19:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3AEF81C00AF for ; Wed, 3 Jul 2024 16:19:11 +0000 (UTC) X-FDA: 82298950902.17.6585473 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D69191A0012 for ; Wed, 3 Jul 2024 16:19:08 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MIpWO3pJ; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720023524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kBTef3Rb92KBup61SlBchk2oT3y8ZSkEqgAO4oEmAEU=; b=TEymFOvaxBuMYUUPWjtvp2Rq7+SaWS84bUlk35VW9XM6o/ghH59MsE2JjKa5IHlwH6vbFy FndyMZxKoVbzWr4giOteSHEFQPsDNaQvmjSH4ZXNa2q+g8nttznfRIO/FRmV0X15enEJFK tdChOmj/T5M22MEGUwimyUgWVHhlo7c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720023524; a=rsa-sha256; cv=none; b=VQPYKOtT04Ccq/XGszV9dXGsw0PyBnbxxOA8YBCAykE9lDUNzlEYQWJvxx06Jqz1+odONG +jn8ct0vAw7FYqA9xHRjs3YiVqPtfR6g/XOFfmKtCfW2twBQmZxuWPDwIH9ak7IFxplDGf FflCthdibEYm1pYYld2JmXKTr0mFJy8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MIpWO3pJ; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720023548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kBTef3Rb92KBup61SlBchk2oT3y8ZSkEqgAO4oEmAEU=; b=MIpWO3pJIECP06bW2PdobS/MDCblGMpxSfDlIDn1cicBFs9ZgxzFcSWr8n/qVyKVOKD26A THfBJdGLANHUzgluE/1moHnUV+dZ2ipED4jb6JBxvVWCuQ4IOR9ZqaPfae/uQisSprCNLU 5QRjnYmu+pPNFmBaRANHiDB+tqvrV04= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-7Npzuhf7NN2I9-da2fLR0w-1; Wed, 03 Jul 2024 12:19:06 -0400 X-MC-Unique: 7Npzuhf7NN2I9-da2fLR0w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-421179fd82bso39268465e9.1 for ; Wed, 03 Jul 2024 09:19:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720023546; x=1720628346; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kBTef3Rb92KBup61SlBchk2oT3y8ZSkEqgAO4oEmAEU=; b=USii1/cbfU9el5avY7iJn0/Q/SwSAbjtrJeup5RDzQP6Fr11gK5xbwOBRA/1qH6VSJ dG0xZQcflF/Rv/CeoCAIOyiF5LdeGfHaqbe7Liinv/4p+BaBkQth4G03o2i3TQJa6tGe kBlZn7MYshFK7AcWL080a9bQPG3bSw/VNjw+9z/ok35FvUCls4rAVj8dqoYQ1J0a681n Khy5iM7lt7m3qvZbm+ggFw7Ym6zx/tXDSWWPXTIUxzEtlZGX3r3hoabiBvaKgir05Ujq hGwPI3Tkqwe/XPChFef4jnTiTKHBDJ7zK+pwh5JTfRUotK5eDI73xs++LW4a4RX/xcbS MVWw== X-Forwarded-Encrypted: i=1; AJvYcCWEimqxMpRK+/ifELJAejKZNceMyDxonX0IoBmKIt4zDMzAMHTeY8J+T49dVB7fNTCY7xtHKmCv3MEClGEEtbYBVqk= X-Gm-Message-State: AOJu0YxX5JLSsLY6taFbd4OvFy45f1ZroCIDs9Bsi9jRWqVaSnpXIiSQ 2WqAA56jjIJI4PMoLBOMwhQzbU9I7YpiV4ei4StwlVERRRhOTM4/j4SBQgBY8x9lYng/haRPDOq QSjyQx7rP64kMgLs9cBH940WNpujHujip8JOlE6RzeemtLM4d X-Received: by 2002:a7b:c3d9:0:b0:424:acd2:40af with SMTP id 5b1f17b1804b1-4257a011a44mr85562735e9.24.1720023545735; Wed, 03 Jul 2024 09:19:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES3hCA3+99w5shoioL/LxHazJmda22GJdpocCDjjHmJ/NOVgxGc4qGdqMBjALowvpd1e8Wbg== X-Received: by 2002:a7b:c3d9:0:b0:424:acd2:40af with SMTP id 5b1f17b1804b1-4257a011a44mr85562515e9.24.1720023545136; Wed, 03 Jul 2024 09:19:05 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:3400:5126:3051:d630:92ee? (p200300cbc709340051263051d63092ee.dip0.t-ipconnect.de. [2003:cb:c709:3400:5126:3051:d630:92ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256af389efsm246725995e9.7.2024.07.03.09.19.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 09:19:04 -0700 (PDT) Message-ID: <3e2ebfd2-7a63-449b-901a-f559049473e4@redhat.com> Date: Wed, 3 Jul 2024 18:19:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] support "THPeligible" semantics for mTHP with anonymous shmem To: Yang Shi , Ryan Roberts Cc: Baolin Wang , Bang Li , hughd@google.com, akpm@linux-foundation.org, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240628104926.34209-1-libang.li@antgroup.com> <4b38db15-0716-4ffb-a38b-bd6250eb93da@arm.com> <4d54880e-03f4-460a-94b9-e21b8ad13119@linux.alibaba.com> <516aa6b3-617c-4642-b12b-0c5f5b33d1c9@arm.com> <597ac51e-3f27-4606-8647-395bb4e60df4@redhat.com> <6f68fb9d-3039-4e38-bc08-44948a1dae4d@arm.com> <992cdbf9-80df-4a91-aea6-f16789c5afd7@redhat.com> <2e0a1554-d24f-4d0d-860b-0c2cf05eb8da@arm.com> <06c74db8-4d10-4a41-9a05-776f8dca7189@redhat.com> <429f2873-8532-4cc8-b0e1-1c3de9f224d9@arm.com> <7a0bbe69-1e3d-4263-b206-da007791a5c4@redhat.com> <2450e4f8-236f-49ce-8bd3-b30a6d8c5e57@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: n6qms19th7qzg84p6r3rcud7e76ms9ei X-Rspamd-Queue-Id: D69191A0012 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720023548-106871 X-HE-Meta: U2FsdGVkX1+jM8m83Erge9Dk7McFEbs79deK2+wPOCYhtBqm1MFQu0DAiOLokt0vg1SQI28ogsdgtsLlC4qYg9uoY/4oQqBf5Ryj7z8+XyTfKTOgX1RlizIY6R9q/zCqMUVaLRvvSgN6SUIE7Pro87OUCbGJmAE3o6URGZ4TRLdFnD2EoToNRDXgNiEfqsjncGiO+nRS5XL1fIX2CYXqLNCEbRp1OCKULcx31QyFA6wjhMEgqzHCGU0ogSXDU6aQalsEMAaq9NsfUsQWo3Ncy52JVXACTHhe6Zzd0pP/nVV+XZ5gNIHG17an4qzrt69DYLk3uy9PnW9rSXWEwM5P4PwV7UXGbojs3uOvTo1SLjEhG6D4iaewjznymRJgAwi3rqXnXAL+8x7GULdqgK/WBXCTXyk2lNEbpwG3eGs2PF7NpKgrIx70P2KIJdh24XVT8HNai3mm34kqKYcM/Kre7bUQdcoUWhY0a/43XFzQwuY62nhGUgg1NveOBFaDNb5PdDaI3CHBvtAzw1dKGBaMhyHnk8NtN5lpDICgUdhFog5C9PUScM4bnVRDibnrMwPsKYDqNCiMKeQbaz74p7NkfaaYdlYdAAynyBUUsyfqkvY+08jEdg4SqLbZbtMi7ZH0guv4Q2XY28bmNJcVEcOx4Ff/jgE0hk/yOLqohkcMj+yhw6AYbnGuP8aA5k+7yh2mOjYgTmPtT2XdoVVP7z5DKMvRNCZduwqvD/KAQV4znHkALnchhJTPbS7IVgOzs232eKnld2UdZacRtpkNrFNRAmZg0oPAPFitYmx0ZdAW5zemXCWnQqooKUBBDA6UoJ/q3iCinAbonMqeR8UhDl/u5rFt9CbiL6y3NhiYGDpwFe/9eS//oNc99FYA18bGo/E8QL7Yk8Z0RnfVjFLVFj1cOfwnDX/pEeGKdhgwWU5om5iEvXigj9ujvnObN0AWKYkt5PMJhW/0pQTQrVePPSW EA3/ivAQ FO3s8hjpQg60+NhnIlXW1J0ZdQS6cCYC25q+vL18Hgd7obZqE192XS63ngFd5IoznupOErm4BYua4jcq3HNF9Z/RkOcnc0y95r5c0tqJO6lpAaUQ4q5n8tI8QxFo2+4YBF5TyLptaOvKI1cgJO1i7rdLEFXFWuZQ3Hp30htCq2aN+ai33C6gDL4qPyyB3fJPLNjtIfxcskIv/6torpNrV1q7Isxe3nV/sg6RMFphWS41D7uc6DuRpBYtUUrjuxziYou+rlX+Hd6EuWH2QsUrf8L/IT7kuKrtBzw1mYHSD2VjhaMpNeBHw4RPdI6j1wVRVx2+YCUVfA17iD42yTbSgRde8+dkKy3eewQZqunmZg/WUMGhGIjhYXnYe+CymEiohC3eRvquUMbnWWS2/ek79SxCcMPYfRiMOTeGjpzfhl27LOn2rNPib3VR5rB/s4IxB/aojj/cKHFmORAiBgn2f+olgCqzkE1EwPwVkBmjCsJXUHH7X4/ASUZFDdWw18+KxabmP76b1JvHOHqNXbKSvnZYkSLkxiea7eayH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.24 18:08, Yang Shi wrote: > On Tue, Jul 2, 2024 at 1:24 AM Ryan Roberts wrote: >> >> On 01/07/2024 19:20, Yang Shi wrote: >>> On Mon, Jul 1, 2024 at 3:23 AM David Hildenbrand wrote: >>>> >>>> On 01.07.24 12:16, Ryan Roberts wrote: >>>>> On 01/07/2024 10:17, David Hildenbrand wrote: >>>>>> On 01.07.24 11:14, Ryan Roberts wrote: >>>>>>> On 01/07/2024 09:57, David Hildenbrand wrote: >>>>>>>> On 01.07.24 10:50, Ryan Roberts wrote: >>>>>>>>> On 01/07/2024 09:48, David Hildenbrand wrote: >>>>>>>>>> On 01.07.24 10:40, Ryan Roberts wrote: >>>>>>>>>>> On 01/07/2024 09:33, Baolin Wang wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 2024/7/1 15:55, Ryan Roberts wrote: >>>>>>>>>>>>> On 28/06/2024 11:49, Bang Li wrote: >>>>>>>>>>>>>> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >>>>>>>>>>>>>> anonymous shmem"), we can configure different policies through >>>>>>>>>>>>>> the multi-size THP sysfs interface for anonymous shmem. But >>>>>>>>>>>>>> currently "THPeligible" indicates only whether the mapping is >>>>>>>>>>>>>> eligible for allocating THP-pages as well as the THP is PMD >>>>>>>>>>>>>> mappable or not for anonymous shmem, we need to support semantics >>>>>>>>>>>>>> for mTHP with anonymous shmem similar to those for mTHP with >>>>>>>>>>>>>> anonymous memory. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Signed-off-by: Bang Li >>>>>>>>>>>>>> --- >>>>>>>>>>>>>> fs/proc/task_mmu.c | 10 +++++++--- >>>>>>>>>>>>>> include/linux/huge_mm.h | 11 +++++++++++ >>>>>>>>>>>>>> mm/shmem.c | 9 +-------- >>>>>>>>>>>>>> 3 files changed, 19 insertions(+), 11 deletions(-) >>>>>>>>>>>>>> >>>>>>>>>>>>>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >>>>>>>>>>>>>> index 93fb2c61b154..09b5db356886 100644 >>>>>>>>>>>>>> --- a/fs/proc/task_mmu.c >>>>>>>>>>>>>> +++ b/fs/proc/task_mmu.c >>>>>>>>>>>>>> @@ -870,6 +870,7 @@ static int show_smap(struct seq_file *m, void *v) >>>>>>>>>>>>>> { >>>>>>>>>>>>>> struct vm_area_struct *vma = v; >>>>>>>>>>>>>> struct mem_size_stats mss = {}; >>>>>>>>>>>>>> + bool thp_eligible; >>>>>>>>>>>>>> smap_gather_stats(vma, &mss, 0); >>>>>>>>>>>>>> @@ -882,9 +883,12 @@ static int show_smap(struct seq_file *m, void >>>>>>>>>>>>>> *v) >>>>>>>>>>>>>> __show_smap(m, &mss, false); >>>>>>>>>>>>>> - seq_printf(m, "THPeligible: %8u\n", >>>>>>>>>>>>>> - !!thp_vma_allowable_orders(vma, vma->vm_flags, >>>>>>>>>>>>>> - TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL)); >>>>>>>>>>>>>> + thp_eligible = !!thp_vma_allowable_orders(vma, vma->vm_flags, >>>>>>>>>>>>>> + TVA_SMAPS | TVA_ENFORCE_SYSFS, THP_ORDERS_ALL); >>>>>>>>>>>>>> + if (vma_is_anon_shmem(vma)) >>>>>>>>>>>>>> + thp_eligible = >>>>>>>>>>>>>> !!shmem_allowable_huge_orders(file_inode(vma->vm_file), >>>>>>>>>>>>>> + vma, vma->vm_pgoff, thp_eligible); >>>>>>>>>>>>> >>>>>>>>>>>>> Afraid I haven't been following the shmem mTHP support work as much as I >>>>>>>>>>>>> would >>>>>>>>>>>>> have liked, but is there a reason why we need a separate function for >>>>>>>>>>>>> shmem? >>>>>>>>>>>> >>>>>>>>>>>> Since shmem_allowable_huge_orders() only uses shmem specific logic to >>>>>>>>>>>> determine >>>>>>>>>>>> if huge orders are allowable, there is no need to complicate the >>>>>>>>>>>> thp_vma_allowable_orders() function by adding more shmem related logic, >>>>>>>>>>>> making >>>>>>>>>>>> it more bloated. In my view, providing a dedicated helper >>>>>>>>>>>> shmem_allowable_huge_orders(), specifically for shmem, simplifies the logic. >>>>>>>>>>> >>>>>>>>>>> My point was really that a single interface (thp_vma_allowable_orders) >>>>>>>>>>> should be >>>>>>>>>>> used to get this information. I have no strong opinon on how the >>>>>>>>>>> implementation >>>>>>>>>>> of that interface looks. What you suggest below seems perfectly reasonable >>>>>>>>>>> to me. >>>>>>>>>> >>>>>>>>>> Right. thp_vma_allowable_orders() might require some care as discussed in >>>>>>>>>> other >>>>>>>>>> context (cleanly separate dax and shmem handling/orders). But that would be >>>>>>>>>> follow-up cleanups. >>>>>>>>> >>>>>>>>> Are you planning to do that, or do you want me to send a patch? >>>>>>>> >>>>>>>> I'm planning on looking into some details, especially the interaction with large >>>>>>>> folios in the pagecache. I'll let you know once I have a better idea what >>>>>>>> actually should be done :) >>>>>>> >>>>>>> OK great - I'll scrub it from my todo list... really getting things done today :) >>>>>> >>>>>> Resolved the khugepaged thiny already? :P >>>>>> >>>>>> [khugepaged not active when only enabling the sub-size via the 2M folder IIRC] >>>>> >>>>> Hmm... baby brain? >>>> >>>> :) >>>> >>>> I think I only mentioned it in a private mail at some point. >>>> >>>>> >>>>> Sorry about that. I've been a bit useless lately. For some reason it wasn't on >>>>> my list, but its there now. Will prioritise it, because I agree it's not good. >>>> >>>> >>>> IIRC, if you do >>>> >>>> echo never > /sys/kernel/mm/transparent_hugepage/enabled >>>> echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled >>>> >>>> khugepaged will not get activated. >>> >>> khugepaged is controlled by the top level knob. >> >> What do you mean by "top level knob"? I assume >> /sys/kernel/mm/transparent_hugepage/enabled ? > > Yes. > >> >> If so, that's not really a thing in its own right; its just the legacy PMD-size >> THP control, and we only take any notice of it if a per-size control is set to >> "inherit". So if we have: >> >> # echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled >> >> Then by design, /sys/kernel/mm/transparent_hugepage/enabled should be ignored. >> >>> But the above setting >>> sounds confusing, can we disable the top level knob, but enable it on >>> a per-order basis? TBH, it sounds weird and doesn't make too much >>> sense to me. >> >> Well that's the design and that's how its documented. It's done this way for >> back-compat. All controls are now per-size. But at boot, we default all per-size >> controls to "never" except for the PMD-sized control, which is defaulted to >> "inherit". That way, an unenlightened user-space can still control PMD-sized THP >> via the legacy (top-level) control. But enlightened apps can directly control >> per-size. > > OK, good to know. > >> >> I'm not sure how your way would work, because you would have 2 controls >> competing to do the same thing? > > I don't see how they compete if they are 2-level knobs. And I failed > to see how it achieved back-compat. For example, memcached reads > /sys/kernel/mm/transparent_hugepage/enabled to determine whether it > should manage memory in huge page (2M) granularity. If the setting is > set to : > > # echo never > /sys/kernel/mm/transparent_hugepage/enabled > # echo always > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled > > memcached will manage memory in 4K granularity, but 2M THP is actually > enabled unless memcached checks the per-order knobs. And you can still do it the old way and keep it all working with existing software (compat mode as default). It's just another option and some software might need updates to benefit from it (just like if you would enable other folio sizes). You can happily do echo always > /sys/kernel/mm/transparent_hugepage/enabled echo inherit > /sys/kernel/mm/transparent_hugepage/hugepages-2048kB/enabled It's an admin choice. -- Cheers, David / dhildenb