From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF37C43331 for ; Tue, 12 Nov 2019 22:21:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C390B21A49 for ; Tue, 12 Nov 2019 22:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="n3+rgoO7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C390B21A49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 614D66B0005; Tue, 12 Nov 2019 17:21:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59E346B0006; Tue, 12 Nov 2019 17:21:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48CFB6B0007; Tue, 12 Nov 2019 17:21:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 3178A6B0005 for ; Tue, 12 Nov 2019 17:21:25 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id E65804435 for ; Tue, 12 Nov 2019 22:21:24 +0000 (UTC) X-FDA: 76149047688.27.jail83_295ddd4e79347 X-HE-Tag: jail83_295ddd4e79347 X-Filterd-Recvd-Size: 3996 Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Nov 2019 22:21:24 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 12 Nov 2019 14:21:22 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 12 Nov 2019 14:21:22 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 12 Nov 2019 14:21:22 -0800 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 12 Nov 2019 22:21:19 +0000 Subject: Re: [PATCH v4 1/2] mm/hmm: make full use of walk_page_range() To: Christoph Hellwig CC: Jerome Glisse , John Hubbard , Jason Gunthorpe , Shuah Khan , , , , References: <20191104222141.5173-1-rcampbell@nvidia.com> <20191104222141.5173-2-rcampbell@nvidia.com> <20191112151856.GB12550@lst.de> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <3e2da09f-a305-14b7-c116-77e4d1b9e3f2@nvidia.com> Date: Tue, 12 Nov 2019 14:21:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191112151856.GB12550@lst.de> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1573597282; bh=Mjsgzq4tTY1ttPXWj4o1nKG2G54sIpqkFXsKMyN1ai4=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=n3+rgoO7Cosk1b8j0LFmjpqfy8vh/1vgXoyo1ZFsHWrDwoNjbxshEcMMFtJooukY+ T7fDLY+vAopGHZ/4qpGFIhxkA194rJAuMM41B4/euZtC0I/pznU+Ne28KxNiQIcFK3 Faf6R0IaXpEGuTlifVRQBbuUAKsUmrmUDs7OSQOnPR1KyJI5m+wBQBetYH6lUuXlDa nC68T3zwoJ2tzJq6kUVOW/4U2KMqyYcHufw9VRZOIX60Um0xspk9k3555KmBo+KGar speu/qs92JpbwFBiJYqP5q+w7GIbTcxVibLgBIOdtJsy1GoVW6I9WqRRBVh/dmnQlV bzOKy1bGxsOSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/12/19 7:18 AM, Christoph Hellwig wrote: > Looks good, > > Reviewed-by: Christoph Hellwig > > Although we could clean this up a tidbit more by removing the start > variable: > > diff --git a/mm/hmm.c b/mm/hmm.c > index d4984a08ed9b..b5b1ed646c2f 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -667,10 +667,9 @@ static const struct mm_walk_ops hmm_walk_ops = { > */ > long hmm_range_fault(struct hmm_range *range, unsigned int flags) > { > - unsigned long start = range->start; > struct hmm_vma_walk hmm_vma_walk = { > .range = range, > - .last = start, > + .last = range->start, > .flags = flags, > }; > struct mm_struct *mm = range->notifier->mm; > @@ -682,9 +681,8 @@ long hmm_range_fault(struct hmm_range *range, unsigned int flags) > /* If range is no longer valid force retry. */ > if (mmu_range_check_retry(range->notifier, range->notifier_seq)) > return -EBUSY; > - ret = walk_page_range(mm, start, range->end, &hmm_walk_ops, > - &hmm_vma_walk); > - start = hmm_vma_walk.last; > + ret = walk_page_range(mm, hmm_vma_walk.last, range->end, > + &hmm_walk_ops, &hmm_vma_walk); > } while (ret == -EBUSY); > > if (ret) > Thanks for the review. I'll add this to patch 1 since I need to send a v5 for patch 2.