From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A86C02198 for ; Sat, 15 Feb 2025 01:27:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 022FD280003; Fri, 14 Feb 2025 20:27:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EEE2F280001; Fri, 14 Feb 2025 20:27:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D67A1280003; Fri, 14 Feb 2025 20:27:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B73B6280001 for ; Fri, 14 Feb 2025 20:27:36 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 743B2160EA2 for ; Sat, 15 Feb 2025 01:27:36 +0000 (UTC) X-FDA: 83120441712.27.5D86B29 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 110D2A0013 for ; Sat, 15 Feb 2025 01:27:32 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739582854; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNG28oCspa1cV+YggQqusoK0C7y6q9eELqVpgckjxXw=; b=doaH6YrSkVaYe+vFB+QP24O1OyqvQcd+WyYGU9K0sRJ6fFqOG9RArBlYUZxblHRwoIQxCt 5FxtPeKlTN0MuGMuhx0NobAGQp0NF8GAyxnCmn/KUWzGb/pR3uUjeMREhbnU5a3IuGg0qf gXn4lGWZnUJvNrs3JEoa8labfE3bdZA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739582854; a=rsa-sha256; cv=none; b=FduUJDw1OR3v0OWNy5W+BQNnY9ETrCxvHxnGRvABI94zBS9tGqUApIO1CYp3JeCToyXDDK v/e5G4ARWpHLFONJwi6UzfpW9pLnKbADKx6xfy3BCwMIgqAax+A3spA2LuPv4+eEfAWzVf /INqd+6JjmfE7+oyu5ODo84eqHpOaQ8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tj6wL-0000000055H-2ugD; Fri, 14 Feb 2025 20:25:53 -0500 Message-ID: <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes From: Rik van Riel To: Dave Hansen , Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Fri, 14 Feb 2025 20:25:51 -0500 In-Reply-To: References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 110D2A0013 X-Stat-Signature: 43cdpt4fakdoab913cs895q8krmnmm3c X-Rspamd-Server: rspam03 X-HE-Tag: 1739582852-321136 X-HE-Meta: U2FsdGVkX1/zGxIwCQUZzkTHdy1Qi2zPnIo3x3+2UBOmMQ/LCaqWOSi22yn6FbJB9SBGkJSHN25CO1/Qq51tjmI6UI53xaM9feLMj6tMu7isbAOuNYicrQnhXgghdCkzvLRHznQdu7sozB5U8qFaTHKullPwtdPWSP0qAOcmiOLxNjzHn4PXuGcbKti/XaCfysfja4renwwjgPx1GeX4IT8o8M5bqS7Xi3VWqr2FFjv4xMvpKN9NRp1U/NhdrG/9+JBPFfQRCubdUUHwP6thrXEUetPTLe8uY3ygD0b6eXTRBYxSR6HQrmQEoMi4J1JQTlbj3im7OhWIxZfwGB/QTB4UG4GZ69n0YUM7sECjqAUD7HtmBRQbFwtZVAHGPNV9xjHJxVv9r2aRTjSoNbQkcy48JZDTppNIM8diAhTC3SYBif7WFnXzoILzzjBVw2zDENmQD304+TQNLu17EjogJmP+GYfkxM1x4E81Ypm6wtWYz72FafPBixf7Mo8AjaG44MGcC8CcmnLX2PvlSMeJPSwD7DWu8nhkS/YRPrSRt0C0R3d06asmABki4h5HM26Z22/B0GaRmwQRv/how1rf185I0cqcCSeIK2TgX88qLgPZ85Z9geMCZBYrbCtCaBYvyfjU/m7rq3O3jJRc6H2ZTfEDDht7EFgNyyupi45f9hjCh7blmsNxha0WYkKyvGYJWWRHEOLXRMCswND8jnjuIyF3p0HLNRYFzIRtUsHXb4vt1gUR0Uf4nK+yqHCjnyh0b+ctYQ9vpqL3W9Vg1w4uVsdKf3CGUuXqfO9dP0rLxIYZflRx8ZdMZODbggDgIV4znnZASdiY/atGkzF+4ZwBTCn7oMuZ7KRGG1Ka+8Q/VVioF4iicF8LYOXPmsi7ecm+58pOduOKRIHnuThNC1sQunwhmEkW0AfT7sl00FIpJ75oV04xxowTBi74R8Y8os6fGC4bsMrbcDmbshqaYdb u9RjkZha eFn/37+zIwbGGtCu3RxoAnpoxzvrVfjEPG7BIU+qdSTyau3oFsUHieyidWnzrLpdvupImVFkakY8qMjP2aw/c4+A4YM2/KVRHA27tE5EzE2K9bsajjR7gur1WgfQYxHDXzQIrshux+omLH+iOPNz9q86eBLK46HEtcrzdj0P6798/PaJs1XOShxx/NPwO2CShNdaLrJch5HXakJeztoGOAm5U6CX6IzdWrk7+A7luBMI0gU4bBjp9ej8i0hUCMv30PuBh6hEix+ZKFtiZVNgFN81RJvD+oQu1lqCh4OIJUYXZE8QtFX8F1RGY0Lfy4QNJzeJiGZ4wJ4NTLTT0tK0jsiCo3e72P30LYB77X1WA3Pm9lDRaa2IbQc6X3gx5XGe18j0f/et4tC6tLCQnl9LCBAFVEX3SXN7RM4wxP1PaI0/o2tY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-14 at 11:55 -0800, Dave Hansen wrote: >=20 > Fair enough. If we don't have a better name, we can at least do: >=20 > if (new_bad_name()) { > new_thing(); > } else { > old_thing(); > } >=20 > My real heartburn is with: >=20 > if (new_bad_name()) { > new_thing(); > } else if (need_thing_1()) { > old_thing1(); > } else { > old_thing2(); > } >=20 > Where new and old are logically squished together. >=20 Do we want to group this code by history, or by function? I would argue that new_thing() and old_thing1() are closer to each other functionally (they both do remote TLB invalidation) than they are to=C2=A0 old_thing2(), which does local-only invalidation. I can organize the code however people want, but I would like a second opinion on this idea :) --=20 All Rights Reversed.