From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90713C369A1 for ; Wed, 9 Apr 2025 14:11:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D5DB6B01AB; Wed, 9 Apr 2025 10:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 75C676B01AE; Wed, 9 Apr 2025 10:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FB7E6B01B1; Wed, 9 Apr 2025 10:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BFDC6B01AB for ; Wed, 9 Apr 2025 10:11:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 572AEAD9D7 for ; Wed, 9 Apr 2025 14:11:43 +0000 (UTC) X-FDA: 83314693686.03.A8B1C1E Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 544AF40014 for ; Wed, 9 Apr 2025 14:11:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qhr+AUTH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744207901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79dRAhMX6hAzgdIihnfQk7TyjpU16Gt/P7A1hHpHnDM=; b=7K8pxd8mUCKEl21bhJHj5wQiStfbA/SXWRUAhcWPo4HR9ZfmLpTDZdQjt6DY4rrJt4QX1V bziaumeMSwGV7K3k9tb0HKPAv5fxfpqa96eQhoRFN82s3Lqt76wOAHLKEn3AcgrOCFRj00 w9zcUJ0Gs5J9Or4C8ypygSgOEMJg9zw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qhr+AUTH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of ryabinin.a.a@gmail.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=ryabinin.a.a@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744207901; a=rsa-sha256; cv=none; b=EL1BQHImbtyNJx7UQD3NIvbyNROJ5mJ7JfE2Si7XJbvhLzWLRtb2WI93rbGx/3NS+a++Sp eLlWgGPq1bw+VE94ZvSuEDWHtlehnMk29H74BkmN9w1jskIoU0l8yYfYHupQlA1MBX2FWG om3jTiLNt81ddt9YkYAPkx0zUkpdUaE= Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39ab85402c9so759253f8f.2 for ; Wed, 09 Apr 2025 07:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744207900; x=1744812700; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=79dRAhMX6hAzgdIihnfQk7TyjpU16Gt/P7A1hHpHnDM=; b=Qhr+AUTHgK1mf3MDBKpf1GDcDsh9wxpEWB5HYK0v3SMEIBKbuQ0fjPWDyH9aajwYeW hl1u70rABIM1Bmm1AL2jovB1/qKqgnKVOXaxS/1ILByDFvs0CURcFmOT8//XVOaGFjAJ SoQYDrw2OPL8CtlGYNt+wQf0Osz78i9ER5eoYIZzO1fdV8VY8P+muTmuR4A8y4DiFDJP /gjLhIvv5RMN0nhDoPAGJ3OMW7k+vgcH0aKIPjW0cKWvnSRwDTPrZTyIp7sEYUQfW+E5 O5eG/Fpu0r6QFv43fTedz/bCWMLLT0o0vyG9g092vxWjk6oQxe+m4EqbRIKTAMjWgOrt qzrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744207900; x=1744812700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=79dRAhMX6hAzgdIihnfQk7TyjpU16Gt/P7A1hHpHnDM=; b=Kv6isXGFwK/XeFv5eb7rBLKxAIGv8DAshLxKI796rYOzBclaXeYihj2+x4NCYvv3Ri 7Irhw3LKBXrwbUyRKtrvVrOtD6F9FWsJfMThFHv+kZPhwOFK+VJx3w1SCYRPGQ2ick4b 05Nf9Jzt6+c6djI5HSX/d1Q22DVsos0uCuib0Y6rJJkS5Qt1WLpEEXJrqFgl9x2ezDoh wIOR0MPlEUyjCMPb4j9klVNYl6iBlmPnT7/uBNTbt5+rEfrkz2w+UdwRdkMB5b4Gtc0T Z5VWQ8dXAMn8QCcIrlorSF5czGhkfnOVEjothanF+mIuiLF+sXY1n+Sdmyen1EoS2mYz vGEg== X-Forwarded-Encrypted: i=1; AJvYcCUmK4udz0e6BCwwkRIPOZVh8hJH6MyFzTBpcq62R1PlhpHyDflz6DK9TVq9FAw+34awcjGreTDxvQ==@kvack.org X-Gm-Message-State: AOJu0YyIWyp+ojbCNHCPPjay+qz61NxGcJlBG9S3hiR8j1jc5LDmnCtM cADOT8JPTO/CJy3EcexpJXY7hViPBDTMqnpR5jukwYOJsGEmmFoz X-Gm-Gg: ASbGncu8o2sRt0IWWrh1x+menM0r7jpOGwoHe7WdXjOUqGbl5vZlNhcfk204O/Wo67w 69AeHprgHDIM4400ZON1Z4YK1vILjj9GUpcd9w0MW+HF0XAl6dkZ8Y9pXPxWVxj8ldOlBCUxtEl rYu82nQwIBMBojSZyRWPYpXsvxH8Lsf7JSQZLOL6WPpD7+WuA4idtDa9Wv05vQlcVgDKyHX98Ps Cf3BVqsxHYUeJu3VhYz24v9papxX9uL00+rr16N1JpkG+QCSwC3HMaYHPA0A8jirGyNPejIj8Gu tS4EFfGsljdhYeMvzUmVWM5bWCNHM/keNifoCvDaypiWB9w2TQ9VKKOIxhN3FheZTDFEig== X-Google-Smtp-Source: AGHT+IHSANHfnsI22VvG7U6Add3MtuqdkHlNUqXmc+ZOIvDB4qPCFfsNQQmWuYIJe4cIBvlXQ9bdkg== X-Received: by 2002:a05:6000:2901:b0:391:2acc:aadf with SMTP id ffacd0b85a97d-39d87ab626emr1029141f8f.6.1744207899192; Wed, 09 Apr 2025 07:11:39 -0700 (PDT) Received: from [172.27.52.232] (auburn-lo423.yndx.net. [93.158.190.104]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f235a5d31sm17305755e9.35.2025.04.09.07.11.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 07:11:38 -0700 (PDT) Message-ID: <3e245617-81a5-4ea3-843f-b86261cf8599@gmail.com> Date: Wed, 9 Apr 2025 16:10:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] kasan: Avoid sleepable page allocation from atomic context To: Alexander Gordeev , Andrew Morton Cc: Hugh Dickins , Nicholas Piggin , Guenter Roeck , Juergen Gross , Jeremy Fitzhardinge , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, stable@vger.kernel.org References: <2d9f4ac4528701b59d511a379a60107fa608ad30.1744128123.git.agordeev@linux.ibm.com> Content-Language: en-US From: Andrey Ryabinin In-Reply-To: <2d9f4ac4528701b59d511a379a60107fa608ad30.1744128123.git.agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: r1n34ib8nc1nkizynhpmd8yf5ufxakrw X-Rspam-User: X-Rspamd-Queue-Id: 544AF40014 X-HE-Tag: 1744207901-601465 X-HE-Meta: U2FsdGVkX18ctLZD56FDhcOHJ2PlWYqEX4T1jAhCvlqf2I6EgHUC4Aj9foPzg6BVBc5cocROt5NlfpTIzBMTCzoBOO3yaNgbKu5UGXdOQzIMK7Pcujyt1Ou/A5+AYSTGhlKs0dE7/EIwpCePeCIzijUqlLSI6gGhG+NtS0hewycVPSNEF4XNPBCHfq3pXgpYltSns6phEXwMNBIwSTpWApdzxQ8YSD3Z/55j/QTMHGDwW9Bv7ig41HSbshW8/YBAlbJutQPvRxdRzfk6tj3IcxhwC7472r8iFg2Ll+5yGPn88z5SwGMsZHmN27XXoSCf+1bKbmhQYkht0f7IXPf2qEIaBgwQeTjdJJB4MwwozUJjcSR4eRb64JycvwVTIAjpQ5eEZ4ALbPVxRlJKmPjYSVHH3eIAb+9iNxY+jRoMbT15dbU7JfKTtQwCHX96u+G3x9Uirmq0lM27XS8IpVIVWPz63lwoxAbCzeL+OIT+//db9YD1T6QYEQRySyyRqSCCrutYTpWTV7xvI36VDLtbORfFOB5ftFH5mv+ySNkM6bYIoeDIz6LARpXBGaqhjl5sywiXLbPq5t6VktdrfCtFBrSOlfNfB7iwNn0wRP3HxpOSsavp1ZQ6++ibAwe0RCw3VMAkQmfr5B7bkqt3dlTLWbZOmTV7E/5NcSGshkKDq/ykYMg/yJeM9t/8ReT2CTT1zZ6lqO+C/i0xUzbGkpTBYUez6cB991lGpIwsG6iw82CwFss/HfGaSOATiuO9Rc5o+zvrboJBRN/otCMltV/6MLBivgHIl15naP/D7xK7Zh2LiLJVzviW0+tQHgwHMEGiHByGS1ub8H/9xZQ8QmskbysIbMlqxCDYJhQjyNWJumqLvcGDfyUwTmyhtBYzoS+VwlvfBYSA8yQ0au3DWPTyc7JI58CuQ/reRyzlXFX6LrD6HbUOZ3g+IGF6eYyhvzICU1cYAMVH1BlmKyfdk1C VIwMJ2Xq VPjXqYl8j0ooiinx1YyhvFvsEvX2KsCNiD6kKBl1SHVeUA2DTufo0mM6au2XWiS0S+/fmiYfDCc2V6Kzc+aWEMtuWomi5f1kty5Zu9orKvTAVt4om4N+hNiKy2djs//l6b2cs5MkGU755bjwbatv0tHw8CUQ06A1RECBzyE81FxHuuQwKsPckSBW7G1MRO13AGnIJ0BBHZzpch4MMN5ix/q+zq0i2iNtkbL4dnTYOnlUMrvtdXQxmc8ACbWi3PaNkcPl5otNMIvIS0bgQfDFZ/NDwBkHHJpnOjOoCzSfWthe5Q91TRoyKa1saBIkeI9+Nq4qi8tZ2srvlj+VnrPEIHCk84dObXm6C4qwVLFFeFTHbkrcMagCaVq6ESSUvx7t/8ZIak8047qWqwG+SpwAhBFUQ7tNxyKa8JuIdvdHOz4nlw8nsAfM67Hd8Sq32/a9ZvF/j9myWBk5xLX3OH3hjeLgg6fTzBh5PgHsXwPWXZUdnO7szzUeg1ToVZ5ZHDBNkepeHS2J7Gjt5uViex8VL2GeiH86hqtRGy1MUfF4YIK8VmMOwvTJE3KnLkpn8zlW2wjjE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/8/25 6:07 PM, Alexander Gordeev wrote: > apply_to_page_range() enters lazy MMU mode and then invokes > kasan_populate_vmalloc_pte() callback on each page table walk > iteration. The lazy MMU mode may only be entered only under > protection of the page table lock. However, the callback can > go into sleep when trying to allocate a single page. > > Change __get_free_page() allocation mode from GFP_KERNEL to > GFP_ATOMIC to avoid scheduling out while in atomic context. > > Cc: stable@vger.kernel.org > Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory") > Signed-off-by: Alexander Gordeev > --- > mm/kasan/shadow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index 88d1c9dcb507..edfa77959474 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -301,7 +301,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, unsigned long addr, > if (likely(!pte_none(ptep_get(ptep)))) > return 0; > > - page = __get_free_page(GFP_KERNEL); > + page = __get_free_page(GFP_ATOMIC); > if (!page) > return -ENOMEM; > I think a better way to fix this would be moving out allocation from atomic context. Allocate page prior to apply_to_page_range() call and pass it down to kasan_populate_vmalloc_pte(). Whenever kasan_populate_vmalloc_pte() will require additional page we could bail out with -EAGAIN, and allocate another one.