From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12957C6FD1F for ; Wed, 3 Apr 2024 01:23:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 124946B008A; Tue, 2 Apr 2024 21:23:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1082C6B0092; Tue, 2 Apr 2024 21:23:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F04996B0092; Tue, 2 Apr 2024 21:23:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D84656B0089 for ; Tue, 2 Apr 2024 21:23:31 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A768640AF3 for ; Wed, 3 Apr 2024 01:23:31 +0000 (UTC) X-FDA: 81966473022.03.9201B6B Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf24.hostedemail.com (Postfix) with ESMTP id 9B048180017; Wed, 3 Apr 2024 01:23:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712107409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAYFln2RbsZJRk/epULYQpRLKIMNADOziaPvopBS6Lw=; b=R7Hhr0iXcHDjQVahz4nvVU+D0KqjFeBkpjKhM5LoLhI0ZXMA65sX1FLU3Ztf5uCuptMCP6 DM0wNibzEL3MOj6f2cip547oHRsd6vbL6TI9iD6dXVX/kCvqYULV8JS431tChBOdDlU2S5 CEm0Kzl/wcBQmxd5yC6BTJD9303YzAY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf24.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712107409; a=rsa-sha256; cv=none; b=4TUkK0+dPMkps6DeQmVa7C+zwM1KFdv5LFPEY9YI+0FMUvTd4ZgDdcJ8JGebx7Yx4eCp1e kt1W5TBmYnEzEXtFa9KMHc9mk2r5XzUDfD3iA4WpryU1C3k05TNFVh1qHJZ9eujy03almI 0o72nYSCrBr89D2C5BTkAzockUeWqwQ= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4V8Rl94hWcz1R9x5; Wed, 3 Apr 2024 09:20:37 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 5FFAE140257; Wed, 3 Apr 2024 09:23:23 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 3 Apr 2024 09:23:22 +0800 Message-ID: <3e17cb03-eb23-4e13-876a-53a62b6c59bb@huawei.com> Date: Wed, 3 Apr 2024 09:23:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] mm: migrate_device: use more folio in __migrate_device_pages() Content-Language: en-US To: Vishal Moola CC: Andrew Morton , , Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-3-wangkefeng.wang@huawei.com> <9200de40-aee5-4aee-9b78-4b93e3442d5f@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 9B048180017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sp4641qp9zpxw8xh4dewgr3q6webcacg X-HE-Tag: 1712107407-305231 X-HE-Meta: U2FsdGVkX191az6cj4HD7vgMLIJGMdan4uVHqKMbOYSdyOwoNfdVjiRqnkP4JfKDlzKLdocrDkaBXwlfcfnXj2s2ZUimT3dv9TpK0QLTUTdVL61/RCHtdbSD9CNI9t1KysLId76slzK/fCWUoScC9/VQNa/YM/O6NnIXa322lg3SZspGnZ94zGkmfHwFBDnoJAW7EHxqgSK5xaCBuSvOlt+P76zQbjPpVpBr7mZLzpcIiBer8e8yMRanF516jSXwWhUwyygYHCo744CbEvrb+81DJxPbYyL0renXg5Z5J4eCmPYf7yAseNVQtdhqQQhGpEP8VCaIv7lpbzQrequBd7ocuSAP/xcX9S5f6vPMOUCOYhWFPyVx7MCgrlpK8TBDzZrKvfPnix5JyV8ttfztR7ePYLC5JCPlOtxwgmhZOon59JnUYtPYrdGkMEgXdKGxDqmUzdSaaf9cEngN+hOUzITPjfWe4U5QGpISCZd5X7rcnYx+dbm5f5koVooD8NoFxTru80tC6SQZ1JrrTae/HILcFC0rRmyqoXgw5SHRbAxYJTa+zqfW/BZOXdP9ROMDVbWGkBsebkhPyM7hSnG5MMt5W5xdvfwDoxJnrZqI5mfQIowbZ/COT96JANosvFLdZ4zdhelaaRyE9SiP605OCCjYqg3gO6fi9cdvK5mZxiZAzY/zlyACUdk9/TRTC5kNmsvLq7WponsTDll3mT3mbL0hMn6EQhPjRsFLvIbPaYUrWPk1qNwt3yN1TofQ+uY3fXtCDSUHIxytpRlp2/4KlLRq9hX2WVBBuTX9WqHfNS+7EOR2PDb107iPbJKMYWiAC2T8f5b2tlpX3EvZTmuxjmRSdK3xaQyy5dRaBzt2v2S5THCkMsOgAXkNgmbtwoH8N2yB6H+Gix2NIkt8LwoL2nber78vbPq9fiSA+Et6BvwejEiTj6SFcRF3hbsojb6A2g9EvFIsy3y4N1Yi09N NjJ7SC/5 yMTGFHXI1mI0orjmqAvdOCgR5SwlMRAXXWAHAZKD3P6moekM40J2TtHTumHZ4p3UpkAx2zmKzrhIzgOcy4pVhYiRDb2uqr3Bm3dZDnS+4paqxayExJBy7xTfnANLE7PJh5UGr8AKgQFkLUTp0Xa6A3y1GCKxS7VJhRdB/JsFMabWd/xSglf8WAD9pGMBRJh+4xNvy2q7FF4zKtg7m6GxvYfKT4qvVV9We+5vikAXKVAGL9jWgLKyspUeAUCxXSjeNkUZwGSpK1nLd8BmGmndYFg3V3TahJAI+0ASPFD84EhLK8OVpTN85pLbLQ6TfZmC9CVTOVzo8qwVGREix1kBhSoEIi39mHLydCB1SkLkr6G+BhAo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/2 23:54, Vishal Moola wrote: > On Mon, Apr 1, 2024 at 11:21 PM Kefeng Wang wrote: >> >> >> >> On 2024/4/2 2:22, Vishal Moola wrote: >>> On Thu, Mar 21, 2024 at 11:27:38AM +0800, Kefeng Wang wrote: >>>> >>>> if (!newpage) { >>>> @@ -728,14 +729,13 @@ static void __migrate_device_pages(unsigned long *src_pfns, >>>> continue; >>>> } >>>> >>>> - mapping = page_mapping(page); >>>> + newfolio = page_folio(newpage); >>> >>> You could save another compound_head() call by passing the folio through >>> to migrate_vma_insert_page() and make it migrate_vma_insert_folio(), >>> since its already converted to use folios. >> >> Sure, but let's do it later, we could convert more functions in >> migrate_device.c to use folios, thanks for your review, do you > > Makes sense to me. This patch looks fine to me: > Reviewed-by: Vishal Moola (Oracle) > Thanks, >> mind to help to review other patches, hope that the poison recover >> from migrate folio was merged firstly. > > I'll take a look at it, I'm not too familiar with how that code works just > yet. That's great. > >>> >>>> + folio = page_folio(page); >>>> + mapping = folio_mapping(folio); >>>> >>>