From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D7EFC2BD09 for ; Mon, 15 Jul 2024 07:53:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37DB6B008C; Mon, 15 Jul 2024 03:53:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6B76B0092; Mon, 15 Jul 2024 03:53:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFCDD6B0093; Mon, 15 Jul 2024 03:53:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C13176B008C for ; Mon, 15 Jul 2024 03:53:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 734B61614C4 for ; Mon, 15 Jul 2024 07:53:16 +0000 (UTC) X-FDA: 82341221592.24.09A6CC2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id C1195120015 for ; Mon, 15 Jul 2024 07:53:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721029965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HJ1v1knZbjNeava7qWpH/aEvyh36KvIO+XUKBwlm0g0=; b=cJ/BQI0Lu8RB8WxltElVjK3T0LMUli06HV9h8aZlsfroO2RsEzBVz0VFxDBvBbgMrWBlkE BkuTk4wZD4Qnv6QOvkcgFD1gnpjJTbVXz5ki87s+cSw7Ko7hBPjsCPJu9JqS6TKDYmdxgD LYcJ8DDBSNByqBC6Mzpam3n2eCb4RKk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721029965; a=rsa-sha256; cv=none; b=vp55O+EK0qhhialK1cgf1hlQSPM8XAkeVc1nXHNH27jHH1rWVrzX+xyOBynpGpFMVOUBhK Y91Juaz6MEBdzfMQDqv3a4oeXeIYma97zod7B9RaKil2jrzL0fwhzTExy9q2XkDwrc8wB1 egErpH3nRVPk/EpVgCLrVUdjf8TL/QM= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 493ADDA7; Mon, 15 Jul 2024 00:53:39 -0700 (PDT) Received: from [10.162.40.16] (a077893.blr.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA5403F73F; Mon, 15 Jul 2024 00:53:05 -0700 (PDT) Message-ID: <3e13f67a-b9b0-4cb1-9af9-19df06546ca4@arm.com> Date: Mon, 15 Jul 2024 13:23:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/29] mm: use ARCH_PKEY_BITS to define VM_PKEY_BITN To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-4-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-4-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: b34r8kepd3ke7fhbts7dkqm76dpj5rot X-Rspam-User: X-Rspamd-Queue-Id: C1195120015 X-Rspamd-Server: rspam02 X-HE-Tag: 1721029994-605975 X-HE-Meta: U2FsdGVkX19gLNPK9ew7xECA142YVYXlyD5xJkaYCHp8Xs1Bs88Wwa6nPYWNJR4OvAQqZzxva+V2qk7k85QJHTRrP/4pv+oMkVG4eab3ttKL697eCQbuJJ5llGQgo5YRaR0VHfx9/yu6otCTqy+YdlQO3f2AUA3KAi7DquUVhMlCXStVPKHppJ1cOJl16q8VeVUepStNCgt4pmlAwQ1Sw+tL983dR4cizs9/uud86+vjWRxePj2/8DJdyZlOSU4w6PSEklg+g+tZkkWvXK21EVHED8qjc2uDDTOUSxDcwx+j225lMY0tR72auenS92AWazOimd/adpAzK7JIyAF9o9N2y3shvCtSq2sZ12ItwPx4U4/qQs0YT+zje5EKUkSE7Iorlq89z+Ljoj0WfKaje+r+Y5uqC0ED92UUSJiUfkVTsox3atU463C3DTqbxdwFvkqcSvlL+Vz0QpJGRkcMUOUPOU1Yz1l8s+YxiOsH9q/T9eWW7yX6z+jHnDdBcJQsWx4g5l7MUuKL1wh+qpkqfhP5oYtPT5bzQOg9DMIsPnxix9fMnRwlmC28PXXvLafq0Nt+DcqqrJd3xvliL50xfGNvSk2+WVFgZ/ULA6pP/faSCDxU93CBz5gwXu0xSlbJW0QFTo2fLW7RKmWFLioHFMieQXuq5gT1PitrHU1PMSZFXmtuTWr7gsae8BP1NObGqf8mowv4zO3OvHMHs0OGy53NtEM/nmkXnXkjgSIuwW0um5Uke+553hJ3OVg7UPVrJyCSIaLL332k1iChdZ4FdTmLIIMPJVs4u1M+gLL0K8DQNSLwYVtm0A9L9JVr2Ni5xNHsxJH+yWnJnoGNCrzxT/8JHWRBRgNQdRytBcLCAd1I4pE7wPxSAHvDVB6rHoys1Y8XrkHDlRMRvwkHqNcZqfRMV+UDxQStOz5Vmg7GRfIZr0PszNtSLEry4Z/PCluIPot0WPTFz8fe4PG0YGd IMR8SVW9 uEB7FdlLukUjhSdB+ERDbyTe+XwrMNuTvewi3ocggtS86IIXtXDrbdYtMiOw6VJeVJE4i975kZz5aqngoB1164194TXwyrJOUCo/qOrMM1NGEuRGGwpaCn6mFThILd7GQv5NLZP9e3LPHGlfZXvvx/LOb+n08tARc72kBx3ZVi+rhjJ9w0DSenxNssFg1Erll8ij6uWPLViZZT/VdaUIM4JIjLtRTlBLdG3h6Rx1vdxMgQuP9k/bIkvXdG6V7KQs6MMCirz2FTHZcBEG09LPDXbeuT4Emvo+SSvA0Lw6913Q4LmbW6E4cNF0DEUZ5BH+WL17VBKgPeXMUU6STLmUlLE68VqKwgbnlVYPZjMccJ3lIumRMpCSBapq1HNeT6YcRC+XW6qwdLtz2mBhtve8k7WfLpaG9nDRUnpxC0/qj8rNsSYU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > Use the new CONFIG_ARCH_PKEY_BITS to simplify setting these bits > for different architectures. > > Signed-off-by: Joey Gouly > > Cc: Andrew Morton > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > --- > fs/proc/task_mmu.c | 2 ++ > include/linux/mm.h | 16 ++++++++++------ > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 23fbab954c20..0d152f460dcc 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -692,7 +692,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > [ilog2(VM_PKEY_BIT0)] = "", > [ilog2(VM_PKEY_BIT1)] = "", > [ilog2(VM_PKEY_BIT2)] = "", > +#if VM_PKEY_BIT3 > [ilog2(VM_PKEY_BIT3)] = "", > +#endif > #if VM_PKEY_BIT4 > [ilog2(VM_PKEY_BIT4)] = "", > #endif > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b6bdaa18b9e9..5605b938acce 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -329,12 +329,16 @@ extern unsigned int kobjsize(const void *objp); > #endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */ > > #ifdef CONFIG_ARCH_HAS_PKEYS > -# define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_0 > -# define VM_PKEY_BIT0 VM_HIGH_ARCH_0 /* A protection key is a 4-bit value */ > -# define VM_PKEY_BIT1 VM_HIGH_ARCH_1 /* on x86 and 5-bit value on ppc64 */ > -# define VM_PKEY_BIT2 VM_HIGH_ARCH_2 > -# define VM_PKEY_BIT3 VM_HIGH_ARCH_3 > -#ifdef CONFIG_PPC > +# define VM_PKEY_SHIFT VM_HIGH_ARCH_BIT_0 > +# define VM_PKEY_BIT0 VM_HIGH_ARCH_0 > +# define VM_PKEY_BIT1 VM_HIGH_ARCH_1 > +# define VM_PKEY_BIT2 VM_HIGH_ARCH_2 > +#if CONFIG_ARCH_PKEY_BITS > 3 > +# define VM_PKEY_BIT3 VM_HIGH_ARCH_3 > +#else > +# define VM_PKEY_BIT3 0 > +#endif > +#if CONFIG_ARCH_PKEY_BITS > 4 > # define VM_PKEY_BIT4 VM_HIGH_ARCH_4 > #else > # define VM_PKEY_BIT4 0 Agree with Dave that this is not very clean but does the job i.e getting rid of the platform #ifdef which in itself is an improvement. Reviewed-by: Anshuman Khandual