[linux-next:master 7414/8213] mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used

[linux-next:master 7414/8213] mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   17cb8a20bde66a520a2ca7aad1063e1ce7382240
commit: 5898c0939406116f8ab33dc5a50d36f3b5d44863 [7414/8213] mm/ksm: add sysfs knobs for advisor
config: openrisc-randconfig-r016-20230621 (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312151854.4k8dhWf6-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used [-Wunused-function]
     344 | static void set_advisor_defaults(void)
         |             ^~~~~~~~~~~~~~~~~~~~


vim +/set_advisor_defaults +344 mm/ksm.c

   343	
 > 344	static void set_advisor_defaults(void)
   345	{
   346		if (ksm_advisor == KSM_ADVISOR_NONE) {
   347			ksm_thread_pages_to_scan = DEFAULT_PAGES_TO_SCAN;
   348		} else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) {
   349			advisor_ctx = (const struct advisor_ctx){ 0 };
   350			ksm_thread_pages_to_scan = ksm_advisor_min_pages_to_scan;
   351		}
   352	}
   353	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [linux-next:master 7414/8213] mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used

[Andrew Morton]

On Fri, 15 Dec 2023 18:36:51 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   17cb8a20bde66a520a2ca7aad1063e1ce7382240
> commit: 5898c0939406116f8ab33dc5a50d36f3b5d44863 [7414/8213] mm/ksm: add sysfs knobs for advisor
> config: openrisc-randconfig-r016-20230621 (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202312151854.4k8dhWf6-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used [-Wunused-function]
>      344 | static void set_advisor_defaults(void)

Thanks.  It looks like there's a bunch of advisor code and storage
which can go away if CONFIG_SYSFS=n?

Re: [linux-next:master 7414/8213] mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used

[Stefan Roesch]

On Fri, Dec 15, 2023, at 11:10 AM, Andrew Morton wrote:
> On Fri, 15 Dec 2023 18:36:51 +0800 kernel test robot <lkp@intel.com> wrote:
>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   17cb8a20bde66a520a2ca7aad1063e1ce7382240
>> commit: 5898c0939406116f8ab33dc5a50d36f3b5d44863 [7414/8213] mm/ksm: add sysfs knobs for advisor
>> config: openrisc-randconfig-r016-20230621 (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/config)
>> compiler: or1k-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231215/202312151854.4k8dhWf6-lkp@intel.com/reproduce)
>> 
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202312151854.4k8dhWf6-lkp@intel.com/
>> 
>> All warnings (new ones prefixed by >>):
>> 
>> >> mm/ksm.c:344:13: warning: 'set_advisor_defaults' defined but not used [-Wunused-function]
>>      344 | static void set_advisor_defaults(void)
>
> Thanks.  It looks like there's a bunch of advisor code and storage
> which can go away if CONFIG_SYSFS=n?

I'll have a look.