From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E28EB64DD for ; Mon, 7 Aug 2023 08:32:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CEE96B0072; Mon, 7 Aug 2023 04:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 988598D0001; Mon, 7 Aug 2023 04:32:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 846376B0075; Mon, 7 Aug 2023 04:32:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 712006B0072 for ; Mon, 7 Aug 2023 04:32:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2EAF9C0125 for ; Mon, 7 Aug 2023 08:32:09 +0000 (UTC) X-FDA: 81096641178.28.E59785B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id 9F3B04000D for ; Mon, 7 Aug 2023 08:32:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691397127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4t2lYWB2KIG3EfeNpZzNq7dMgbQqQuiR2EJ8GG+gSM=; b=3LwnIIXiZl+kA92y6JPq8Bsfl23x5Q/zUv1vWjX1ct3E3hYaCZ/PJsd9IWh6EWV3hEMnsE RF7FvfU3slZOaqrVfvqhcuy40vkGYTKdpie7TmcXQ4vkMJwE/FfFrCi71QdvheuNQvm0G0 g0saFsyfCQgDTALUpbLKAkPu5KxXTHk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691397127; a=rsa-sha256; cv=none; b=t04YvfNAw9Z7zJLvGp19/5K3S7lD6hxANaWkAxTbWR77ybM/KMIxPHaBgHOMoXEKl9wgF6 8yPnCPsQ5CLI1hzto47re20oKNvwYftRv32LrcFMg5ubRsstv43KRjC4tX3DqRfNiVhN2H v3rrKhEIZNJLTxXPwVOAvzmH1E0Un4s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RK8bj2RVYztRyx; Mon, 7 Aug 2023 16:28:33 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 16:31:59 +0800 Message-ID: <3df967c2-5635-422b-959a-07632a783690@huawei.com> Date: Mon, 7 Aug 2023 16:31:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] mm: remove redundant K() macro definition Content-Language: en-US To: Peng Zhang , CC: , References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-2-zhangpeng362@huawei.com> From: Kefeng Wang In-Reply-To: <20230804012559.2617515-2-zhangpeng362@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 9F3B04000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u7gxd81w65nifmg169zk67h3dqoxh3ar X-HE-Tag: 1691397126-604157 X-HE-Meta: U2FsdGVkX19twQLLIBQ5EXn5iwQGThfOMO339cAHtePluRUW/cSL50JECM8sLM0Le7xQ8TFA79vLMtGhOtTvkdMA3P31hXzRnTDou4ynw64V14RAwivRV/qkJd/2naD6ABg98u3PJqlt9BAX4IXJGDrnpob20g8S0jMwH6Z6GRcHjGXnKdetS2jFq42mgYlfh7ZoHYtWlQi+BKSoGw6PFlsBGe5WTDASwEjznIt4RtJD2wq+XWe02EBpFw7xZ7dtMvkWuk9KyLlmUGQyfjmXBS8zkjI4uhWwjjY9PYuCKXC8uRCOalFD9MCkZEE3A3qxXMSQWiZrsaWPRtmjirt0sBlPZc3UP5U7t3UKHGle0BQrhCBaWOkM7lMOuWRHkeDgmn4nX+NNCdCPdedCLUZdvMDdRWMQZZL3mAG4QVAyib63Yzrvu6w8yP/J/asm7u6f5xsB/lCNOHayn/7dqLFIG+eGpf7xu0hgCJiGhdby1waRA9D8ZLlhPNr8sZ2ZeROuHh2nmTx2MGkVJqs7BL18Gz4Cto7S+MB7e9NeUsP6aCZtFGW+0Qu7VPQpvT6oLrvM7j7CJsjQG/vMfBlIxONOzKPWujSNgWzYTnOXMJTssmV5Ev+zgVuTBajnYRLnf0FIdqDfATsSObUIpZpGWKuHcITp7fewXvQ3sp4rcNw+k+6y6SU46IB9ENDUjx9xYjwdfgFmcEKambftOe4JgYXEhvPDJqWbRVRzHZYex7SNCv9LDsH25ZpnU4FKBKifPlBAwfNzzDr7Sxa4o7ZdEj7vtXkMSk08srgp+ElnQ0nOpRXtHYZeWPUbEaFXTYaIM/SouqUnkwoKRMw4FgKvv8/oQS2swxxVOd7wek1oJmc+tskq/yoERWdLOYKyhBroZ8z0fNsRwv/C/qfEtNUj7t5DNQdtnyAd99cIq899WCiLSF+cBR0luBTHsVMBwDe1oSTMZ1uVz2SRtWkrQcbn72u FNjFcbXH cN35E/P/rIvTt8JQg+raN250SuoOwhDzILyBF36rV3SGMqMu6x8tCo8HoGyTy4p9xoGcB/Its12+akPxkRLug4+0IuFV/ERIabo9hQnbju+M5erHilBZqbzRL2ayk2+7yl4zv4WLkfL4hJW5vOQxwYoagt/JizN/ziHpMUyPjZ2cjA9rj/d5qcbnChOOyl7lpFt9W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/4 9:25, Peng Zhang wrote: > From: ZhangPeng > > Since commit eb8589b4f8c1 ("mm: move mem_init_print_info() to > mm_init.c"), the K() macro definition has been moved to mm/internal.h. > Therefore, the definitions in mm/memcontrol.c, mm/backing-dev.c and > mm/oom_kill.c are redundant. Drop redundant definitions. > > Signed-off-by: ZhangPeng > --- > mm/backing-dev.c | 3 +-- > mm/memcontrol.c | 1 - > mm/oom_kill.c | 2 -- > 3 files changed, 1 insertion(+), 5 deletions(-) > ... > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 612b5597d3af..471061a3a0f5 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -479,8 +479,6 @@ static DECLARE_WAIT_QUEUE_HEAD(oom_victims_wait); > > static bool oom_killer_disabled __read_mostly; > > -#define K(x) ((x) << (PAGE_SHIFT-10)) > - > /* > * task->mm can be NULL if the task is the exited group leader. So to > * determine whether the task is using a particular mm, we examine all the Please drop "#undef K" in oom_kill.c