From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE950CF5394 for ; Wed, 23 Oct 2024 14:30:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53CD56B0088; Wed, 23 Oct 2024 10:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EC766B0089; Wed, 23 Oct 2024 10:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 318626B008A; Wed, 23 Oct 2024 10:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 083646B0088 for ; Wed, 23 Oct 2024 10:30:58 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4EF651A0CBB for ; Wed, 23 Oct 2024 14:30:26 +0000 (UTC) X-FDA: 82705103124.25.1AA98A7 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 0B71612001E for ; Wed, 23 Oct 2024 14:30:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fTlMoYEr; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=G+ohylZn; spf=pass (imf29.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729693652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jgqaFi6yheydC1D0b8x4cEm0PQgrYabCLuhRnspZ5K4=; b=uHteNi02RdfDtB6DGFrxOT04+v34EcpU6LwqaLUKBxQUHR7vBA2ONCtkwo6DFDPxvYdPsu 8hoREjIWgjqG9ADMDQhfN68wfb4aJ88YJaE1cC59yEZRysRmfdFBKR3TsjyG4uXPuWtFcm h3ntG480YjKuOMYZIfNnHCM0hS5Rjvc= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=fTlMoYEr; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=G+ohylZn; spf=pass (imf29.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729693652; a=rsa-sha256; cv=pass; b=Ry590vBvgYJuR3n28MwF0iRQy9gIcrgFcwtic5TZWVIah+tHq7/nLkKCM4CCHOh3PbOqUG SGObsankK+v/b/K+fdiIt1UxbFGeuXHoymkS+EX39pB0F2wyCIEpFA5kBjCimwKn0nrb6h BWpNtz1shEgs3/28sIBzdxZIfCHtOI4= Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49NBQWYH017377; Wed, 23 Oct 2024 14:30:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=jgqaFi6yheydC1D0b8 x4cEm0PQgrYabCLuhRnspZ5K4=; b=fTlMoYErHRJ1crdyDR5JDAE/TK/DM/v9cf eI3SQB2GNPUfLSUxFCvchrHSjHCysM31Yu168Ip/txYSIbK5TbHIf5hswSjc3vLa DSzvezSRWrDV4f2U60i6f8al+ADY8s1oIPrHLwPuUnxONT/pnYUvc3iHj/sn7WjU npvpCiFnuPDlMbg3Z0TWbxJqyzR30zq94s4EW79qe7VSUFhBjY5rgfXbwAmpP8DV JQLZkMLV+0iJ9y8LPgH4ekI2uO9n33/9QiOZDh4K8BbdbrgVzGCeEpWF/L3DYGux E/nriwoioCckev4jm/1zJQL3BD598uR9MUat+M4ExHGX8xYf/T7w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c5458d7u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 14:30:51 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49NEUI6d030872; Wed, 23 Oct 2024 14:30:50 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2046.outbound.protection.outlook.com [104.47.58.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42emh1ktwe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 14:30:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C1c3hEnrRs+B+Q2uaF//BHV+xfC9Yonn5UIOmFR6Nvnv4B+GFQl/OSZu/69Y/RVz28BQcB+BxrWoy5UEeD5t6bW0CvP/vpZnSFtMhdXE69/8qFazkTVXJS08CrwpiK+keyHPddy6LEwooHu5DhaRBk3M/3ESPLzlz2d7Ld34TUYc6jzj5uofUKbzaVYnp2suz1ahJtccI98e2A8r4V5FH91HI6iGHc/y9HsXnndCZqtgUYvPrDD1S6r5TyULqIYf7IJgnta0XuoBOQoapcyXkaSnZaa6N9CLYk/BeCW67h+SLUHcz1b1gCvKDPgzHjIsWCmNCCSdDOeeKoHqO/CbXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jgqaFi6yheydC1D0b8x4cEm0PQgrYabCLuhRnspZ5K4=; b=ceY47v+Dfb5SYPIEp6+bznLSWV7gky0U2IIJcYCoFpk5Sv8Woq1gx+LAL9TzvrmoQfdgryaMkHbzDjNnH8Azv6oDhNp4rw1QYyxq98AWDhFnfXPPux9DKeeTMPAhnMZ8Yt6CKj9a3cawVp1r+CMFrG6JEKtOLflZQiWIkN6QEY2OOB7lY/ftxIGmFU/+Eg9rr8UgK2+JAucGV+xBfaulBsdq3lZZBi27cljh0WHtQ1/xlYqgdRP7L0pF72IU+ja+32lVjTOI4LXd51UfjZrx6A0Ew6fYbIpJb/S3SD3c6GKnqi4NQ+d/JH/z9ohqV8IWzK3sxvEPyiXVyjif/jeexg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgqaFi6yheydC1D0b8x4cEm0PQgrYabCLuhRnspZ5K4=; b=G+ohylZnJa+NnXEG0aui51AKYQXYMVMxUueWm4+kyOFOzmQRGwXvqyPAIOYyJDBoqEhmHXBbOqU6s5An2f082RAdmarR5FCOtqrnkUzk0zc6/ntzHcpMW5uuXXeWvwiZZVH7GWZ+tKxiZSVtYxc2uJQZGa2hRfyG0tDjZvOvo+Q= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CY8PR10MB6636.namprd10.prod.outlook.com (2603:10b6:930:54::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.26; Wed, 23 Oct 2024 14:30:47 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.024; Wed, 23 Oct 2024 14:30:47 +0000 Date: Wed, 23 Oct 2024 10:30:46 -0400 From: "Liam R. Howlett" To: Lorenzo Stoakes Cc: Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu Subject: Re: [PATCH hotfix 6.12 3/8] mm: refactor map_deny_write_exec() Message-ID: <3de53e7fmsql2t7byzoqonyt7e22bztucjcypykvqiystbalw3@2vwnvh7jcfed> Mail-Followup-To: "Liam R. Howlett" , Lorenzo Stoakes , Andrew Morton , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0264.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10f::25) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CY8PR10MB6636:EE_ X-MS-Office365-Filtering-Correlation-Id: 373e83f2-cc74-437b-043a-08dcf36f4950 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t5F6IoMeDxKcs3T2gF6wu1Iqt2yd+KURyX7k+le0/fmv8jv1uMYrg9R2Bm6Q?= =?us-ascii?Q?Mfi6TyckJeqYhKg2+d4qaieW2HLkMYDNFSSAZEIGmi0oEF8hfKLZEAcJ2yuL?= =?us-ascii?Q?D1jH0NSmbeO0Gw2yggSeeWIlmRwpi9KQ6RGGccDXctvXwiS7ct2v5m1qOrSj?= =?us-ascii?Q?nCWTtxDaGthrnXgSjMN4Xxj45Lg/MTUonSvYNNPxuPZIyT/puiBpa5joRRku?= =?us-ascii?Q?6xDu7ibqEzCXEIwmjrzDSIdnBfzOMO7EdQbQGX817JMZEWGzNtd156+uHf2j?= =?us-ascii?Q?tyAhDjsK3njSxZTo0toaULhL8JDrU8Ar1J9SE7nChx5odYJqdJZgFAs6TXhi?= =?us-ascii?Q?iZXeYqTQ12YV30WCc68b65zVI1kvT3UrfpxuGC0shq8agBlJ0E+u1TyMxcC5?= =?us-ascii?Q?LJEt1N1dIeAIoHWySFg/wX0T2jcVlcD3a6fVsqcj6j//nH+BtMhjuW+WnKxz?= =?us-ascii?Q?Bk54kOed65b/wPI/9zfeKeTtaW+HwHPjQcqc7VE1VFBVzeA80niBYr4zBfHv?= =?us-ascii?Q?KkICbtMVXJf4pyYpY/xpdNRLd8e3VeHBrPXh235XV1tnSQoxRz09QK2+3i3I?= =?us-ascii?Q?Z6uYjRFLtkZrj1u1Z7RbSk5CA7PPzrM427Yj4mNGc4S4gut1irNA2jEP+kQz?= =?us-ascii?Q?RZV9HF7SmQydOpJhbY/ZqtPjbBf2qFKPFqmTPYs771qCf+Xkyvk1krtHdMN/?= =?us-ascii?Q?tGz+fiEqhLcDHDBSeIbAca/SL6EHNHArFtqoCWNwe6ZBEtq8OPHJle0MWF2s?= =?us-ascii?Q?+/8YcxRONLtJnLnPrtN7S9M0qr58wvJfprGIMLEB0vzmDg4yiykAaW3OZjpj?= =?us-ascii?Q?BJOtaCfKhgL1p3l+fR48NANRTpwlR2ohhHpG8h3u18e+JaVJdRoPZ7NzJiwn?= =?us-ascii?Q?h/Fwt4T9jQcLnbPC0HGkbH6QZnQcN3Jf4wndGEfQZl2fPyB5ZlLIVGnyWDb7?= =?us-ascii?Q?P9jdPv/M0XI99QXAtiveDzVHbE0jLahYH9rPcKBjxcIRgdlfvOcuCPGVKtG4?= =?us-ascii?Q?17hVwAzDTs+SboS+61fs6To/Q/qJAJj0b5P2HHfBNQQgKprqECDKwXrftCOf?= =?us-ascii?Q?vPxc5PG7Fm3Wp64H0KctfNlqIrjG4fMJKOYbCDawN6DJ0tgNOhgwEkmHORO6?= =?us-ascii?Q?lc2Kzna7ZbmJC654KXz5Zlxjj5o5nLIdBSgew8MCNdgmHqsesbY9zpkVq5Xs?= =?us-ascii?Q?xneemjYc4EcSkBUc9kOaYT9+GIZ1U0AIAQeXqtt9D/yVg6dHQm++OTO82ao6?= =?us-ascii?Q?d9o+j6cwqLKtSwqqiJ/rxVJlXkL//WLPS7HtRjxHctkUGGZTaOG49d1s3f8N?= =?us-ascii?Q?0lx+qt7vK7K2QufoE59rNdrx?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5DqJAxe4XwEp7zguHjQrMCtmRM1HdMGCEG74wa4W96GCuYUor9USaU7uyNQF?= =?us-ascii?Q?ZE1tkJP9ogbdmVIFna4HiJKpvBPKlHZ9qPfsJI6iUaXEMJFy+kxYC8ytVHfV?= =?us-ascii?Q?FP1bIosBr5yZIOB6bUWcbO0uYekwXqKSPnISpIxGXjjpeVjrmbPiKkXHyuBc?= =?us-ascii?Q?EEs9miiyD2N7HUAtZQ33A3okz5LlNSXB7PGSk9zrj1Jf5dcUL/+Y7cN9T81t?= =?us-ascii?Q?yaoFyuTGG8UUEguszHKNLwlBomQ1yrNmwT4v8DTJR2z1D55Y3/U+AbFptA24?= =?us-ascii?Q?zeYZiV6cLeUNtaLI/wlcv87UTaoUyULg8M1n0WNQAyUtD/vUF2Ib92dr9FVH?= =?us-ascii?Q?/G9nRgYGlMHYTnIcQZKYv3zokeQpbRxZRtFpI/vWSNkXIkH7tCeFNXzcabt9?= =?us-ascii?Q?5eGkFOOS6GMTuVrFO2gqEvSQoxk/RHCwOb/L54/iYt3U5LLy94oKZ4hD8P6r?= =?us-ascii?Q?SBnb2nCWUSdyFih6RhacJhOS40HCn2UyBJ9nzgEHzlhj7sq1vMb0sfF3C1uY?= =?us-ascii?Q?OiQYqnx9P+uI/uzNKO1Rz4ItLM6jOuKG3CvHZ29KDW79TO7Fa8UJQ27B1k7o?= =?us-ascii?Q?+BUPU4W9Fde2qK/8WFAVkNcwtl04HYBDclPL8s+f7YmDG7nZpZsYCFlS5XUt?= =?us-ascii?Q?WQcSAa7GcAdi/rJrjD+ao9yCcZaqiEFFBZp75WksCcZcECA7OZJUfqzgYev+?= =?us-ascii?Q?Dx5lYQGJoSDNfJ9KSjk+RZ8g3/a2AYcT5nVgjXYXEcP+lW6Wy9V9QTvm0RzL?= =?us-ascii?Q?CkELvmR7l9iKT7SsNlaRT9F/wEDEJ7ySaciRT7PY3SDWuJD1TcrQGG1YAoHM?= =?us-ascii?Q?oiO0ksvLl1OlTNkkPLHJZCXKfR8X4f6s0g6sNH215xOg3NdSMHyf/9y+LVqN?= =?us-ascii?Q?nAQqH3vP3aTa0+wS6PjCCNf8ektXx+5TrfBRTFu6JTJxlxxRgdSfqx7rqHSk?= =?us-ascii?Q?cBnRwTrIsEET7ajfKT1kXuVTl5V3XYKcwL9l4Sb5yHyDjjrvxBc9sFscsEkv?= =?us-ascii?Q?l33lTpc6zD4gYN/jZcWuiOdV5dy/lY8KYEegg+oUWksQsj+chZxnNjsc2RKf?= =?us-ascii?Q?sUDwfNKsL/1CzGqsbmdlBuTlwDID2TOk/z10H8ZOCcLCJ1/g33uy5EAtRRe6?= =?us-ascii?Q?eJVmnnsEBmqsUKdWa1OFNyttGFYctMHwloN8NMrvCjnFPJ8DVPTzFo5WKAxn?= =?us-ascii?Q?MiB8XiyQHmXuB8/eSoR1+qYE7uGS8rRRGV0fgtZop9lDIZ5gvr2ZKvMJ7RAt?= =?us-ascii?Q?vpkxPy+6NjV27G8ZVj4XwPHiQlG5+RsPHVcWa5AVV9OsyfmjmQemcNJ3p6Q4?= =?us-ascii?Q?w2lhlfhEvZXXtoets3v5nr4L2RoKDjcytOPyjLRWk3TOZXmBbH6F993UqiGA?= =?us-ascii?Q?EI+fdSfiufGrvN99o4qxFW1vGOvV2sc3fbPSC0fZHi2InBjOj4CkN3WjCXKV?= =?us-ascii?Q?CtuLzSrMj8G4iv/lMFnH+O7jetOvXwC+hwywu+SixCV0C8qMiIcVyl2l7Nq6?= =?us-ascii?Q?e6QAg1kPbkGq9uYYb/8xmablQMExp9Bez67zOMcg0vZxG4aURMksicSV6y2S?= =?us-ascii?Q?oaMuqspNDlUFzsdNk40yaZgArxszVkn99kT8x6HEeUBc635uJpmxWVZo39zx?= =?us-ascii?Q?bw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xbPOZ56U15KC4Ln+b8yz7mGMmA7NwRG4AJL1quPpbP4XZ+0BzMsSgrJJt1myZhiTrUzrgSpWQJ4yvEiXlVV8PmzSMcgB6BnFjsUzQMSI4eIVLs3m2S2tPshuKizmtzjLYYarRiyS4hx6n7qgzCatRtA1z8sMOgFq6BpgdyEhiKhb6niCq/L6NyfkaeoJc63XAZNAQJLAtDGzHlqAvvDI481o03dFwAReSpVzx3DEeC07V+r+gJrM2vQMjS2mKnzCKipLkMVRZ5mB/J6Ke5NnsSm3m6kof93nwAzeDcyjmrem5rSix2XRK40Hyo0VR7QQVqOI3KBCI9Yzq3phSpTbrY/meEAMnqxid6mush6wWDd1mJfEmOhpKEpgrthuXZ9TYND8+s2vEpfriaTUkrQSsZhIRPI955G3dycdSDcXBRuUW58YrBnm6nexHKemCQoSHWMdJajmEsjP66Nod7/L0G+R/84/es3A47IXQK33KGlmT/Wggj836IonYvRIccW8tdzL5L+RUHROHVadECEbwQCEDEYstpJ+o3F8Tx1ctXz9HZxG3T2RE5ROj+YgUE6OXhhnIXNzueGrXRKxD0htEpCDi08rusqpBqQVlJN3Do4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 373e83f2-cc74-437b-043a-08dcf36f4950 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2024 14:30:47.8253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qjIbDCpoHWFJbsHtj3qtW0xof5rjuiMgh6SsW0bJ2C7oSqvUQOZbKeE8ECr0D30LMZ/xgbMfQreB8GGNWN/ynw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6636 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-23_12,2024-10-23_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410230088 X-Proofpoint-ORIG-GUID: 8zUsBLNRAG8T5qX9v-PDio3Hyy5SHmZC X-Proofpoint-GUID: 8zUsBLNRAG8T5qX9v-PDio3Hyy5SHmZC X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B71612001E X-Stat-Signature: bftro6durg69p9a4xjhr8hezb3p1reqs X-Rspam-User: X-HE-Tag: 1729693830-551303 X-HE-Meta: U2FsdGVkX1/Sl4pXe1rYCTm6Q9HfZ84XXI9icqrp99Mv4pd80C/Rm+t0ngeC+y3tHhcuJU9BgOs67EHiWKnIUljeN/jCfrSWkH0DG0PejwZQsYiQv1AFoCIHGvcNtujdjhmNZyihokRPB1/fwS0QnYadzInfkAUxDO/GoRjacxWu7RfwGFx1Vjw+prMBJTiMfMlpX+5vWd+jmxPFr8hJsQpL9Lc/w6cyuz43OLNpfr1eRr8XpNZ0QJYbf/NHO8ysb8jivT8iTZizJRrvDOwxtm3jLgsEHo5QC3CdpzV9E70J3jaa7UAxpgMDYis/P4UC2sYeE0P7StjVERq4gbgbSlTKAHzdb9ht5ZuynRSA8/KqWdHSdKtmOtaVmzyLKk44b2zqdbzOKp/7SKtzkDTZs4EJm7HY/OE+LLPyDIa+a6OcdperLKaAjqOTlp0UEWAFAambVVmrVLDXkpyAOG66EnhvBgKRX9ZqWWZk/BCuexApME7rpGgFkiJXHxnkJVvLGzZwLcWPUf6wtJQ/NVqWf2DSQ0qMaOwUS9AU03CwHShQ95lCcNUG4hltLgeo8IiNCdlUIfWymiPp4BDs9hjSS39KpAC5rRzq6mb47p5xMJmwzJNxlyujWoYGHxFplbfn5tFl+5uZnHjT8hkVqIbEhnVawRpfyYJBiMVKK3ms+YyRHrQng4+d7xlihpXuaSqij51xnRz6vgpGRIMatK8eRIDj5RdGcSbbOHkYs/wvL/jndj0wpLjhiP/HjF6aNNvvflE9YiLjOFnz1pit7JGrjJEefn97REZqbTUS9BOfQcc3i0wL57Kaff6zhRGzVfJc4rE8qL6oYih/PPnL1dyVUYBZv5x8XxpKW2YWQo7JnY1q6xhZgEdEpZUjdx5PmHndWAmC8ml3kTeQFYeE7OCtojG+7msoXYtU5LYnL1oxTsCWP+Gddmk3HMJohj//AhsUIVglblZUSftgeeyLk1N ik6HJk9j YRUnZ3bVZhXLsgcT5biIg1dRa159L1nO/DWM4HLOZn0gcKdfQNscGAx902MFFYi1d726LQvCX/E2dVueQ3OYIDj/xWVqqNIN8pOkz/6onQkTlq7AFS5nNGTJnA2LdxOYDny0F/wOVl/u/pdkjelCNeAYyQFWe0JGZu7xADdWD2iXdqF05q0pm8EeMtvbGcgw9Zbp8KQhlbJbxwWEen0NBqBb+XeBgCg5UeojGzetnCIQu0rCDatFxAf1mixWzXUcY7+xUm/hOBw4jLFd6z7v2uKqnfHoqsH/yOumxCkTbYCHLogsPi9DPyyQ1c8D1Vr2HJdEiIdOJXsTrf8+o2bT68Glb5+MW9uFsupQVainQP/dOiQwkPggysyO4KTT12PVvyhuuCj3DfbLoCLq4Ko52mI6N+VZUJfoga6FOc+ZvpeABuC4NgmAnFt+YrzZ3rV4B/M533tTP8VZzkul0MyB9QxCAzPmfZuYcjJFiTwMz1DeTXhd7iZX78KloV6OxxuX+xfVGiADGct8D/AlO6VWK5zuj28pytuB1RqqTHI7ydJTZdCeWCRvalVoR2B4kBu/DXGw6u7gvsGmm/sZxU7oEXg1ImZW5P4s0Uf4HUAvmws5CYBI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lorenzo Stoakes [241022 16:41]: > Refactor the map_deny_write_exec() to not unnecessarily require a VMA > parameter but rather to accept VMA flags parameters, which allows us to use > this function early in mmap_region() in a subsequent commit. > > While we're here, we refactor the function to be more readable and add some > additional documentation. > > Reported-by: Jann Horn > Fixes: deb0f6562884 ("mm/mmap: undo ->mmap() when arch_validate_flags() fails") > Cc: stable > Signed-off-by: Lorenzo Stoakes Reviewed-by: Liam R. Howlett > --- > include/linux/mman.h | 21 ++++++++++++++++++--- > mm/mmap.c | 2 +- > mm/mprotect.c | 2 +- > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mman.h b/include/linux/mman.h > index bcb201ab7a41..d71f83b821ef 100644 > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -188,16 +188,31 @@ static inline bool arch_memory_deny_write_exec_supported(void) > * > * d) mmap(PROT_READ | PROT_EXEC) > * mmap(PROT_READ | PROT_EXEC | PROT_BTI) nit: the arguments are not in the comments (which is a pre-existing issue). > + * > + * This is only applicable if the user has set the Memory-Deny-Write-Execute > + * (MDWE) protection mask for the current process. > + * > + * @old specifies the VMA flags the VMA originally possessed, and @new the ones > + * we propose to set. > + * > + * Return: false if proposed change is OK, true if not ok and should be denied. > */ > -static inline bool map_deny_write_exec(struct vm_area_struct *vma, unsigned long vm_flags) > +static inline bool map_deny_write_exec(unsigned long old, unsigned long new) Nit: somehow "new" is special in my editor. Also, I'm too lazy to fix my editor so I'll live with it. > { > + /* If MDWE is disabled, we have nothing to deny. */ > if (!test_bit(MMF_HAS_MDWE, ¤t->mm->flags)) > return false; > > - if ((vm_flags & VM_EXEC) && (vm_flags & VM_WRITE)) > + /* If the new VMA is not executable, we have nothing to deny. */ > + if (!(new & VM_EXEC)) > + return false; > + > + /* Under MDWE we absolutely do not accept writably executable... */ > + if (new & VM_WRITE) > return true; > > - if (!(vma->vm_flags & VM_EXEC) && (vm_flags & VM_EXEC)) > + /* ...nor newly executable VMAs. */ > + if (!(old & VM_EXEC)) > return true; > > return false; > diff --git a/mm/mmap.c b/mm/mmap.c > index d55c58e99a54..66edf0ebba94 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1508,7 +1508,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > vma_set_anonymous(vma); > } > > - if (map_deny_write_exec(vma, vma->vm_flags)) { > + if (map_deny_write_exec(vma->vm_flags, vma->vm_flags)) { > error = -EACCES; > goto close_and_free_vma; > } > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 0c5d6d06107d..6f450af3252e 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -810,7 +810,7 @@ static int do_mprotect_pkey(unsigned long start, size_t len, > break; > } > > - if (map_deny_write_exec(vma, newflags)) { > + if (map_deny_write_exec(vma->vm_flags, newflags)) { > error = -EACCES; > break; > } > -- > 2.47.0