From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E7BC48BEB for ; Thu, 15 Feb 2024 10:41:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 384166B006E; Thu, 15 Feb 2024 05:41:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 332A96B008A; Thu, 15 Feb 2024 05:41:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FA536B0085; Thu, 15 Feb 2024 05:41:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C0B78D000E for ; Thu, 15 Feb 2024 05:41:01 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6F9041014 for ; Thu, 15 Feb 2024 10:41:00 +0000 (UTC) X-FDA: 81793695480.29.97DB478 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 8C9201C0006 for ; Thu, 15 Feb 2024 10:40:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M2Q7dZje; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707993658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dn6tveOs8PusEs8m4mD6zhNeKDU0VeTYuAwtKeY+rs0=; b=j1IKih9lcqiT5iz4NHNkYZq7bL7c+UiTeztvNTZmAJIxmi2/kyJObGDpPydk6Aik6nIIV3 NErGJB4moKiK57hLqnqbwcBoIRqYvo1MlEE+0M3RJY9O3t9ZZxxv5qTAByxasUJF8/pVTG r993Ez+iJeKoq47/nxome0SQqr6nWQU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M2Q7dZje; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707993658; a=rsa-sha256; cv=none; b=hg3+KhQVR4WQvSHs7owoDx+FKuj2shWt0uLldheA/yOsN9den3QpOO5SQp2heEqI+T8b6c q2n8cbRi/WSp4aEr9ueWtGojE/eiCuRq1FFGktJpY1MW8mWmfvIFaGtBrqmB/+X2RcjtKp L863p3JEPd/o1n0XJ81ZmcGW/Csjenc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707993657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dn6tveOs8PusEs8m4mD6zhNeKDU0VeTYuAwtKeY+rs0=; b=M2Q7dZjePAHFju4KIcgDQjHQHeQl5D/Q94GVRS9XgzzhORZDAJNxK43Fi4Wh9OTKY/VKVg E85RL7x/Ke4waaVRPUQBJYxRn/3jyTPj2kajIe/z69eBdtchxqfueDSkOK+Yez+cjrZ5rT 1FB/1Xnpi+OnS2iNoMtBgGLImXUnMH0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-n6RgQz9WObukrRjKtAIr2g-1; Thu, 15 Feb 2024 05:40:56 -0500 X-MC-Unique: n6RgQz9WObukrRjKtAIr2g-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-68c51abe499so13044966d6.2 for ; Thu, 15 Feb 2024 02:40:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707993655; x=1708598455; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dn6tveOs8PusEs8m4mD6zhNeKDU0VeTYuAwtKeY+rs0=; b=dA8RjOxcluwy9rYh78E0aPjUYeGH1mcT2yyIlnEA0Tvr+3egWGwhORT662obEmUPP2 fiH0AwiLaq+G9qCqNZrU/GNfHDmlMbnMs4wZ3HIsbkVQUuGtHImIse06R6LoV3dLq3s5 a5qnY8/IbSiwEtpUwCS6+sTlBs29QccU47h8GtNdzAUuQEPosEJU8AuEdEF1s5NXnZH2 S7MQTOicDZY/hatYIU62bgaHgvoFfT60PuMRon4Ebk5iqAdgciwoHepb9462T69QveS3 3keAhNTpcz26Q6WnF0JFKw1MTGYslBE/gDCGYBQbb+3OoecCHw0fAyHq3jS4xSv0WYCk cp6A== X-Forwarded-Encrypted: i=1; AJvYcCV74RTn0OUNq+6fFCvuM1hV+p3NQWt7kzI1a/2K+nrOOxNll++e3XUU/i5X0wrAlnB+vOY2jKdQu/z00OYHLV72mrc= X-Gm-Message-State: AOJu0Yx2tHaR5v2QinWn0Hc67sj5w8iRWCgCvVDKEyrTIc/YjVFJARJ2 3e+fKnpgcCCumyhQIocXI2qqDhLYiYjDeL5RQjWJAsGukmya4XJEAtDTKJN/9hnPn75O6ESNNPn 4x0Z1ZjR418Q6nn5exfExFV0m7cfQskOlCWOWDgQGeBPZge4s X-Received: by 2002:a0c:f5d3:0:b0:68c:46e0:78d with SMTP id q19-20020a0cf5d3000000b0068c46e0078dmr1336997qvm.45.1707993655387; Thu, 15 Feb 2024 02:40:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMIzzBE86F6/yl4ubcuKOsVW2ImujOvA9fp0gqQGQAEFO2Q+VxkIQrF3T8orreKnGMsgBwPg== X-Received: by 2002:a0c:f5d3:0:b0:68c:46e0:78d with SMTP id q19-20020a0cf5d3000000b0068c46e0078dmr1336986qvm.45.1707993655069; Thu, 15 Feb 2024 02:40:55 -0800 (PST) Received: from ?IPV6:2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e? (p200300d82f3c3f007177eb0cd3d24b0e.dip0.t-ipconnect.de. [2003:d8:2f3c:3f00:7177:eb0c:d3d2:4b0e]) by smtp.gmail.com with ESMTPSA id lu7-20020a0562145a0700b0068efbe2235asm535657qvb.54.2024.02.15.02.40.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Feb 2024 02:40:54 -0800 (PST) Message-ID: <3dd9a4b1-d912-4a92-9450-97ca816a267b@redhat.com> Date: Thu, 15 Feb 2024 11:40:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/18] mm: Introduce pte_advance_pfn() and use for pte_next_pfn() To: Ryan Roberts , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240215103205.2607016-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8C9201C0006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: w6xirdunzx6wceh1x6y366nq76w6b7u9 X-HE-Tag: 1707993658-243254 X-HE-Meta: U2FsdGVkX1/2WVwFP6B0YjRrZib8Ve/QOcY9XxgaNrV4gL3xlefEEUrJokjgj4LB2ZaSozESvvE5WofvgViB2gBzipgj6Ol9haSKeNO57U+2DBa35yc+sABelryxpe2jYqSCCGDgciO/42cdbpdU/1rKqcjBAvx3kOJ8iBAP3Dmjb7pT0EG55fuofJtO/2FlnwwbiqDZh/GxEpPcgh8ZkmUeJFqrEO6sKnQMPk5zu9xWfRlMVT5laB2FRZrAEb6bekd61ZLGWOFImCJn56TUmZEp9On24vuPY/OchOVxCLQuXx56T6XlmQ/6GaGOYHWrAv5KQSdjqJ2iqKtEG0EKKpsyzNosX410lEwtDyyELl7/CNBHW+VH5BvdY7yjarbNg7pvdf+cXep6tF/okrA1df4AfdMP9q+AQ6YXTsPCNJB9/lm33p7D3GhYCvsO0XfynnHLBlJ8xRxY6GAVOTNgDZAx8pGykEP3QPiER6TL1Hsd9RdVvagDmsxl0E5fJLTtlROSZraCU0wmbexJsPMc6zEdbKzfz776ZT4eg6rZyMI1ZPBspPlEXnV7caOvlYmF9sMrWrg3Cxx0kzZPhKjbfTtD8XxtrwfwN5Tsv9W5PlDg86ckUlOkskYE2lwa2ny2F5fUyarkL8ElU6nHAlP00VaZ+DP6reGYEoZ9xhp3pEVJt6tymvwbCs/XbB+kka2QJtRSdo0wive9/UUyyBfbK5mUpPm79acIOSLMZC0niZ/h8Uha164gKBiUDhiUhYq4Fy8PhFg4Km0v33ik5bdeTvSA2g2gQgAJDPUfo+F4YES95OUev1i3NKtABP1XmdDeBvPc5x02ZBvTfq+YDtfjyD1Za/0s3w12GDT/LEVrGoz46OEwQ80j0LiRbMord1RPokLRZTYazs4+c6MhvxBuBl4tY9qXqeunh9gL/IxbLMguK2kyU+PJpiDUyVg0TaU7ngLI2l+ZA2Po6R6nN1N kJeKrsdz CZXYtHOLUUxZO9HfW0UrC3IbSfwjm7paYo3AJvEiLQ0ageQdRoMq+oZTXcRLD8q6nEccmRkfXFYi880OmUUfkQS0SLaE2tPrP3Nlz9u3h07DNTXILQUbh256x2Z17Eth96WkiTsN0pc54EbcBz+10V5kSI65rjIBu81GePp5djAwY0xZBJEBf18HFH57XeoInabmKrJu4PUDatPqL1zWeceXlqfo2NtxBUA3gi50V8Xs3xgi1TAeSOeyMS6BINu8CaGz/PbwdlAJEv2n7Cmh39xYePfY/qh4G0k2RbA0PWcs0BW5xeKNFP4FKYE/gvfj7WntIY6Nh78j9Ss4P7pSVJ2J0yZIFt0cFgAVY9cbbZw5h91HatRX9JIwlPhrSV8u764GupOp86LXn/BVaJXfnCtKg8l43TCl9Lo9mYFXwGFIEfobiQLGXi/ehVQuURM23Cc8kRXVb7usP7EoXdPhBaujE9E61mrMev7gyz8mfmb+AxwU472pMe9rRcsp7MB94ln4IXAciG/tPTeySlgFW1JrfHNZv/joNgF7zJ1o501P5qwdhYrdWaOdDMBmAHuu/EQd7xCuRdFyhN/tiNfOg0djKk+fh7Un2vPry1MKQ7zOS9eabOXglaUu13g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.02.24 11:31, Ryan Roberts wrote: > The goal is to be able to advance a PTE by an arbitrary number of PFNs. > So introduce a new API that takes a nr param. Define the default > implementation here and allow for architectures to override. > pte_next_pfn() becomes a wrapper around pte_advance_pfn(). > > Follow up commits will convert each overriding architecture's > pte_next_pfn() to pte_advance_pfn(). > > Signed-off-by: Ryan Roberts > --- > include/linux/pgtable.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 231370e1b80f..b7ac8358f2aa 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -212,14 +212,17 @@ static inline int pmd_dirty(pmd_t pmd) > #define arch_flush_lazy_mmu_mode() do {} while (0) > #endif > > - > #ifndef pte_next_pfn > -static inline pte_t pte_next_pfn(pte_t pte) > +#ifndef pte_advance_pfn > +static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > { > - return __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); > } > #endif > > +#define pte_next_pfn(pte) pte_advance_pfn(pte, 1) > +#endif > + > #ifndef set_ptes > /** > * set_ptes - Map consecutive pages to a contiguous range of addresses. Acked-by: David Hildenbrand -- Cheers, David / dhildenb