From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B0BFC3DA63 for ; Tue, 23 Jul 2024 10:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7651A6B0089; Tue, 23 Jul 2024 06:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ECFA6B008A; Tue, 23 Jul 2024 06:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5664B6B008C; Tue, 23 Jul 2024 06:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3633A6B0089 for ; Tue, 23 Jul 2024 06:14:53 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E4751C4245 for ; Tue, 23 Jul 2024 10:14:52 +0000 (UTC) X-FDA: 82370608824.07.549284A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 582CBC001C for ; Tue, 23 Jul 2024 10:14:50 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dhJFhM/y"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721729667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XlFxZ+XlkpR4+j6b6lDCxwV3tYEU5UHjvLxc8Lst/vo=; b=w1DbnXPaftgGtkACGuYZrKRffFiTF9xRoeaxhIirlxcgMYHPE7FcOJ0q3gXw0lXtK8ttqc dgg8IQVpf/FINgG0ge6J3+RePw2X4r7XXx9aV3cYVCiM/YK/1SmODglWV8hkpGVp8KnS9V FMGHR1SnS6FRMXbJD3L/8yKPIY0ye0s= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dhJFhM/y"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721729667; a=rsa-sha256; cv=none; b=8aiwruzXo2AGpGcd/V9Uxlp7qvOvjKSCkgC/GKVVYBhLbgpta+iXjRBX17RLsORIGT8w+s cUtAM4OvW30Mz190nCbNKGPbz/DOkaq72R0pNWs2WT14yReOqmO394OMyNc6IeuQlkt7pm B9zetaSPTAguM+YKDfmbXWcvb6iZRvM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721729689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XlFxZ+XlkpR4+j6b6lDCxwV3tYEU5UHjvLxc8Lst/vo=; b=dhJFhM/yWJbVgMBYuSk8Ln7xMaPLf+BNYphFrpAwUKSPn8XKqLrPVXxofEV9bgDl71VIbJ RHgEpgXIGulzhYFwpb9u/PqA+jrGXwOAo3awdJPkr6BrIS8m0oz53Ip684IXe1KXOn07VR l2seIlKaxqzeMGozji3uIARJTwMWI50= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-BMeXdAt_Mc2oam4CX0FGtw-1; Tue, 23 Jul 2024 06:14:48 -0400 X-MC-Unique: BMeXdAt_Mc2oam4CX0FGtw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4265464ddc9so23773675e9.1 for ; Tue, 23 Jul 2024 03:14:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721729687; x=1722334487; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XlFxZ+XlkpR4+j6b6lDCxwV3tYEU5UHjvLxc8Lst/vo=; b=B00+4hPFWYZ+XzN0+z9lggEWeaGBz8eMjkdjcnClD4ELpMGSuc59qNRo2xG9+ZbBIE hu1kTLQjEKVaIpUhL0QW0B8sEnpD3u33iqWW9pq1N9DcreVTL1y9WSbdKeGyp5+2D5ZA ECBQYLwwJ/MmIfSw4NxcUm1py79XdntuW8pgA+cbXe0MMmUn88OU/9ldCPfRjRc8XemT FZwti3V9D+3qE2G9dbGGWyQId42n9may2RKeaolYbqOm82eL8TrcuQ4WnC8sAaVBej0p TRxovC+n+uiFphY56/qs7s0HTXALO982KXYpfwNlDT3df2WEPWrN0LVXaW4/tLt5Ic73 7Iyw== X-Forwarded-Encrypted: i=1; AJvYcCUmi3DWjDKFKCn2TK9v4I+dJYm63IZpB43pHvOkFYTxLg2i6Rc/6bX/klrJv5Ti80Wz37Mt+YWmKG7njtpCYXC8NWE= X-Gm-Message-State: AOJu0YyQuW+N0CC6FLrj/tNmCt5LfZLtOdsk78STyvoN+vQ6XoFPFx3e bt9trWiM53Xv455M7HekKQ6Tv2dMpcqwSynb7deLQTcX9Z/ITzQdXwVHXqnvo8g7I6ck/4kMmPu 4uZsmjToD1mc6qpjvXukLde/fOX/K36Sx4xnyZW+AfygkEtT1 X-Received: by 2002:a05:600c:3583:b0:427:abfd:4432 with SMTP id 5b1f17b1804b1-427ef3a885emr11669915e9.12.1721729687160; Tue, 23 Jul 2024 03:14:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHoBse6L8kdIBGmNij8ozd1MUp8F0t6d3W6q/68QdWE15CCDvEAXBZx3wnDH0cQAASoS0VLA== X-Received: by 2002:a05:600c:3583:b0:427:abfd:4432 with SMTP id 5b1f17b1804b1-427ef3a885emr11669755e9.12.1721729686762; Tue, 23 Jul 2024 03:14:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ed00:9dc2:1adb:d133:4434? (p200300cbc72fed009dc21adbd1334434.dip0.t-ipconnect.de. [2003:cb:c72f:ed00:9dc2:1adb:d133:4434]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d68fa0a6sm167944555e9.9.2024.07.23.03.14.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jul 2024 03:14:45 -0700 (PDT) Message-ID: <3d9ea6fd-03f4-4fd5-8407-2201e8ba5010@redhat.com> Date: Tue, 23 Jul 2024 12:14:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] memory tiering: introduce folio_has_cpupid() check To: Lorenzo Stoakes , Zi Yan Cc: Andrew Morton , linux-mm@kvack.org, "Huang, Ying" , Baolin Wang , Kefeng Wang , linux-kernel@vger.kernel.org References: <20240722172917.503370-1-ziy@nvidia.com> <20240722172917.503370-2-ziy@nvidia.com> <6effd690-3cf2-46bc-8061-2d19922ad4fa@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6effd690-3cf2-46bc-8061-2d19922ad4fa@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 582CBC001C X-Stat-Signature: h6mz7phg9thxrx9sooxn4dtohd8ox8fh X-HE-Tag: 1721729690-478708 X-HE-Meta: U2FsdGVkX1/ZCW/vqq+2JO8vSmzZXnGaYGK+5AGXLSY8wO4OfD9kmf2AbEecnyh1Uw2ZaLhaGRtr1vOCK6XNZLJRxknmD5lzCMxlr/cQCu4z2vG2NcmgP7oFM4HYRG8xiInN66QwTRgRZ3RI5reMld8sz+er70/rL1a/kL+I2oxwBCvK21QJ1TPAHywdLA+QvB4jozZIU/eIw50lAoShdh6x+iM2Vph5O1gUhUuuLKQpUtZRQpRARS5kPU6Kdh1LDL+0wHhgzSZl6xo+UmcaXmbum8RD7sysV/9C7ZHlY6UhsnYmwUql5kvbwO3/DRk/3wp9x9SItJfnI284kHWt4YVlpYgp8zRabNFDMoQmN0t603LkeKItc9TcS8odZ/4XL2M/03p+sI50eJ33qHVrAdKTP/wXwSAo33IOOLAkfERAZ3psghPtgtfp1xJVKoe+UpFUrXlExOFhX2hnu4ks8JjVSDicGYFdQ/sdUDJnZ5p2oZPoXg8g2WkzOezJsHD5/Bc1+ahxIul0zEnGJx/8BbPdOpqZFGZ8/Lb55DrBHe5YzBO0+kH02n0jR75RgU3tDDvLQQujWSzkH8L7CgfLtJwV7EpHFocWucJhBE3pwzNJajKAt2+5y6Wc6W794XGv3/17jgeyANKXHQPqxgG3Z8BdwBf4vl0VZm8Z2w6RRaTL5nYtYpLNqJIeJFjsnD6JI2DrAPp/KcnoLmezivzazuyZfIzTF8BJtnpnS2ivEo64Lkg54IzJVaOCW34FoP7lIvR4OEe6tgs6BZtjQ4NCjO2QVGciuf3K/thqVHLF2MUqji+Dc5nW2lOvenCjD9wV6qABmqJFSVtj1CbByTYgdLLN2MenAOqffMkNOUg0k+2I5n6JWaPFeuyuRsT/RDL1xDiewJ1GVhc0/6hWjgw5xuVL/ilnzuqpdtgh7YGe+XV+sVozkBG/SptwWBEwuGWpANqAZiJg684QwIxBY// oDTTe4IZ E5g7WarhV/5EKrd4QsSIElW4zt5KHCewb+rVjbQMXd+/PxhvEWHu/YZaPUKk+a35Yz7LDMm2CK/HsH9YdQbSeATrJH4Z1vKgtxfJ7U79cVEewhXqVpFMHDiv0Qmaj6BHvmnGR7b0zjyhmZGINUOCuqINCj79/xpnT82v/QZbnkGdkvC7WqALpJMU/3Lu1XHGhY75OvxqV+CqdtLEBanH9VSXFy50TlKHw74nSmpygyYAWtJAt7Y2ipI9FfAIZFYQgkSZIZS3u5VINa8NZups1VOwh80/wTA82ZhS++B+Ss9F9qUdbc0pARrRU/WbIxfYpDCDaWIKipOZFe0ibH+gsb2cEUmhyutHAuMDZ1U67cJW89kKBQHqGYWgkSObQU+fUnKl6SKivAeLMmmChcgpupJ2FKVO9TTrh0wpa1dJBpG/VR0QmVUCd37zTRZ3ilXPML2W2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > The static version of folio_has_cpupid() is defined in include/linux/mm.h > if !CONFIG_NUMA_BALANCING but you define the function in memory-tiers.c > unconditionally, a file that is compiled predicated on CONFIG_NUMA. > > So a config with !CONFIG_NUMA_BALANCING but CONFIG_NUMA set results in a > compilation error (I just hit it this morning in mm-unstable). > > A minimal fix for this is to wrap the declaration in: > > #ifdef CONFIG_NUMA_BALANCING > ... > #endif > > I've tried this locally and it resolves the issue. Agreed, with that Acked-by: David Hildenbrand -- Cheers, David / dhildenb