From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>, Zi Yan <ziy@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, "Huang, Ying" <ying.huang@intel.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] memory tiering: introduce folio_has_cpupid() check
Date: Tue, 23 Jul 2024 12:14:44 +0200 [thread overview]
Message-ID: <3d9ea6fd-03f4-4fd5-8407-2201e8ba5010@redhat.com> (raw)
In-Reply-To: <6effd690-3cf2-46bc-8061-2d19922ad4fa@lucifer.local>
>
> The static version of folio_has_cpupid() is defined in include/linux/mm.h
> if !CONFIG_NUMA_BALANCING but you define the function in memory-tiers.c
> unconditionally, a file that is compiled predicated on CONFIG_NUMA.
>
> So a config with !CONFIG_NUMA_BALANCING but CONFIG_NUMA set results in a
> compilation error (I just hit it this morning in mm-unstable).
>
> A minimal fix for this is to wrap the declaration in:
>
> #ifdef CONFIG_NUMA_BALANCING
> ...
> #endif
>
> I've tried this locally and it resolves the issue.
Agreed, with that
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-07-23 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 17:29 [PATCH v2 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() Zi Yan
2024-07-22 17:29 ` [PATCH v2 2/3] memory tiering: introduce folio_has_cpupid() check Zi Yan
2024-07-23 5:54 ` Lorenzo Stoakes
2024-07-23 10:14 ` David Hildenbrand [this message]
2024-07-23 12:55 ` Zi Yan
2024-07-22 17:29 ` [PATCH v2 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled Zi Yan
2024-07-23 1:48 ` Kefeng Wang
2024-07-23 1:54 ` Zi Yan
2024-07-23 3:24 ` Kefeng Wang
2024-07-23 5:46 ` Huang, Ying
2024-07-23 10:17 ` David Hildenbrand
2024-07-23 13:03 ` Zi Yan
2024-07-24 1:22 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9ea6fd-03f4-4fd5-8407-2201e8ba5010@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox