From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D0BD41C27 for ; Wed, 13 Nov 2024 09:57:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B630F6B00C9; Wed, 13 Nov 2024 04:57:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0D866B00CA; Wed, 13 Nov 2024 04:57:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9880A6B00CB; Wed, 13 Nov 2024 04:57:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 772C16B00C9 for ; Wed, 13 Nov 2024 04:57:55 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0B4E61A0934 for ; Wed, 13 Nov 2024 09:57:55 +0000 (UTC) X-FDA: 82780618326.01.A3054E0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf09.hostedemail.com (Postfix) with ESMTP id 2B3D7140003 for ; Wed, 13 Nov 2024 09:57:22 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0TlU+W/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHOpp8cS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0TlU+W/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHOpp8cS; spf=pass (imf09.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731491679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hV5b2CTqSgF2h+VoSWAvQ30MrQovnUdkQI+o+QMCBVY=; b=ASJbIejVNHE1QD8LXih8QKHQd5y0wViySTfEnZlJGo0/ViJBjnX78Jsmd+VyR3sYuaLrT7 DvTvOfvElXn55/Ho/uqUkLW8oDb+WgQQ4skn+jK7MOp1x3IFor50I8EyTvrCkSX/rxGrJ1 wErJcqDieXn7Fa2nzuDNG5QQL0sVbyk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0TlU+W/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHOpp8cS; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="0TlU+W/4"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qHOpp8cS; spf=pass (imf09.hostedemail.com: domain of hare@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731491679; a=rsa-sha256; cv=none; b=WJBPneyVuHe/12S8zE3ssDyV/NEk7CQzeK/RQhUJfl+X0Z3xCnsHZY5VH9W+mf+zEswsAe uMpzhKI37ul4zJVuVRZRilm5zxMLjcMzH9LHmVEPNYkq2aAEDp47ExIxjw05ZScag4vhHM aGd9vutV4azMR01ObNZTq5WAfpYSdZA= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 91407211D6; Wed, 13 Nov 2024 09:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731491871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hV5b2CTqSgF2h+VoSWAvQ30MrQovnUdkQI+o+QMCBVY=; b=0TlU+W/4bUYp+OByx7+NiiisHCjUfndCfhqSJhZQkJMLn0OUU9WqxgPH1o0/98eMuTxTCQ PGpTGnWdh/dPIueFN2n3YKtSvaSlVdJJ8LwlgBWVGNztaYIg93OnGp55u1YFDIiR/9i0gM 9rtxEcqbiAQ4jb5nk9gHm7Gj5acoXHI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731491871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hV5b2CTqSgF2h+VoSWAvQ30MrQovnUdkQI+o+QMCBVY=; b=qHOpp8cSsFXAQyLcVqoXHnxXQtAA/EmyUipW5697pZVksMUNMxCNsDFOamF8lbCm1dM05/ Yg/jvVRe78G4TXCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731491871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hV5b2CTqSgF2h+VoSWAvQ30MrQovnUdkQI+o+QMCBVY=; b=0TlU+W/4bUYp+OByx7+NiiisHCjUfndCfhqSJhZQkJMLn0OUU9WqxgPH1o0/98eMuTxTCQ PGpTGnWdh/dPIueFN2n3YKtSvaSlVdJJ8LwlgBWVGNztaYIg93OnGp55u1YFDIiR/9i0gM 9rtxEcqbiAQ4jb5nk9gHm7Gj5acoXHI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731491871; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hV5b2CTqSgF2h+VoSWAvQ30MrQovnUdkQI+o+QMCBVY=; b=qHOpp8cSsFXAQyLcVqoXHnxXQtAA/EmyUipW5697pZVksMUNMxCNsDFOamF8lbCm1dM05/ Yg/jvVRe78G4TXCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 67A6813A6E; Wed, 13 Nov 2024 09:57:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CF3dGB94NGfzGQAAD6G6ig (envelope-from ); Wed, 13 Nov 2024 09:57:51 +0000 Message-ID: <3d9b08b2-b130-49a5-b69f-5b51b27848af@suse.de> Date: Wed, 13 Nov 2024 10:57:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 7/8] nvme: remove superfluous block size check To: Luis Chamberlain , willy@infradead.org, hch@lst.de, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-8-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241113094727.1497722-8-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2B3D7140003 X-Stat-Signature: aef7491jwaeywqa8hrjikrkkw68n8eew X-Rspam-User: X-HE-Tag: 1731491842-135491 X-HE-Meta: U2FsdGVkX1/f69HuicEfeboAY5k3gaPLABzkL5F6+ctlHtuCfodHJVAitTvHzCrlSRzxmjdp+rItYETEGXKIvNc0mNTQ9rb8GCDXeWcIalLIc1nWEOrCgDwak96Pp01Cc3JLYiJIK5L3LP90TYso3CnFhEIgXaTAJEXBkIz6JKNVO/KGRbKs1C9Wg1Ri7wdSk/Bs3wf6+NmCmqVkrH1oLFs37+6OAqZXGLRzHSI2y1cZb0cjA30UWZdAHaT43lzBNzgu2VdRYcIaONn9g38R9ZEVHiBfjSf55FrYhbD7U5SRviRUDdSZT58NbE1fhGwBReb1pTfSb1LWFZTic8sw3yV6fo2l5KIaL8m+rHF+8pTyS8RXVNPwnxNW9p9Yvp79tr+JZfe0kQn5lpora9rflngo7STuFojr0BkDad94pRpI54AJTTkAXLp1ncFDdSY5Kl3xXgrsJLlv/UsbYlKwrWjfWtK8z+rXzidVjVMbotLxnKP8iwz8RVBDL+/ZeUCiMT9mE5MTeIAsRM11BrTsDy/yGrbNit9dw2Ux5DTDCguyjhbdhwEj+mWH5LHHk0D8etAJNdBMwap3QaSfokRgacg0g4sB/21MVEHVSjonueyTvrHP8BgzqJZjIcRHJsDWPL7f/CJd3Qx2S6lSK3VhPY5ss8ckGxhhlWJLL572IJo5q28BS6NF7lGL8mjRyCBPFc42mXkasTv9MfKrgIf5ikK1UZft/sdcEKdSDG17xs7rWBuRiqimdONaQSKC5AVnlKm27V/odlnrqoqwH/EVXUTgzobMvQWN5XglNCSoD925ldEzX/w1/1Mc3PEUvXCduMiVdJZHJhNATgNHgbyfhbi4wTlAVqLT1GXMjMezXwfqab3RNf8Oc4neSZYzYsWZS4tVhGVj/T0YraDgNU6YpPQXJyPoB3KvLg4+N755IEAY+bUxbqRg1AnoVYEaCwDeoxj06e2JgIM1rdBCd3v Tv9R0zOe +RFgxcUiBNGgFLPcghqJbiK59m6/+XUCpzIOTP47rKJ+koAeng7E85yMyMgkcRP9JWA4gu1JNk/OoWmG4dNgX6qOfnn6ErZZF1h+ROZlIrRhudkytH30vQ+Mw2oi5L0dhzifm1Eij3q9TAxP/tulYo1pLyul4/bJkoby5DlF3xdTpt8bQ0ae4NpeyUFiMRlIOJPg5OWK3uKoI+0crNccWRLULf7CHrmKjFfOgelV3A8ZbXP1bK99XyIAYX1+ch8IFPEo71oZCM6CzcI1+96Q9UJpWHyAXPTl3HU0g9QUzcyercwJi/rvWeWjmfi8pnpfZGmzgAU4bvE3wPwv+hpoPnXTSY3Oqzkzyw1qpdHRJARgrjDRz4ZyH5McneC8xoBxOyui7B8OskSvzDJhMc1jYZYv/tjR11b100Fo3MiujkqIZUWwX5ubWWb6lHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 10:47, Luis Chamberlain wrote: > The block layer already validates proper block sizes with > blk_validate_block_size() for us so we can remove this now > superfluous check. > > Signed-off-by: Luis Chamberlain > --- > drivers/nvme/host/core.c | 10 ---------- > 1 file changed, 10 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich