From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7C4C61DB2 for ; Mon, 9 Jun 2025 04:09:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6489A6B007B; Mon, 9 Jun 2025 00:09:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D24C6B0088; Mon, 9 Jun 2025 00:09:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49A396B0089; Mon, 9 Jun 2025 00:09:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 298F26B007B for ; Mon, 9 Jun 2025 00:09:00 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 34238140D75 for ; Mon, 9 Jun 2025 04:08:59 +0000 (UTC) X-FDA: 83534531598.21.00E91E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id F00A6C0003 for ; Mon, 9 Jun 2025 04:08:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DuTTgJh5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749442136; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=znSV+kVarM376WETpFG5vxmhQ7lGKQs0oHqrXu/evqo=; b=yJ/AKjBh3i3ajDQcfV9Ly/4fcHvBr17RwyF4uImGq0qeqOfM8sv2oTuWaLoSGupSRapCH5 ENntaABJnnuUzLHbF4QKPUV/VRG1g6ZIb6vIAh4Sg1+sQCEDGvLU7ItujUIWYvMe4FeUpc Olfdq9kg4h+ZYIpJRdBY6A+rnyiBPBY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DuTTgJh5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of gshan@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gshan@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749442136; a=rsa-sha256; cv=none; b=oLFprDbhsossGB+RKObbeBFlQogExeJPkyDnW2epU+uXU3pMylV+7Ev4OV+5lLC9tXDQ5k pOj+6LtsQqDlc6GfDIL88Q/Koy0zkE8AyFr9UdEyEYV7n4AyR4rsIEPXWobYpaNSV6OQ0B PaoeMQZKxQAAxsh7F+W6SwUOdL/vmO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749442135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=znSV+kVarM376WETpFG5vxmhQ7lGKQs0oHqrXu/evqo=; b=DuTTgJh5mU6sc0wFuyLgBk1o2THkQ4slMsQaknxRi8Ti7Mw3TBtnAhXpciRG2aTLq1IOPx +q6M4ZQib55/6JWYUvixPLm2L8ibLRLx4KgwZJsrOsI6narV4cLvJXFTKZlFbTvaLXbphN PXP8Sa67bju1ZvliA365XqIal8RU6yY= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214-cV3TDVIwMKSuCYT3dAXWlg-1; Mon, 09 Jun 2025 00:08:54 -0400 X-MC-Unique: cV3TDVIwMKSuCYT3dAXWlg-1 X-Mimecast-MFC-AGG-ID: cV3TDVIwMKSuCYT3dAXWlg_1749442133 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-73bfc657aefso2734048b3a.1 for ; Sun, 08 Jun 2025 21:08:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749442133; x=1750046933; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=znSV+kVarM376WETpFG5vxmhQ7lGKQs0oHqrXu/evqo=; b=mM1k6cxmT5GuMEsSJ1B10aXc90emVcynMk7i5FW3ozCIcdSEpBaQ+5mMnzX/Qlzftb zkVmdSPATk63fYJp1FF+3j8HxFfnq7DRwjlpLQuucrIrkBsa1fZPfUH9syBINoiaephN C95fwz0LBF09z/O+LE0cxvbufTYk0zHZm98qJT8p1X1CE8ehLzN0fafi5LGiPfJoiIWx BtCpsScETUqCX6AcWif5+Hyad7ypPwPiReEAy6n9nCiTtdiV7b/yTQARduDPNeYNfJN5 Jsrq1MP05QIni6jvrdhrtnkCCpbN85mCQGavOXgOFjQhSLK6aEBCTB9mK2rt9if8+EnH FTKg== X-Forwarded-Encrypted: i=1; AJvYcCU5W+EFsADm4FfW5XpqupAyFYWsXiAE9W4OfNLlH/UYqJ0d/zQ0I4atdhIL0HjUGC59FYJFfAKFiw==@kvack.org X-Gm-Message-State: AOJu0YwK0SqiMOOYOUVI/rB8S2YILjHYPdnzHgRFGtSNfzSMA3MzMpAd J2ZkwEO9cyaMnbB80c4SvqrW5ryWOjDjYcdYYpTWJL/N6/cNg/xReGQV5U3vbSbJV7GnFiuTJQO NlSwVHlvtIIYdKm/VdwkAejQe2guCw8cqryIbgBX/2GDEi9efuhQB X-Gm-Gg: ASbGncuXhPSyRqfGySNvSkT0h2EFNFDJeDHK5qWriNdOyGVFNIMZzfhxLhLL4fZM9ZS YhKxy7yt22Xpg4qfRdBgdvHTZceuaL4IKHOsejYkR5hI8nPvgXGA3detMb7pmhnA8S5nUiH+B/z JkUWviIzO9zCjDeKBN8aAxTjeJ4BiW1/HCAiKjDaItAu+wBhhQzdv8gFMWq5sZyPZLhEA0Tkuws +72+haxiuw/UZj0cjBaPCee7nr51paZBR9NmpaZrzrTDF508DIpLwATLjsEFrsIP1SSwzl81DOc 0oke6/76L/9oQ62swROGbdCLVpWC1yWexxygQBGuQS+Ec4UtI38= X-Received: by 2002:a05:6a00:1caa:b0:740:596b:4a7f with SMTP id d2e1a72fcca58-74827f10b78mr13424925b3a.16.1749442133140; Sun, 08 Jun 2025 21:08:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7m/zTCGkEamABNbzON01NHA2JLBsIZ9H30Axsha6qHcMH8sLupDXiKBcrqXD+K67xykgA3w== X-Received: by 2002:a05:6a00:1caa:b0:740:596b:4a7f with SMTP id d2e1a72fcca58-74827f10b78mr13424895b3a.16.1749442132715; Sun, 08 Jun 2025 21:08:52 -0700 (PDT) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482af382fcsm4806740b3a.28.2025.06.08.21.08.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Jun 2025 21:08:52 -0700 (PDT) Message-ID: <3d9a15ff-fbb2-4e9a-b97b-c0e40eb23043@redhat.com> Date: Mon, 9 Jun 2025 14:08:30 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 14/18] KVM: arm64: Handle guest_memfd-backed guest page faults To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250605153800.557144-1-tabba@google.com> <20250605153800.557144-15-tabba@google.com> From: Gavin Shan In-Reply-To: <20250605153800.557144-15-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -aUlz9f64GJtcYYi3weKfujg9fJ3H0pxdyF03vvoFHw_1749442133 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F00A6C0003 X-Stat-Signature: mmq6a8bfsmtg6wsb7ouyrkwk8bkk1wyu X-Rspam-User: X-HE-Tag: 1749442135-951739 X-HE-Meta: U2FsdGVkX18Q+HoKLZ2ku71t4mUiSSKnvf0eWGVxFBjCLQONTLeGeUaVIjyJOLQJLTQeFcMD4sl1BXfH961vaXB71QK6zoKzeao1DHzIYT+1WMCfh5T0wrgEISztf0nb23lC8DuVffJm4AlWYmwgG/TCXST+gxRSc+N+8siOQzTJuwxnXR8ozVPnOdxuVpJ5tsbb6UMJVwd58M4Ll90EAxL6nPixtiQh2nIrbsjBrL/OgAI5BU1DTBfmxOgO/wVm0urDPk8//akUodKdhEbUxOnOc8XI8AvqmvWiRt3StlIxmxoz1plROk+OqxXOYfPJZkBhFYhhI3jWkPxBNtwS4A3cKd+eXnG81iuoLSXI/I5CYoXdoGFMDg6V8nqFeBWriWO3MU2AXLm+g6f3WJ0Ktzo2WrWhmYTa5U49zuuJJ+x5qVaq7+/SbcMI33+wFabx+FIrOH5dhe6p3RNcmAIW8sML85cVtiiCDO0bxeHBo37PQh7LGx097bXxWGUBzxZIg4B+C0E/RBHv1dP5Qa7cj8sgYa4XitmXXVbNTsTjhNtn/B5s2vqVy5xysjg9M1PRiRyCyARJoFvnk6Ze7+Xsx20g7ZjKBxnMMEeVJfprp2JZ0Kl0HSVdlhs88kaiKHixit+LVNtArlu297UbUgYEolTSRXU039QYHhgtVJbMApgupZWaFmNoMfkP42skUHf9VCTJhnVyUZxN0T08C1eKvKt4ELGMVhP5r9CRPCUV391WPAjhjNM0J5isenC766pQ07L/QE8agOsLyMsKvpm8/BZWfVEsNy33JVjeDOtaL9d8PbI7GvJ79ZSACfZvNDp/v57MfPG4eEWb7AMEbnVSf+qMSbTPsJmWdB4T6OANwaSIfpL1d78Cqe1u96C45rX5sBGDoZ5UUjMcOazMHVFC//uuKQv7zdzy5h7p+TcjS2mtlCzXQ9SoZE9UWIvV+zogqitX1akoFJskxlr+OP/ U90ImUkz pz5PFJDP16qm3O2Irx/GvND9xqJXse6mmi80mZjT6GJ18gs89M8/6zltTnayxtgxm7eCaIo2gZLiYGH5T3zDpHVd7t4DjafDybA5veRwpvB2afbpVyXe2zNzneAYMGe/ffA2hwJQOG3NHE8fmMMSsXwJr982iKpIRTldDPHPLNeMKkXzbDpSF5Ccl10RIOoNDpFRIpaio/yDJspnjH94Jyi+6+y9GJ0NZ2hG9wD/0RqATx+ooj1LEMNsScSOFg/oH3eX3orsdfs44I3Ldt66B6H8R7+T7DOBCj6Z2sEDx5L4JsII62QrCsDBuPntYy9Wcmxb0aAjUPxQbyFmmJQcPwZNo5E01f7vRX5XgeGw27afxvHnLPZHGBVyDvcGSN+DusGeUToyw6yD5h8N3TQvZn1R43eyMxenNv+kkoPh6rwri+iOd06sZWohHKY+PN77YPr4m4915Rf0E9P1EXTxARHKhIm0CrUwQc2VTx9ofYSigtfOa/1fSUWHNN0DkO4wm+97lmBy5vztPJjM+9ZHax7osM9QHbn1j0IMqNb1lIkS1r9Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fuad, On 6/6/25 1:37 AM, Fuad Tabba wrote: > Add arm64 support for handling guest page faults on guest_memfd backed > memslots. Until guest_memfd supports huge pages, the fault granule is > restricted to PAGE_SIZE. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/kvm/mmu.c | 93 ++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 90 insertions(+), 3 deletions(-) > One comment below. Otherwise, it looks good to me. Reviewed-by: Gavin Shan > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index ce80be116a30..f14925fe6144 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1508,6 +1508,89 @@ static void adjust_nested_fault_perms(struct kvm_s2_trans *nested, > *prot |= kvm_encode_nested_level(nested); > } > > +#define KVM_PGTABLE_WALK_MEMABORT_FLAGS (KVM_PGTABLE_WALK_HANDLE_FAULT | KVM_PGTABLE_WALK_SHARED) > + > +static int gmem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > + struct kvm_s2_trans *nested, > + struct kvm_memory_slot *memslot, bool is_perm) > +{ > + bool logging, write_fault, exec_fault, writable; > + enum kvm_pgtable_walk_flags flags = KVM_PGTABLE_WALK_MEMABORT_FLAGS; > + enum kvm_pgtable_prot prot = KVM_PGTABLE_PROT_R; > + struct kvm_pgtable *pgt = vcpu->arch.hw_mmu->pgt; > + struct page *page; > + struct kvm *kvm = vcpu->kvm; > + void *memcache; > + kvm_pfn_t pfn; > + gfn_t gfn; > + int ret; > + > + ret = prepare_mmu_memcache(vcpu, !is_perm, &memcache); > + if (ret) > + return ret; > + > + if (nested) > + gfn = kvm_s2_trans_output(nested) >> PAGE_SHIFT; > + else > + gfn = fault_ipa >> PAGE_SHIFT; > + > + logging = memslot_is_logging(memslot); > + write_fault = kvm_is_write_fault(vcpu); > + exec_fault = kvm_vcpu_trap_is_exec_fault(vcpu); > + > + if (write_fault && exec_fault) { > + kvm_err("Simultaneous write and execution fault\n"); > + return -EFAULT; > + } > + > + if (is_perm && !write_fault && !exec_fault) { > + kvm_err("Unexpected L2 read permission error\n"); > + return -EFAULT; > + } > + > + ret = kvm_gmem_get_pfn(kvm, memslot, gfn, &pfn, &page, NULL); > + if (ret) { > + kvm_prepare_memory_fault_exit(vcpu, fault_ipa, PAGE_SIZE, > + write_fault, exec_fault, false); > + return ret; > + } > + -EFAULT or -EHWPOISON shall be returned, as documented in virt/kvm/api.rst. Besides, kvm_send_hwpoison_signal() should be executed when -EHWPOISON is returned from kvm_gmem_get_pfn()? :-) Thanks, Gavin > + writable = !(memslot->flags & KVM_MEM_READONLY) && > + (!logging || write_fault); > + > + if (nested) > + adjust_nested_fault_perms(nested, &prot, &writable); > + > + if (writable) > + prot |= KVM_PGTABLE_PROT_W; > + > + if (exec_fault || > + (cpus_have_final_cap(ARM64_HAS_CACHE_DIC) && > + (!nested || kvm_s2_trans_executable(nested)))) > + prot |= KVM_PGTABLE_PROT_X; > + > + kvm_fault_lock(kvm); > + if (is_perm) { > + /* > + * Drop the SW bits in favour of those stored in the > + * PTE, which will be preserved. > + */ > + prot &= ~KVM_NV_GUEST_MAP_SZ; > + ret = KVM_PGT_FN(kvm_pgtable_stage2_relax_perms)(pgt, fault_ipa, prot, flags); > + } else { > + ret = KVM_PGT_FN(kvm_pgtable_stage2_map)(pgt, fault_ipa, PAGE_SIZE, > + __pfn_to_phys(pfn), prot, > + memcache, flags); > + } > + kvm_release_faultin_page(kvm, page, !!ret, writable); > + kvm_fault_unlock(kvm); > + > + if (writable && !ret) > + mark_page_dirty_in_slot(kvm, memslot, gfn); > + > + return ret != -EAGAIN ? ret : 0; > +} > + > static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > struct kvm_s2_trans *nested, > struct kvm_memory_slot *memslot, unsigned long hva, > @@ -1532,7 +1615,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > enum kvm_pgtable_prot prot = KVM_PGTABLE_PROT_R; > struct kvm_pgtable *pgt; > struct page *page; > - enum kvm_pgtable_walk_flags flags = KVM_PGTABLE_WALK_HANDLE_FAULT | KVM_PGTABLE_WALK_SHARED; > + enum kvm_pgtable_walk_flags flags = KVM_PGTABLE_WALK_MEMABORT_FLAGS; > > if (fault_is_perm) > fault_granule = kvm_vcpu_trap_get_perm_fault_granule(vcpu); > @@ -1959,8 +2042,12 @@ int kvm_handle_guest_abort(struct kvm_vcpu *vcpu) > goto out_unlock; > } > > - ret = user_mem_abort(vcpu, fault_ipa, nested, memslot, hva, > - esr_fsc_is_permission_fault(esr)); > + if (kvm_slot_has_gmem(memslot)) > + ret = gmem_abort(vcpu, fault_ipa, nested, memslot, > + esr_fsc_is_permission_fault(esr)); > + else > + ret = user_mem_abort(vcpu, fault_ipa, nested, memslot, hva, > + esr_fsc_is_permission_fault(esr)); > if (ret == 0) > ret = 1; > out: