From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA89C433DF for ; Fri, 21 Aug 2020 07:15:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0641207DA for ; Fri, 21 Aug 2020 07:15:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="djeDcFTD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0641207DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3CB668D000D; Fri, 21 Aug 2020 03:15:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3560F8D0006; Fri, 21 Aug 2020 03:15:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CEF38D000D; Fri, 21 Aug 2020 03:15:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 004138D0006 for ; Fri, 21 Aug 2020 03:15:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 97158180AD81F for ; Fri, 21 Aug 2020 07:15:15 +0000 (UTC) X-FDA: 77173714590.18.roll76_1b0831e27037 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 6A36E100EC66E for ; Fri, 21 Aug 2020 07:15:15 +0000 (UTC) X-HE-Tag: roll76_1b0831e27037 X-Filterd-Recvd-Size: 8115 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 07:15:14 +0000 (UTC) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07L74WiJ062821; Fri, 21 Aug 2020 03:15:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=70UOR7nwFWRkCla2CKkYVciZ4+/nBYafjOfMpFHZ8cY=; b=djeDcFTDA7g1IMXDyeg5ApBicF2cMO3N19HAljOEuS3XwwE/01W6+y9wv+dI7iWMICIu eyTfcSbTaZqCJhl0J2Kx0sGtD6Xjtjty2p/4Eu8aAngUzB0H2mVyiPeXvDjQ7q6bfrIJ 2jvaXmVce3CyWCzm0Qic22cqgW54eFwgQBY5rzLLn/XoZGhVvwb6Fok1Wy0vQ/2o9iih n7+rbjl90BV27Nz9BfO3gHiS0o/g1NkLXP3ScLsGbXQC/N07/bI+lTzuhFvbsGrpK3Ec VobkL8ZwRnPKW2Z44sgqiarDgTmbkgOii0a5la8nWceizTSEYrskreq6Z29TCvqTm4gH KA== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3329c98hr8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 03:15:00 -0400 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07L7AJd2012891; Fri, 21 Aug 2020 07:14:58 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma03ams.nl.ibm.com with ESMTP id 3304um41qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 07:14:58 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07L7Eusl28901636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Aug 2020 07:14:56 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F326FAE045; Fri, 21 Aug 2020 07:14:55 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C2622AE04D; Fri, 21 Aug 2020 07:14:54 +0000 (GMT) Received: from [9.102.2.201] (unknown [9.102.2.201]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 21 Aug 2020 07:14:54 +0000 (GMT) Subject: Re: [PATCH v2 07/13] mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update an existing pte entry To: Christophe Leroy , linux-mm@kvack.org, akpm@linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org, Anshuman Khandual References: <20200819130107.478414-1-aneesh.kumar@linux.ibm.com> <20200819130107.478414-8-aneesh.kumar@linux.ibm.com> From: "Aneesh Kumar K.V" Message-ID: <3d966519-0a6b-3ccb-fd21-b7f06c8e4df7@linux.ibm.com> Date: Fri, 21 Aug 2020 12:44:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-21_05:2020-08-19,2020-08-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 spamscore=0 priorityscore=1501 mlxlogscore=671 impostorscore=0 mlxscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008210065 X-Rspamd-Queue-Id: 6A36E100EC66E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/20/20 8:02 PM, Christophe Leroy wrote: >=20 >=20 > Le 19/08/2020 =C3=A0 15:01, Aneesh Kumar K.V a =C3=A9crit=C2=A0: >> set_pte_at() should not be used to set a pte entry at locations that >> already holds a valid pte entry. Architectures like ppc64 don't do TLB >> invalidate in set_pte_at() and hence expect it to be used to set=20 >> locations >> that are not a valid PTE. >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> =C2=A0 mm/debug_vm_pgtable.c | 35 +++++++++++++++-------------------- >> =C2=A0 1 file changed, 15 insertions(+), 20 deletions(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 76f4c713e5a3..9c7e2c9cfc76 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -74,15 +74,18 @@ static void __init pte_advanced_tests(struct=20 >> mm_struct *mm, >> =C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte_t pte =3D pfn_pte(pfn, prot); >> +=C2=A0=C2=A0=C2=A0 /* >> +=C2=A0=C2=A0=C2=A0=C2=A0 * Architectures optimize set_pte_at by avoid= ing TLB flush. >> +=C2=A0=C2=A0=C2=A0=C2=A0 * This requires set_pte_at to be not used to= update an >> +=C2=A0=C2=A0=C2=A0=C2=A0 * existing pte entry. Clear pte before we do= set_pte_at >> +=C2=A0=C2=A0=C2=A0=C2=A0 */ >> + >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pr_debug("Validating PTE advanced\n"); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ptep_set_wrprotect(mm, vaddr, ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D ptep_get(ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(pte_write(pte)); >> - >> -=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> -=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ptep_get_and_clear(mm, vaddr, ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D ptep_get(ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pte_none(pte)); >> @@ -96,13 +99,11 @@ static void __init pte_advanced_tests(struct=20 >> mm_struct *mm, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ptep_set_access_flags(vma, vaddr, ptep,= pte, 1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D ptep_get(ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!(pte_write(pte) && pte_dirty(p= te))); >> - >> -=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> -=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ptep_get_and_clear_full(mm, vaddr, ptep= , 1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D ptep_get(ptep); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pte_none(pte)); >> +=C2=A0=C2=A0=C2=A0 pte =3D pfn_pte(pfn, prot); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pte =3D pte_mkyoung(pte); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_pte_at(mm, vaddr, ptep, pte); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ptep_test_and_clear_young(vma, vaddr, p= tep); >> @@ -164,9 +165,6 @@ static void __init pmd_advanced_tests(struct=20 >> mm_struct *mm, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmdp_set_wrprotect(mm, vaddr, pmdp); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(pmd_write(pmd)); >> - >> -=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> -=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmdp_huge_get_and_clear(mm, vaddr, pmdp= ); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_none(pmd)); >> @@ -180,13 +178,11 @@ static void __init pmd_advanced_tests(struct=20 >> mm_struct *mm, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmdp_set_access_flags(vma, vaddr, pmdp,= pmd, 1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!(pmd_write(pmd) && pmd_dirty(p= md))); >> - >> -=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> -=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmdp_huge_get_and_clear_full(vma, vaddr= , pmdp, 1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmd =3D READ_ONCE(*pmdp); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(!pmd_none(pmd)); >> +=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkhuge(pfn_pmd(pfn, prot)); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmd =3D pmd_mkyoung(pmd); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_pmd_at(mm, vaddr, pmdp, pmd); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pmdp_test_and_clear_young(vma, vaddr, p= mdp); >> @@ -283,18 +279,10 @@ static void __init pud_advanced_tests(struct=20 >> mm_struct *mm, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 WARN_ON(pud_write(pud)); >> =C2=A0 #ifndef __PAGETABLE_PMD_FOLDED >=20 > Same as below, once set_put_at() is gone, I don't think this #ifndef=20 > __PAGETABLE_PMD_FOLDED is still need, should be possible to replace by=20 > 'if (mm_pmd_folded())' I would skip that change in this series because I still haven't worked=20 out what it means to have FOLDED PMD with=20 CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD. We should probably push that as a cleanup later and somebody who can=20 test that config can do that? Currently i can't boot ppc64 with=20 DBUG_VM_PGTABLE enabled on ppc64 because it is all buggy w.r.t rules. -aneesh