From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8EB6C433DB for ; Wed, 24 Mar 2021 12:33:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 804B2619B6 for ; Wed, 24 Mar 2021 12:33:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 804B2619B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB2186B02C0; Wed, 24 Mar 2021 08:33:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E62DF6B02C1; Wed, 24 Mar 2021 08:33:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D01C26B02C2; Wed, 24 Mar 2021 08:33:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id B23306B02C0 for ; Wed, 24 Mar 2021 08:33:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 65A135DDB for ; Wed, 24 Mar 2021 12:33:10 +0000 (UTC) X-FDA: 77954707740.02.EEEC5BD Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 4F918200025F for ; Wed, 24 Mar 2021 12:33:09 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id o126so22179425lfa.0 for ; Wed, 24 Mar 2021 05:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ETqBMU69OiVYdMvCczpxH6iSVMFBbrvvC1c+Nearczk=; b=XypW53avmJ4g2E1pKslW36bigwllw9bzame6yU/kPt6JgEqriLu1KCO3Usk1g6d6pR hgWgRfZ4sFu3UglyoEsbQgwrdXnDY0ygCkG1ChPaSYVxVKMtr0aFVa8CZQiJVKTPdPns IsPOu6DtiVIbhj7laA0Wftj3art0pxx0RlAr0j7Hfbs9RoBlqXZFWgmuPaxCVHYSk5zZ az0nvJlTD9fgs0TngACy8f0K6oqGqnPkxFYDhAt8NnmKaCGo+rOazlGEoKNQBFMk73Vv gZhZk7sOA+P7zWKLfDJvfDIJg5LhW6ZQe/5Km5QSehqd76nQnNOFn6Svum3niOluJClx gpgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ETqBMU69OiVYdMvCczpxH6iSVMFBbrvvC1c+Nearczk=; b=fRxa9/anAB9cGFbNYIZ3PJgZuRnqG5WKLOVsfSUaofw0ULxowGLz0mxirjomvbdGjd D+JgnIBekgP2UBiMN6oqzt3oNewLzrHek00qS4iIaeqtKpwaDTNCRqOwNFe+PZUXKcXF 9T2C90wN01dtO4w/ACuP6OLFgMS2qn4TtT9yrSVT1Skwv6srqFxVXwamFSZp/8lYkNhE 0YNkR9IPwfYzfQaLN4VDBfcjIP6BTaJ/3tQcv+TontYGGJunTKrPDa63nwmJQh6b1GxG 1DQXOPrkjHTqrRN8P4wTWt8klN0vZIQnS96w945Zp0uTCfBGg8+8MH0jhEnTYDtbgY0G CX2Q== X-Gm-Message-State: AOAM531wMp8bAhxT5arfRHVitMUt9hBvd+rnczw0d+jpBhVgXR/hD4gs Gr/9YQp7Gg4gauemo8DgzCQ= X-Google-Smtp-Source: ABdhPJzKeCr5gBrukru+Rp9XMBBi9uUxkaJnWxEsEaxThFvI60q4T0jOf+vT8goDZgzawCC9To6XSQ== X-Received: by 2002:ac2:4826:: with SMTP id 6mr1830392lft.629.1616589188609; Wed, 24 Mar 2021 05:33:08 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-60.dynamic.spd-mgts.ru. [109.252.193.60]) by smtp.googlemail.com with ESMTPSA id h24sm295528ljg.77.2021.03.24.05.33.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 05:33:08 -0700 (PDT) Subject: Re: [PATCH v6] mm: cma: support sysfs To: Minchan Kim , Andrew Morton Cc: linux-mm , LKML , gregkh@linuxfoundation.org, surenb@google.com, joaodias@google.com, jhubbard@nvidia.com, willy@infradead.org References: <20210324010547.4134370-1-minchan@kernel.org> From: Dmitry Osipenko Message-ID: <3d90177b-e143-03b9-0f78-77740690266f@gmail.com> Date: Wed, 24 Mar 2021 15:33:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324010547.4134370-1-minchan@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4F918200025F X-Stat-Signature: odzu9nhzttzj78xy5ow5pf84ku36ps5w Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-lf1-f49.google.com; client-ip=209.85.167.49 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616589189-539149 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 24.03.2021 04:05, Minchan Kim =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > +static struct kobject *cma_kobj_root; This should be a local variable. > +static struct kobj_type cma_ktype =3D { > + .release =3D cma_kobj_release, > + .sysfs_ops =3D &kobj_sysfs_ops, > + .default_groups =3D cma_groups I'd add a comma to the end, for consistency. > +};