From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B16C433F5 for ; Fri, 17 Sep 2021 10:44:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE31C611F2 for ; Fri, 17 Sep 2021 10:44:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE31C611F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 297D3900002; Fri, 17 Sep 2021 06:44:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 246DE6B0072; Fri, 17 Sep 2021 06:44:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E994900002; Fri, 17 Sep 2021 06:44:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 002C36B0071 for ; Fri, 17 Sep 2021 06:44:08 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9D512824556B for ; Fri, 17 Sep 2021 10:44:08 +0000 (UTC) X-FDA: 78596730576.11.11031A8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 3BD3D505D859 for ; Fri, 17 Sep 2021 10:44:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631875447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Z9qLUq2BDHVt4FxNaULEqhyuGeSzzXMfrlMb+du88M=; b=U/xy9wy9ZRhPkQkLLP/ACSyJ+LpVAYSg3FVtgCJW4STVgZ/mlN78mbMW1Bi/QLiQG6tGEY 3NhyBU7VfomnlWcKrvHSOXnWB7CE4CSDjpyKuLtkExQf5yfMPQ1OVghhHniOoLS5wr1xQk SB1zvQihJuUwnK82UnBYcY+p+528BOc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-Oy_kUya8M4Skk2C0Rk6LoA-1; Fri, 17 Sep 2021 06:44:06 -0400 X-MC-Unique: Oy_kUya8M4Skk2C0Rk6LoA-1 Received: by mail-wr1-f71.google.com with SMTP id f7-20020a5d50c7000000b0015e288741a4so3566420wrt.9 for ; Fri, 17 Sep 2021 03:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+Z9qLUq2BDHVt4FxNaULEqhyuGeSzzXMfrlMb+du88M=; b=N0stStY2VI7wbj87nMrdZjZa0GyV5i9JL0/goXDvmh5qN/c7SUWLYsWiKEsGqp7cah p/ZPrGTrYy3z85vVK2wRYBC9ZYjw1corJfZkUzzNpYeKwUh5WZ8QRO5SuANOUnLo/7V6 OxsJtiBpbqwXhVz6LiP8iYdz9UVTDHfPylAFoUeM7HNMWsH3ar9EyJ9baYryZRn6Nb5t 9GqmXnemxhtsStaPkuwo2xThOlbITeBCormFNaryEfLJ/c3u1ekG6XAeF5iIpeovKhpN KNX70fD+3CD/m86feb5+AspJgs38cWifwVlObnIkjd3A3hj3+61+mamzv3jY5b2WF18g kdzg== X-Gm-Message-State: AOAM532x1mx6SJgkHzNZg0Gz1nn9QG9MptzP3/ddy+m5GZSk5Az+xdBb EdRQHad9Sp4zphoW7cmxImXGb6aatTw6YXy1CekmtqNZslP7TlfaPx/8jKiIaPZtDCYhXb38D1e w3TDo9J+Pwug= X-Received: by 2002:adf:d20f:: with SMTP id j15mr11321957wrh.255.1631875445514; Fri, 17 Sep 2021 03:44:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE438hv18Je6b3QHkYkAkmfbBOZU0BAmfYzed/MwXxbBg06Zs0/ToFExpbdRJcJoTZ7+EQDw== X-Received: by 2002:adf:d20f:: with SMTP id j15mr11321936wrh.255.1631875445322; Fri, 17 Sep 2021 03:44:05 -0700 (PDT) Received: from [192.168.3.132] (p5b0c655a.dip0.t-ipconnect.de. [91.12.101.90]) by smtp.gmail.com with ESMTPSA id c30sm6329698wrb.74.2021.09.17.03.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 03:44:04 -0700 (PDT) Subject: Re: [PATCH] mm/memcg: Drop swp_entry_t* in mc_handle_file_pte() To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox References: <20210916193014.80129-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <3d8d2411-9de3-5a87-da7c-8b268e933346@redhat.com> Date: Fri, 17 Sep 2021 12:44:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210916193014.80129-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3BD3D505D859 X-Stat-Signature: c6f3bq89kirzj3564njnc8586rcu4h9h Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/xy9wy9"; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1631875448-378460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.09.21 21:30, Peter Xu wrote: > After the rework of f5df8635c5a3 ("mm: use find_get_incore_page in memcontrol", > 2020-10-13) it's unused. > > Cc: Matthew Wilcox > Signed-off-by: Peter Xu > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b762215d73eb..12fa08e216a6 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5555,7 +5555,7 @@ static struct page *mc_handle_swap_pte(struct vm_area_struct *vma, > #endif > > static struct page *mc_handle_file_pte(struct vm_area_struct *vma, > - unsigned long addr, pte_t ptent, swp_entry_t *entry) > + unsigned long addr, pte_t ptent) > { > if (!vma->vm_file) /* anonymous vma */ > return NULL; > @@ -5728,7 +5728,7 @@ static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma, > else if (is_swap_pte(ptent)) > page = mc_handle_swap_pte(vma, ptent, &ent); > else if (pte_none(ptent)) > - page = mc_handle_file_pte(vma, addr, ptent, &ent); > + page = mc_handle_file_pte(vma, addr, ptent); > > if (!page && !ent.val) > return ret; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb