From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9F9C7883B for ; Fri, 20 Sep 2024 12:59:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A41366B0082; Fri, 20 Sep 2024 08:59:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F0CA6B0083; Fri, 20 Sep 2024 08:59:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8CC6B0085; Fri, 20 Sep 2024 08:59:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A9746B0082 for ; Fri, 20 Sep 2024 08:59:24 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E0E63120353 for ; Fri, 20 Sep 2024 12:59:23 +0000 (UTC) X-FDA: 82585122606.29.B515166 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf09.hostedemail.com (Postfix) with ESMTP id EAE0E140009 for ; Fri, 20 Sep 2024 12:59:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GhcBFxxX; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.49 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726837046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W0hP89T635eug0SQzdhHFuUzTKbWOKYLiIcD5q3T0mM=; b=iDT6qjdNHXUc74d7rXK147u+x2lwMvQMPJEObNsZwOkVGNShexV3GsV3GLMD6GZ18Nbo5Y xe/+pOcRo56PY9hvsn396t9ks/3iiKvPB6xJ32kf6pbe3/U5gFZmZ6Wr6Q68ig2vp/MJU9 94URE8cjIzCIaJo3RuQxQEF4EuyQfPE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726837046; a=rsa-sha256; cv=none; b=MSivBsycDXjAFlAK9RssgdOEOutMCrrms7ewlzCBBnyTiiNYnUFv5YtJ092WvKYVH+JlwB /m0fOsysKqDQJO7l7IHlJheHK0US783DXH9v5BkOGcH833UhUHkicjj2PUC+C2kgjFLtAN AgytGhTi4sgtwZQr7LRL1UI5XgJ/vaw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=GhcBFxxX; spf=pass (imf09.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.49 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-82cda617e1aso110252639f.2 for ; Fri, 20 Sep 2024 05:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1726837160; x=1727441960; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W0hP89T635eug0SQzdhHFuUzTKbWOKYLiIcD5q3T0mM=; b=GhcBFxxXpuuhYeeW3EM8ch6/tOZ8B7v+dN2hGNl/BPdS7Bjc2cJdX3znpTrPCDJHJb Ke2HbQbTk0cCaCobIpkg5YvlVb9gK6jGDuT1uxmZ74d4GPpGnUnD1qAXxeOQmB3fbAuJ CihHrqcSYeMyq7hdrU0d9YmVLfYlpfvl5CEzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726837160; x=1727441960; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W0hP89T635eug0SQzdhHFuUzTKbWOKYLiIcD5q3T0mM=; b=O6xOwb4lQ/hyEkiJnac+VS0EHHYWVQ4TQeXNIkVL3HhG5IN2khuqA4RV6uFvl5kpuK 2exbQ/wlHxkiUw2diCAvtI1moyBvw8w73oupyAIFzNU8LOGJIRKxk19ZjSkv6OXd2rVT stsT7MoQwPf1kfVej3S7AORgHHzKkwk0AY4FiK8OLTb8MCaqTmE+o1Y8Tm5/YTXhAgZR vhVQ3N3MMHFxd5M6+R7Z5aZ+5CKrmGb69gKLftPxo0HVr+xwLEZ3C0n/Un/ufW54pMl6 NrS32XADy68323kJt1dUT0sCzp8LLxQ4jVkC4GAreCwu9azYNmyKYXeDiFg77Liim+NC buBQ== X-Forwarded-Encrypted: i=1; AJvYcCV/CHQ0GpNeoevVzbqpJZRXATuZyn197NWRlHWz0X8+RHaTdI0Xs0rT+MwmDYgH3zMrpb0xZV355g==@kvack.org X-Gm-Message-State: AOJu0YzFwxxctTWyOprsmiKvcDNO2GHibJDp3vXk6w/plgU+O4mBTthM VKr/Gcn1YA/EPQrdHQFjgwYiV7kjBuidBRDpAiDgXyLN2qzGD8trcODMO9+bRDs= X-Google-Smtp-Source: AGHT+IGF6z+FwKs6Ow9z55WL2jKZTmbVonx4GKN4imUz/2x6f8q9f1nEgxtWtd14C01WEykOqTVEbQ== X-Received: by 2002:a05:6602:341d:b0:82d:79b:ee8d with SMTP id ca18e2360f4ac-8320b2841femr233896639f.4.1726837159804; Fri, 20 Sep 2024 05:59:19 -0700 (PDT) Received: from [10.212.145.178] ([12.216.155.19]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-82d49338509sm382912439f.34.2024.09.20.05.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Sep 2024 05:59:19 -0700 (PDT) Message-ID: <3d89dd5c-549e-4f40-8d5d-3ef71b1f58d8@linuxfoundation.org> Date: Fri, 20 Sep 2024 06:59:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/mempolicy: fix comments for better documentation To: Tanya Agarwal , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, anupnewsmail@gmail.com, Shuah Khan References: <20240914151801.4388-1-tanyaagarwal25699@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240914151801.4388-1-tanyaagarwal25699@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EAE0E140009 X-Stat-Signature: uxedo3c6cbfe55id7or49tipr15ifpu8 X-HE-Tag: 1726837160-848524 X-HE-Meta: U2FsdGVkX19DzXE2KJEUp9EsSVw+MLm2Kqek3FBW6vJeKUe4dkeplge2XFS7/KGqIILUodvGW3zE3523AAaHX0hHNPwSOgcpL5UlTTphrsT4gVTKWEh8Wmo46efEdQYsA6t7MCAJEIP6Z0ITbbTvTRjTaiy4vw68FXIkYrS1nYEQ6xWu16W7I3n0+2ohUBbq2eWSuEPMAflGprngZ+MLTDEod3ETzw+qbPzNl7BqWjR7GD27KGPuvmyHFCf5TYWZg+jaBkEenNDOtwCjMVbqXVRJfq9jDVA05E7+TIiwvOZrDQMShhd2MwZxeR/t43CAoaGPo2dGiRzQPq32jZrFICf72lSjrlq4Uv1GspE1BUrJFz/vo+7Njpb4pkDdW1voAXRTvldNFf9msRw7I3cHc75JADPvznS7rLJaq2YcjqKwuLX40ea0DalBdOBfV0MxzOLOkQNRJDBI06LLH8JarsSvybjRp0UbxQOn6qMfuREhgcerDENdeIQf4fCCKoxmb++lSAh4Pesk9Dnnh4b2goiY7+XRb3Y9XtFcwb4TAOt5w3WAFirlU0xpCjPV9JEf4wPQiyvgzNgIKQPor8etadogilSEMp5PK4mGafV/pVIVBr+hn7uYD1GfvSwA+hzM4CqfxO2J/Fk3uIMIbt8AmZdGKmffLhWnYAARlSLNW1WLmwf8LHz3GyIluJgXIMRrskmn/mjiuKpmcu2zog47XZTMZmFoUOMUMmh0RhJ2ohwBeHYnyM3LnE2OIa3nQmvAfJrN5nXYl2sNUr62Jhb0oXYkNTM9LsbjEZokisYuf70FYfDfLJowXO2qHPfKj8Vmcw4iC2FALG2z8a1IYDj9ciKMqgPKdYwWo38kLT7hfUB221QThJc6ylRbAXiZk1CNkytBd+JVN83IdPpy/Og0e1XSMeIrLfMK7oXGT6nRlQxaLuw3Ohb3BcX2alhL5Zq/rNhR4gpX/aVESUAu6X7 ukWvj6X+ YBYeS9ERnDJc5vwiFlCWX3S2CIwih6xZqtE2t2hG24idF1X1FtCOdCd7qRO/we7RWCRI/SrTYKvWcfUKASSn004IjW4YUftm/lr3tVAJu2ZlIt7CXmTr+p3QU5xputL6eLf4mkRNwWmiUC26zZQZBu18+uH6R3KNh0sC4bNeLX5r3aIwwwWX15eXVFjxnlicZ5YgVoNiEDblQ9rInbNYeSYrX3IKM5myNGxLyQQFK00n+F64tdKAkScTBhOT0ynGhncCYFdQMb7DzQarNehe9KM8c+fIbtpqxwKTFQNWuTLA+OlM1Qdn5oTc+1vCxgjO5+d3TTZZydZMPpmyN3iPEHUuLER41vqcGCiTtly0+NC4WSoljhDuabN7rjYhsZJkNC1LR3nPlIKNYE8rTS3prtvfe9B28bjIIo1LH0fmbkTXWu5//j6hytnwpwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/14/24 09:18, Tanya Agarwal wrote: > From: Tanya Agarwal > > - Fix typo in mempolicy.h > - Correct the number of allowed memory policy You don't need to say 1/1 for a single patch. Please write changelog in paragraph form. Also mention how you found the problem and include putput from the tool to find the problem. > > Signed-off-by: Tanya Agarwal > --- > include/linux/mempolicy.h | 2 +- > mm/mempolicy.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h > index 1add16f21612..ce9885e0178a 100644 > --- a/include/linux/mempolicy.h > +++ b/include/linux/mempolicy.h > @@ -47,7 +47,7 @@ struct mempolicy { > atomic_t refcnt; > unsigned short mode; /* See MPOL_* above */ > unsigned short flags; /* See set_mempolicy() MPOL_F_* above */ > - nodemask_t nodes; /* interleave/bind/perfer */ > + nodemask_t nodes; /* interleave/bind/preferred/etc */ > int home_node; /* Home node to use for MPOL_BIND and MPOL_PREFERRED_MANY */ > > union { > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index b858e22b259d..613fdb73c404 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -8,7 +8,7 @@ > * NUMA policy allows the user to give hints in which node(s) memory should > * be allocated. > * > - * Support four policies per VMA and per process: > + * Support six policies per VMA and per process: > * > * The VMA policy has priority over the process policy for a page fault. > * With these fixed: Reviewed-by: Shuah Khan thanks, -- Shuah