linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Tanya Agarwal <tanyaagarwal25699@gmail.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	anupnewsmail@gmail.com, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/1] mm/mempolicy: fix comments for better documentation
Date: Fri, 20 Sep 2024 06:59:17 -0600	[thread overview]
Message-ID: <3d89dd5c-549e-4f40-8d5d-3ef71b1f58d8@linuxfoundation.org> (raw)
In-Reply-To: <20240914151801.4388-1-tanyaagarwal25699@gmail.com>

On 9/14/24 09:18, Tanya Agarwal wrote:
> From: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> 
> - Fix typo in mempolicy.h
> - Correct the number of allowed memory policy

You don't need to say 1/1 for a single patch.

Please write changelog in paragraph form. Also mention how you found
the problem and include putput from the tool to find the problem.

> 
> Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
> ---
>   include/linux/mempolicy.h | 2 +-
>   mm/mempolicy.c            | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
> index 1add16f21612..ce9885e0178a 100644
> --- a/include/linux/mempolicy.h
> +++ b/include/linux/mempolicy.h
> @@ -47,7 +47,7 @@ struct mempolicy {
>   	atomic_t refcnt;
>   	unsigned short mode; 	/* See MPOL_* above */
>   	unsigned short flags;	/* See set_mempolicy() MPOL_F_* above */
> -	nodemask_t nodes;	/* interleave/bind/perfer */
> +	nodemask_t nodes;	/* interleave/bind/preferred/etc */
>   	int home_node;		/* Home node to use for MPOL_BIND and MPOL_PREFERRED_MANY */
>   
>   	union {
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index b858e22b259d..613fdb73c404 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -8,7 +8,7 @@
>    * NUMA policy allows the user to give hints in which node(s) memory should
>    * be allocated.
>    *
> - * Support four policies per VMA and per process:
> + * Support six policies per VMA and per process:
>    *
>    * The VMA policy has priority over the process policy for a page fault.
>    *

With these fixed:

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah


      reply	other threads:[~2024-09-20 12:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-14 15:18 Tanya Agarwal
2024-09-20 12:59 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d89dd5c-549e-4f40-8d5d-3ef71b1f58d8@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=anupnewsmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tanyaagarwal25699@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox