From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E284EC4345F for ; Thu, 2 May 2024 13:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B1966B007B; Thu, 2 May 2024 09:08:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 261606B0082; Thu, 2 May 2024 09:08:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 102C36B0083; Thu, 2 May 2024 09:08:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E5E796B007B for ; Thu, 2 May 2024 09:08:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 991C11A0E11 for ; Thu, 2 May 2024 13:08:29 +0000 (UTC) X-FDA: 82073484738.03.A629DE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 465FE2000B for ; Thu, 2 May 2024 13:08:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=caulvv9f; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714655307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ylGHOp62O7s37wB6m2TxWSrAjoDqOAFGMczJ+VHsbgs=; b=jAt42G4rMyYPTivwRlu4Ay+4Ul95a6F7Z8yucPUquMTomfyTb0tMeRqVyCbSRgBXfItHbR rALS0i1ft0jMp/xIVnhEHHrN121GRHvRXqyaJvCf6fUfF+fS+0/d5CDGRU9XfTN2Kb+J9a 1hAyrYG5FIkK9edzLZZjQ6okNKIDeNU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=caulvv9f; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714655307; a=rsa-sha256; cv=none; b=Mou9rbxwVLdFRTHlIaAkkUM9r1ly6RT3RJ24lVnPeslaWdlRNAeaJ8pZYYJTLNZhmQqrk3 W5mbUXmClM7Ej5Nn/VePX06WmcM0CFbZM7lIE4flxCyl0Rc6p4XruaLMKK7nD/ECU7Aq5O 8wabO+otwkRNGZsIscuce3lsrLsv6ag= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714655306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ylGHOp62O7s37wB6m2TxWSrAjoDqOAFGMczJ+VHsbgs=; b=caulvv9fPuHLM6icWJsj8bY0WJdgLJpmxd/Mcvyn2hLE9dcfJKe0J4VNLlbs+pAPp0pRT4 hoGeYrxUoCf+KJsQ/bNcuTWhlv9AlYUoGqTefrQ0bZRuY4spM+WuzsKU8wTRzMT6Mo/5vP CHbCpwZRdWvHu/zdBzKN+GKGTtqDKeg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-iOvctoYWPjuhJEHofxtkYQ-1; Thu, 02 May 2024 09:08:24 -0400 X-MC-Unique: iOvctoYWPjuhJEHofxtkYQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-34d91608deaso1533589f8f.0 for ; Thu, 02 May 2024 06:08:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714655303; x=1715260103; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ylGHOp62O7s37wB6m2TxWSrAjoDqOAFGMczJ+VHsbgs=; b=KXVE7FYcQpd5KShJFL3xUhcYUAVOQle+5jcYvJMUltz7q4NgH+JSPlsCsJqe1APizL z9ioKXny7v6uzh4jDL6lIBS2mi58LtyzDNqS95Evf4SJrZmF7Aeotxk9LLswfCcCw6gS Wm0bEDEtthxisM6MVC3qwFGrTZVpP12NyuAt5aiZfqoflCNZpPkBvqud14BOFUIbMCiZ CaIPDMzkmXMyro3ANgcnTmgILYz+wr8QqNDFBtl0g3nMhQxo8fN4EQoN6fEU3CkIK/EI aCJu0RojUQ1VI06u+LBQ4INN2msNhEYKKRSGPNbhGGPqUOuUBV7EofXcdsTKjBGHkymi 91tg== X-Forwarded-Encrypted: i=1; AJvYcCVqWaoo0nFnh2h8gPYfBffDaRGgHGNy9//rIXi8B70FEY+KtSCQJ87qgmrSK55TpJoV46HZBDPEvifFHyfd92ys3cI= X-Gm-Message-State: AOJu0Yy4RJwoMQfV/sS85pcRQPrKvPcGK+rs+hWNOQ6Zc4i8buiSvg8D FVC7Ti+XJw8jmEU7uKb071hI9XSO5/mHa1jrOlAhWgmYUbwNi1xWTQnoiuWiWbsHOzWSrsnQO/W 7uA59cbzmTJVPrf3Sbij9O+tgSmJpm/cYELCqYsesFHHjeO1z X-Received: by 2002:adf:f98e:0:b0:34d:a1fb:8f73 with SMTP id f14-20020adff98e000000b0034da1fb8f73mr3886726wrr.4.1714655302886; Thu, 02 May 2024 06:08:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfLT78sbXYQRxgwK2Hy1T4Th/2e9EhWCInI4nKulB33e+Jnf3IyyQTLTOz97wAG24nnpNYBQ== X-Received: by 2002:adf:f98e:0:b0:34d:a1fb:8f73 with SMTP id f14-20020adff98e000000b0034da1fb8f73mr3886686wrr.4.1714655302365; Thu, 02 May 2024 06:08:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676? (p200300cbc71ebf00eba13ab9ab0fd676.dip0.t-ipconnect.de. [2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676]) by smtp.gmail.com with ESMTPSA id dn2-20020a0560000c0200b0034e14d59f07sm1240196wrb.73.2024.05.02.06.08.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 06:08:21 -0700 (PDT) Message-ID: <3d88297b-ce6f-4b97-8a25-75f0987af6fd@redhat.com> Date: Thu, 2 May 2024 15:08:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: Fix race between __split_huge_pmd_locked() and GUP-fast To: Ryan Roberts , Andrew Morton , Catalin Marinas , Will Deacon , Mark Rutland , Anshuman Khandual , Zi Yan , "Aneesh Kumar K.V" , Jonathan Corbet , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Felix Kuehling References: <20240501143310.1381675-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240501143310.1381675-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: t17m354d913am17h8tkehjet9a1jjdtt X-Rspamd-Queue-Id: 465FE2000B X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714655307-359499 X-HE-Meta: U2FsdGVkX185g5cOVfiF/bQwobE8rMFI0XAh2MjufCUjbKDYqL0UfAmawyhzZsZUtCZHinDwy8q3ZoPeCCDSnHb+WYXBfW7CpczX8OujT2Ca05zMQToQx1jpWJr5vuW9RLC1+Ff4YK2aREmfsI2/qkmqZT5P1dt53g8O6tkmje9z2w6Omb+UgJ9nALijuqAAqnuUgXBOaKSLrWDAfQLcNSeTd8nuuQgHwIW85OMDLNxNPqrnvBG0BjnsBIi57Kw0/Dt9mfmgjv+CYsdY+D9czIyrPdbekLnrxY1a04IuwG12I413pCqxYBXB5UFja4c+FYlk+bStwpcTqiwmKyJVtYwvU/+mFNoxoZ1xdcxpI5VzUR4AuCJtcwbDnPKl0M2p2IDMiZ4lMAQ3dRBqiyXpFg/wk2FVnqBBrq5ueZGMDOlUnhkW9YS7/7N1sAN+M2/11x0biBTLSoMGQo3eUAEL2R/iVNGGuh6uhjTENm6l0lAjfDQKo6HYUcIJEnlAKo5BpfSs0rLn2jMohu7AGPA07e1V0n7tsqHGR/Ntru2d6HsXugKEx5LTUaqJMrC8ChujSYtx3UL7KOeej31f4Eq3tAHDHeYRmv9CGEGgwxaoNKs8X2btGXLttt3YdT6K+VNDneq562+JOtXpPjRNQAVuocC0eXGxuF7gjKxFdgicfBiqL+FH08He8U1eymTKlsjmSxyAaAyL/iX5kGb8nkAhcJvyY9q5IsLo49cSf85OAxpOiLKaMLa+uZRCT3pEZJ2EEUq4Oa7045/yNSAlRRhXiTqRwHSFZ86y4EnGg9Mygdx6m35xb6bUOACUafyacSRexkxB0t2xbzIrdWIFuFNWdAboz6uaSDWEtaV/HHh9X6frHKdYk5onO6j8VEJVICkkU7+z4NbLbTaSU7eaUg2SqI4SMaDLTurpveUfuxvDlXuJTR+JyZTY68ycv4slwp2t49EyaaDT6TPt0Sw2L69 q2Z/qXpx svJAk/3tR6Y2Tu0Icju14bFilE6ubUYFePWV8T+1wfxfYAW02u3RW626W1mTOSk1Wxb0s+m9fAm6SU3RYcoa8nBaVx2r37nt7WNZVUH68G3B7n5By97Do8r9z2GhgLgoRlzsj6nrYjtNDK6DISkRWswyxczhjh9XDB5w382OV3updZl0WDVdUcmdziMFCWFr37rCRz7KZTWjdT3SfWlU2wR+ZOQbFsboP6ZeIbyFmJwhNuVk79ffGvgO9GK2wItREVaeBVJZcOHKfRviLM4SJukdF6dhX/hlUBX5lCKxB1TMnKFG25td5nO2fzLjTlGUYLKiMMqT4qIpNJCPv7eGZHReGwQEbnt5IyfONCqSAfLaRxZ0Svf6wXCBLHYuLmysARYaRLDMC/G8BcYEVj+INxg8HvMbViaSfT29gToM9bYIed0XeQAhnGlWdN4qt62Zf7P40ofopn06t2AQ4WCCAeiDbBVTLl4erSHud6PCileIrazTcxix5p/e/4XxhAaZO+WQ54+/GUsziup/E18LcZ2iqAzdpFqjNNtFbtJQTmtuwYMhrfNAvN8kGM+f22pc61YVmoNEP6kvSa01wtduwfo8pvpPqEeaWVmt/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.05.24 16:33, Ryan Roberts wrote: > __split_huge_pmd_locked() can be called for a present THP, devmap or > (non-present) migration entry. It calls pmdp_invalidate() > unconditionally on the pmdp and only determines if it is present or not > based on the returned old pmd. This is a problem for the migration entry > case because pmd_mkinvalid(), called by pmdp_invalidate() must only be > called for a present pmd. > > On arm64 at least, pmd_mkinvalid() will mark the pmd such that any > future call to pmd_present() will return true. And therefore any > lockless pgtable walker could see the migration entry pmd in this state > and start interpretting the fields as if it were present, leading to > BadThings (TM). GUP-fast appears to be one such lockless pgtable walker. > > x86 does not suffer the above problem, but instead pmd_mkinvalid() will > corrupt the offset field of the swap entry within the swap pte. See link > below for discussion of that problem. Could that explain: https://lore.kernel.org/all/YjoGbhreg8lGCGIJ@linutronix.de/ Where the PFN of a migration entry might have been corrupted? Ccing Felix Patch itself looks good to me Acked-by: David Hildenbrand -- Cheers, David / dhildenb