From: "Xu, Yanfei" <yanfei.xu@windriver.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long'
Date: Wed, 16 Sep 2020 09:56:43 +0800 [thread overview]
Message-ID: <3d7dde64-826d-e449-0ca3-6521619cdf32@windriver.com> (raw)
In-Reply-To: <20200915174855.822d866316948aadb8193e9b@linux-foundation.org>
On 9/16/20 8:48 AM, Andrew Morton wrote:
> On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@windriver.com> wrote:
>
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> try_to_free_pages returns the number of pages reclaimed, and the type of
>> returns is 'unsigned long'. So we should use a matched type for storing
>> it.
>>
>
> __perform_reclaim() returns an int, so this change is fairly pointless.
>
> However __perform_reclaim()'s single caller expects it to return
> unsigned long, so including that change in this patch would make more
> sense.
>
Yeah, thanks for reminding. I will add that and send a v2. :)
Regards,
Yanfei
prev parent reply other threads:[~2020-09-16 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:46 yanfei.xu
2020-09-16 0:48 ` Andrew Morton
2020-09-16 1:56 ` Xu, Yanfei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d7dde64-826d-e449-0ca3-6521619cdf32@windriver.com \
--to=yanfei.xu@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox